chore(quality): apply ruff autofixes and formatting (223 fixes, regression-free: 118/118 tests pass)

app/services/activity_service.py

@@ -3,7 +3,6 @@
 from __future__ import annotations
 
 from datetime import UTC, datetime
-from typing import Optional
 
 from sqlalchemy.ext.asyncio import AsyncSession
 
@@ -24,9 +23,9 @@ async def _validate_parents(
     db: AsyncSession,
     *,
     org_id: int,
-    account_id: Optional[int],
-    contact_id: Optional[int],
-    deal_id: Optional[int],
+    account_id: int | None,
+    contact_id: int | None,
+    deal_id: int | None,
 ) -> None:
     """Ensure at least one parent is set and each provided id exists in org."""
     if account_id is None and contact_id is None and deal_id is None:
@@ -35,14 +34,17 @@ async def _validate_parents(
         )
     if account_id is not None:
         from app.models.account import Account
+
         if await OrgScopedQuery(Account, db, org_id=org_id).get(account_id) is None:
             raise NoParentException(f"Account {account_id} not found in this org")
     if contact_id is not None:
         from app.models.contact import Contact
+
         if await OrgScopedQuery(Contact, db, org_id=org_id).get(contact_id) is None:
             raise NoParentException(f"Contact {contact_id} not found in this org")
     if deal_id is not None:
         from app.models.deal import Deal
+
         if await OrgScopedQuery(Deal, db, org_id=org_id).get(deal_id) is None:
             raise NoParentException(f"Deal {deal_id} not found in this org")
 
@@ -79,9 +81,7 @@ async def create_activity(
     return activity
 
 
-async def get_activity(
-    db: AsyncSession, activity_id: int, *, org_id: int
-) -> Optional[Activity]:
+async def get_activity(db: AsyncSession, activity_id: int, *, org_id: int) -> Activity | None:
     """Fetch a single activity by id."""
     q = OrgScopedQuery(Activity, db, org_id=org_id)
     return await q.get(activity_id)
@@ -93,10 +93,10 @@ async def list_activities(
     org_id: int,
     skip: int = 0,
     limit: int = 20,
-    type: Optional[ActivityType] = None,
-    owner_id: Optional[int] = None,
-    overdue: Optional[bool] = None,
-    completed: Optional[bool] = None,
+    type: ActivityType | None = None,
+    owner_id: int | None = None,
+    overdue: bool | None = None,
+    completed: bool | None = None,
 ) -> list[Activity]:
     """List activities with optional filters."""
     scoped = OrgScopedQuery(Activity, db, org_id=org_id)
@@ -110,7 +110,8 @@ async def list_activities(
     now = datetime.now(UTC).replace(tzinfo=None)  # SQLite returns naive datetimes
     if overdue is True:
         base = [
-            a for a in base
+            a
+            for a in base
             if a.due_date is not None and a.due_date < now and a.completed_at is None
         ]
     if completed is True:
@@ -162,9 +163,7 @@ async def complete_activity(
     return activity
 
 
-async def soft_delete_activity(
-    db: AsyncSession, activity: Activity
-) -> Activity:
+async def soft_delete_activity(db: AsyncSession, activity: Activity) -> Activity:
     """Soft-delete an activity."""
     activity.deleted_at = datetime.now(UTC)
     await db.commit()