feat: phase 2 - migrate all route guards to require_permission (75 guards, 21 files)

app/routes/addresses.py

@@ -7,9 +7,8 @@ import uuid
 from fastapi import APIRouter, Depends, HTTPException, Query, status
 from sqlalchemy.ext.asyncio import AsyncSession
 
-from app.core.auth import check_permission
 from app.core.db import get_db
-from app.deps import get_current_user
+from app.deps import require_permission
 from app.schemas.address import AddressCreate, AddressUpdate
 from app.services import address_service
 
@@ -21,7 +20,7 @@ async def list_addresses(
     entity_type: str = Query(..., pattern="^(company|contact)$"),
     entity_id: str = Query(...),
     db: AsyncSession = Depends(get_db),
-    current_user: dict = Depends(get_current_user),
+    current_user: dict = Depends(require_permission("addresses:read")),
 ):
     """List all addresses for a given entity (company or contact)."""
     tenant_id = uuid.UUID(current_user["tenant_id"])
@@ -37,18 +36,12 @@ async def list_addresses(
 async def create_address(
     body: AddressCreate,
     db: AsyncSession = Depends(get_db),
-    current_user: dict = Depends(get_current_user),
+    current_user: dict = Depends(require_permission("addresses:write")),
 ):
     """Create a new address for a company or contact."""
     tenant_id = uuid.UUID(current_user["tenant_id"])
     user_id = uuid.UUID(current_user["user_id"])
-    role = current_user.get("role", "viewer")
 
-    if not check_permission(role, "companies", "create") and not check_permission(role, "contacts", "create"):
-        raise HTTPException(
-            status_code=status.HTTP_403_FORBIDDEN,
-            detail={"detail": "Insufficient permissions", "code": "forbidden"},
-        )
 
     data = body.model_dump()
     try:
@@ -62,18 +55,12 @@ async def update_address(
     address_id: str,
     body: AddressUpdate,
     db: AsyncSession = Depends(get_db),
-    current_user: dict = Depends(get_current_user),
+    current_user: dict = Depends(require_permission("addresses:write")),
 ):
     """Update an address."""
     tenant_id = uuid.UUID(current_user["tenant_id"])
     user_id = uuid.UUID(current_user["user_id"])
-    role = current_user.get("role", "viewer")
 
-    if not check_permission(role, "companies", "update") and not check_permission(role, "contacts", "update"):
-        raise HTTPException(
-            status_code=status.HTTP_403_FORBIDDEN,
-            detail={"detail": "Insufficient permissions", "code": "forbidden"},
-        )
 
     try:
         aid = uuid.UUID(address_id)
@@ -91,18 +78,12 @@ async def update_address(
 async def delete_address(
     address_id: str,
     db: AsyncSession = Depends(get_db),
-    current_user: dict = Depends(get_current_user),
+    current_user: dict = Depends(require_permission("addresses:write")),
 ):
     """Soft-delete an address."""
     tenant_id = uuid.UUID(current_user["tenant_id"])
     user_id = uuid.UUID(current_user["user_id"])
-    role = current_user.get("role", "viewer")
 
-    if not check_permission(role, "companies", "delete") and not check_permission(role, "contacts", "delete"):
-        raise HTTPException(
-            status_code=status.HTTP_403_FORBIDDEN,
-            detail={"detail": "Insufficient permissions", "code": "forbidden"},
-        )
 
     try:
         aid = uuid.UUID(address_id)