feat: phase 2 - migrate all route guards to require_permission (75 guards, 21 files)

app/routes/contacts.py

@@ -11,9 +11,8 @@ from fastapi.responses import StreamingResponse
 from sqlalchemy import select
 from sqlalchemy.ext.asyncio import AsyncSession
 
-from app.core.auth import check_permission
 from app.core.db import get_db
-from app.deps import get_current_user
+from app.deps import require_permission
 from app.models.contact import Contact
 from app.schemas.contact import ContactCreate, ContactUpdate
 from app.services import contact_service
@@ -29,7 +28,7 @@ async def list_contacts(
     sort_by: str = Query("last_name"),
     sort_order: str = Query("asc", pattern="^(asc|desc)$"),
     db: AsyncSession = Depends(get_db),
-    current_user: dict = Depends(get_current_user),
+    current_user: dict = Depends(require_permission("contacts:read")),
 ):
     """List contacts with pagination and optional search.
 
@@ -53,7 +52,7 @@ async def export_contacts(
     format: str = Query("csv", pattern="^(csv)$"),
     search: str | None = Query(None),
     db: AsyncSession = Depends(get_db),
-    current_user: dict = Depends(get_current_user),
+    current_user: dict = Depends(require_permission("contacts:read")),
 ):
     """Stream contacts as CSV (not buffered — uses StreamingResponse).
 
@@ -148,18 +147,12 @@ async def export_contacts(
 async def create_contact(
     body: ContactCreate,
     db: AsyncSession = Depends(get_db),
-    current_user: dict = Depends(get_current_user),
+    current_user: dict = Depends(require_permission("contacts:write")),
 ):
     """Create a contact. Optionally link to companies via company_ids array."""
     tenant_id = uuid.UUID(current_user["tenant_id"])
     user_id = uuid.UUID(current_user["user_id"])
-    role = current_user.get("role", "viewer")
 
-    if not check_permission(role, "contacts", "create"):
-        raise HTTPException(
-            status_code=status.HTTP_403_FORBIDDEN,
-            detail={"detail": "Insufficient permissions", "code": "forbidden"},
-        )
 
     data = body.model_dump()
     return await contact_service.create_contact(db, tenant_id, user_id, data)
@@ -169,7 +162,7 @@ async def create_contact(
 async def get_contact(
     contact_id: str,
     db: AsyncSession = Depends(get_db),
-    current_user: dict = Depends(get_current_user),
+    current_user: dict = Depends(require_permission("contacts:read")),
 ):
     """Get a single contact with companies array. Cross-tenant returns 404."""
     tenant_id = uuid.UUID(current_user["tenant_id"])
@@ -191,15 +184,12 @@ async def update_contact(
     contact_id: str,
     body: ContactUpdate,
     db: AsyncSession = Depends(get_db),
-    current_user: dict = Depends(get_current_user),
+    current_user: dict = Depends(require_permission("contacts:write")),
 ):
     """Update a contact."""
     tenant_id = uuid.UUID(current_user["tenant_id"])
     user_id = uuid.UUID(current_user["user_id"])
-    role = current_user.get("role", "viewer")
 
-    if not check_permission(role, "contacts", "update"):
-        raise HTTPException(403, detail={"detail": "Insufficient permissions", "code": "forbidden"})
 
     try:
         cid = uuid.UUID(contact_id)
@@ -220,15 +210,12 @@ async def delete_contact(
     contact_id: str,
     gdpr: bool = Query(False),
     db: AsyncSession = Depends(get_db),
-    current_user: dict = Depends(get_current_user),
+    current_user: dict = Depends(require_permission("contacts:write")),
 ):
     """Delete a contact. Default: soft-delete. Use gdpr=true for hard-delete with deletion_log."""
     tenant_id = uuid.UUID(current_user["tenant_id"])
     user_id = uuid.UUID(current_user["user_id"])
-    role = current_user.get("role", "viewer")
 
-    if not check_permission(role, "contacts", "delete"):
-        raise HTTPException(403, detail={"detail": "Insufficient permissions", "code": "forbidden"})
 
     try:
         cid = uuid.UUID(contact_id)