feat: phase 2 - migrate all route guards to require_permission (75 guards, 21 files)

app/routes/workflows.py

@@ -7,9 +7,8 @@ import uuid
 from fastapi import APIRouter, Depends, HTTPException, Query, Response, status
 from sqlalchemy.ext.asyncio import AsyncSession
 
-from app.core.auth import check_permission
 from app.core.db import get_db
-from app.deps import get_current_user
+from app.deps import require_permission
 from app.schemas.workflow import AdvanceRequest, InstanceCreate, WorkflowCreate, WorkflowUpdate
 from app.services import workflow_service
 
@@ -25,7 +24,7 @@ async def list_workflows(
     page_size: int = Query(20, ge=1, le=100),
     is_active: bool | None = Query(None),
     db: AsyncSession = Depends(get_db),
-    current_user: dict = Depends(get_current_user),
+    current_user: dict = Depends(require_permission("workflows:read")),
 ):
     """List workflows with pagination."""
     tenant_id = uuid.UUID(current_user["tenant_id"])
@@ -42,18 +41,12 @@ async def list_workflows(
 async def create_workflow(
     body: WorkflowCreate,
     db: AsyncSession = Depends(get_db),
-    current_user: dict = Depends(get_current_user),
+    current_user: dict = Depends(require_permission("workflows:write")),
 ):
     """Create a new workflow definition. Requires write permission."""
     tenant_id = uuid.UUID(current_user["tenant_id"])
     user_id = uuid.UUID(current_user["user_id"])
-    role = current_user.get("role", "viewer")
 
-    if not check_permission(role, "workflows", "create"):
-        raise HTTPException(
-            status_code=status.HTTP_403_FORBIDDEN,
-            detail={"detail": "Insufficient permissions", "code": "forbidden"},
-        )
 
     data = body.model_dump()
     return await workflow_service.create_workflow(db, tenant_id, user_id, data)
@@ -65,7 +58,7 @@ async def list_instances(
     page_size: int = Query(20, ge=1, le=100),
     status: str | None = Query(None),
     db: AsyncSession = Depends(get_db),
-    current_user: dict = Depends(get_current_user),
+    current_user: dict = Depends(require_permission("workflows:read")),
 ):
     """List workflow instances with optional status filter."""
     tenant_id = uuid.UUID(current_user["tenant_id"])
@@ -82,7 +75,7 @@ async def list_instances(
 async def get_workflow(
     workflow_id: str,
     db: AsyncSession = Depends(get_db),
-    current_user: dict = Depends(get_current_user),
+    current_user: dict = Depends(require_permission("workflows:read")),
 ):
     """Get a single workflow by ID."""
     tenant_id = uuid.UUID(current_user["tenant_id"])
@@ -100,18 +93,12 @@ async def update_workflow(
     workflow_id: str,
     body: WorkflowUpdate,
     db: AsyncSession = Depends(get_db),
-    current_user: dict = Depends(get_current_user),
+    current_user: dict = Depends(require_permission("workflows:write")),
 ):
     """Update a workflow definition."""
     tenant_id = uuid.UUID(current_user["tenant_id"])
     user_id = uuid.UUID(current_user["user_id"])
-    role = current_user.get("role", "viewer")
 
-    if not check_permission(role, "workflows", "update"):
-        raise HTTPException(
-            status_code=status.HTTP_403_FORBIDDEN,
-            detail={"detail": "Insufficient permissions", "code": "forbidden"},
-        )
 
     data = body.model_dump(exclude_unset=True)
     result = await workflow_service.update_workflow(db, tenant_id, user_id, workflow_id, data)
@@ -127,18 +114,12 @@ async def update_workflow(
 async def delete_workflow(
     workflow_id: str,
     db: AsyncSession = Depends(get_db),
-    current_user: dict = Depends(get_current_user),
+    current_user: dict = Depends(require_permission("workflows:write")),
 ):
     """Delete a workflow definition."""
     tenant_id = uuid.UUID(current_user["tenant_id"])
     user_id = uuid.UUID(current_user["user_id"])
-    role = current_user.get("role", "viewer")
 
-    if not check_permission(role, "workflows", "delete"):
-        raise HTTPException(
-            status_code=status.HTTP_403_FORBIDDEN,
-            detail={"detail": "Insufficient permissions", "code": "forbidden"},
-        )
 
     deleted = await workflow_service.delete_workflow(db, tenant_id, user_id, workflow_id)
     if not deleted:
@@ -157,7 +138,7 @@ async def create_instance(
     workflow_id: str,
     body: InstanceCreate,
     db: AsyncSession = Depends(get_db),
-    current_user: dict = Depends(get_current_user),
+    current_user: dict = Depends(require_permission("workflows:write")),
 ):
     """Create a new workflow instance."""
     tenant_id = uuid.UUID(current_user["tenant_id"])
@@ -183,7 +164,7 @@ async def create_instance(
 async def get_instance(
     instance_id: str,
     db: AsyncSession = Depends(get_db),
-    current_user: dict = Depends(get_current_user),
+    current_user: dict = Depends(require_permission("workflows:read")),
 ):
     """Get a workflow instance with step history."""
     tenant_id = uuid.UUID(current_user["tenant_id"])
@@ -201,7 +182,7 @@ async def advance_instance(
     instance_id: str,
     body: AdvanceRequest,
     db: AsyncSession = Depends(get_db),
-    current_user: dict = Depends(get_current_user),
+    current_user: dict = Depends(require_permission("workflows:write")),
 ):
     """Advance or reject a workflow instance step.
 
@@ -236,7 +217,7 @@ async def advance_instance(
 async def cancel_instance(
     instance_id: str,
     db: AsyncSession = Depends(get_db),
-    current_user: dict = Depends(get_current_user),
+    current_user: dict = Depends(require_permission("workflows:write")),
 ):
     """Cancel a workflow instance. Returns 200 with cancelled instance."""
     tenant_id = uuid.UUID(current_user["tenant_id"])