fix(arch): externes Audit — 13 Backend-Fixes (Workspace-Modules, Tenant-Manifeste, Lifecycle, Contracts, Permissions)
Check Cross-Plugin Imports / check (push) Has been cancelled

Verifikation: Alle 17 Audit-Findings gegen den Code geprueft — alle bestaetigt.
Backend-Lifecycle-Fixes umgesetzt; 4 Frontend-Plugin-Architektur-Punkte
als Phase Q in die Roadmap eingeplant.

- P1 list_workspaces: Module + User-Counts gebuendelt laden (Editor-Overwrite-Bug)
- P1 active-manifests: Tenant-Deaktivierung (tenant_plugin_activation) filtern
- P1 uninstall: volle Service-Deactivation VOR registry.uninstall()
- P1 ContractRegistry: DB-Aktivstatus-Guard (Restart-Edge-Case) + Re-Activate
- P1/P2 Field-Definitions: voller Lifecycle (register/unregister) im Service
- P1/P2 Contact-Felddefinitionen (39) ins ContactsPlugin-Manifest verschoben
- P1 12 fehlende Permission-Keys registriert (AST-Scan: 0 fehlend)
- P2 contact_folder -> ContactsPlugin; ENTITY_PLUGIN_OWNERS wird befuellt
- P2 Entity-Permission-Fallback fail-closed statt contacts:read
- P2 forgejo_error_reporter is_core=False; DMS is_core=True (ADR-020)
- P2 Worker: Contacts-Trash-Cleanup ins Plugin (get_job_modules-Discovery)
- P1/P2 DSGVO-Export delegiert an DSAR-Collector (kein Core->Contacts)
- P2 False-green Tests korrigiert (or True, veraltete Route-Count-Assertion)

Verifikation: tests/test_audit_architecture_fixes.py 17/17; Regressionen
gruen (contacts_lifecycle, entity_registry, workspace_scopes, rbac,
lifecycle_service); Combo-Order-Test 35/35; Cross-Plugin-Checker 497/0;
compileall sauber; ruff auf 7-Error-Baseline.

Doku: PROGRESS.md Audit-Section, PLATFORM_ROADMAP.md Phase Q (Q1-Q4),
plugin-development-guide.md Lifecycle, permissions.md Katalog.
This commit is contained in:
Agent Zero
2026-09-13 02:25:01 +02:00
parent 86cea5d6c4
commit 4a25ac1379
25 changed files with 1020 additions and 141 deletions
+17 -1
View File
@@ -337,6 +337,22 @@ async def lifespan(app: FastAPI):
if plugin and plugin.manifest.permissions:
register_plugin_permissions(record.name, plugin.manifest.permissions)
# Audit P1 (contract lazy loading, restart edge case): plugins that
# were already inactive in the DB when this process started never get
# a runtime deactivate() call, so the ContractRegistry would
# lazy-load their contracts module and resurrect the contract.
# Mark them once here so get_contract() fails closed for them.
inactive_result = await db.execute(
sa_select(PluginModel.name).where(PluginModel.active == False) # noqa: E712
)
inactive_names = {row[0] for row in inactive_result}
if inactive_names:
from app.plugins.builtins.contracts import get_contract_registry
get_contract_registry().mark_db_inactive(inactive_names)
logger.info(
"Contract registry: %d plugins marked DB-inactive", len(inactive_names)
)
init_permission_registry(active_plugin_names)
logger.info("Permission registry initialized with %d active plugins", len(active_plugin_names))
@@ -359,7 +375,7 @@ async def lifespan(app: FastAPI):
plugin = registry.get_plugin(name)
if plugin:
for entity_type, model_class in plugin.get_entity_models().items():
register_entity_model(entity_type, model_class)
register_entity_model(entity_type, model_class, plugin_name=name)
logger.info("Entity models registered for %d active plugins", len(active_plugin_names))
# Register field definitions from active plugins only