sprint2: 8 services + 8 routes visibility filter + BaseSearchProvider + owned_mixin on models
Check Cross-Plugin Imports / check (push) Has been cancelled

This commit is contained in:
Agent Zero
2026-07-29 01:52:47 +02:00
parent 479ee04834
commit 9fc84b7905
25 changed files with 977 additions and 211 deletions
+1 -1
View File
@@ -12,7 +12,7 @@ from app.core.db import Base, TenantMixin
from app.models.owned_mixin import OwnedMixin from app.models.owned_mixin import OwnedMixin
class Address(Base, TenantMixin): class Address(Base, TenantMixin, OwnedMixin):
"""Polymorphic address entity — multiple addresses per contact. """Polymorphic address entity — multiple addresses per contact.
entity_type: 'contact' entity_type: 'contact'
+1 -1
View File
@@ -13,7 +13,7 @@ from app.core.db import Base, TenantMixin
from app.models.owned_mixin import OwnedMixin from app.models.owned_mixin import OwnedMixin
class Attachment(Base, TenantMixin): class Attachment(Base, TenantMixin, OwnedMixin):
"""Attachment entity — links files to companies, contacts, invoices, etc.""" """Attachment entity — links files to companies, contacts, invoices, etc."""
__tablename__ = "attachments" __tablename__ = "attachments"
+1 -1
View File
@@ -12,7 +12,7 @@ from app.core.db import Base, TenantMixin
from app.models.owned_mixin import OwnedMixin from app.models.owned_mixin import OwnedMixin
class BankAccount(Base, TenantMixin): class BankAccount(Base, TenantMixin, OwnedMixin):
"""Bank account entity — multiple accounts per tenant. """Bank account entity — multiple accounts per tenant.
is_default: one default bank account per tenant. is_default: one default bank account per tenant.
+1 -1
View File
@@ -14,7 +14,7 @@ from app.core.db import Base, TenantMixin
from app.models.owned_mixin import OwnedMixin from app.models.owned_mixin import OwnedMixin
class SavedFilter(Base, TenantMixin): class SavedFilter(Base, TenantMixin, OwnedMixin):
"""Saved filter — reusable filter criteria for list views (contacts, mail, calendar, DMS).""" """Saved filter — reusable filter criteria for list views (contacts, mail, calendar, DMS)."""
__tablename__ = "saved_filters" __tablename__ = "saved_filters"
+1 -1
View File
@@ -14,7 +14,7 @@ from app.core.db import Base, TenantMixin
from app.models.owned_mixin import OwnedMixin from app.models.owned_mixin import OwnedMixin
class SavedView(Base, TenantMixin): class SavedView(Base, TenantMixin, OwnedMixin):
"""Saved view — reusable view configuration (filter+sort+group+viewMode+folder) for list views.""" """Saved view — reusable view configuration (filter+sort+group+viewMode+folder) for list views."""
__tablename__ = "saved_views" __tablename__ = "saved_views"
+1 -1
View File
@@ -13,7 +13,7 @@ from app.core.db import Base, TenantMixin
from app.models.owned_mixin import OwnedMixin from app.models.owned_mixin import OwnedMixin
class Sequence(Base, TenantMixin): class Sequence(Base, TenantMixin, OwnedMixin):
"""Sequence entity for document numbering (e.g. invoice RE-2026-0001).""" """Sequence entity for document numbering (e.g. invoice RE-2026-0001)."""
__tablename__ = "sequences" __tablename__ = "sequences"
+1 -1
View File
@@ -12,7 +12,7 @@ from app.core.db import Base, TenantMixin
from app.models.owned_mixin import OwnedMixin from app.models.owned_mixin import OwnedMixin
class Webhook(Base, TenantMixin): class Webhook(Base, TenantMixin, OwnedMixin):
"""Outgoing webhook subscription. """Outgoing webhook subscription.
Each webhook defines a target URL, a list of events to subscribe to, Each webhook defines a target URL, a list of events to subscribe to,
+1 -1
View File
@@ -15,7 +15,7 @@ from app.core.db import Base, TenantMixin
from app.models.owned_mixin import OwnedMixin from app.models.owned_mixin import OwnedMixin
class Workflow(Base, TenantMixin): class Workflow(Base, TenantMixin, OwnedMixin):
"""Workflow definition — a template of steps stored as JSONB, tenant-scoped.""" """Workflow definition — a template of steps stored as JSONB, tenant-scoped."""
__tablename__ = "workflows" __tablename__ = "workflows"
@@ -0,0 +1,98 @@
"""Base search provider with visibility filter — all search providers should inherit from this.
This ensures that search results respect row-level security automatically.
Plugins that provide search functionality should use this base class.
"""
from __future__ import annotations
import logging
import uuid
from typing import Any
from sqlalchemy import text
from sqlalchemy.ext.asyncio import AsyncSession
logger = logging.getLogger(__name__)
class BaseSearchProvider:
"""Base class for search providers with built-in visibility filtering.
Subclasses must implement _search_fts_filtered() and _search_vector_filtered().
The base class handles loading visible IDs and passing them to the subclass.
"""
entity_type: str = "" # Override in subclass
async def search_fts(
self,
db: AsyncSession,
tsquery: str,
tenant_id: uuid.UUID,
limit: int,
user_id: uuid.UUID | None = None,
is_system_admin: bool = False,
) -> list[dict[str, Any]]:
"""Full-text search with visibility filter."""
if is_system_admin or not user_id:
return await self._search_fts_filtered(db, tsquery, tenant_id, limit, None)
visible_ids = await self._get_visible_ids(db, tenant_id, user_id)
if not visible_ids:
return []
return await self._search_fts_filtered(db, tsquery, tenant_id, limit, visible_ids)
async def search_vector(
self,
db: AsyncSession,
embedding: list[float],
tenant_id: uuid.UUID,
limit: int,
user_id: uuid.UUID | None = None,
is_system_admin: bool = False,
) -> list[dict[str, Any]]:
"""Semantic vector search with visibility filter."""
if is_system_admin or not user_id:
return await self._search_vector_filtered(db, embedding, tenant_id, limit, None)
visible_ids = await self._get_visible_ids(db, tenant_id, user_id)
if not visible_ids:
return []
return await self._search_vector_filtered(db, embedding, tenant_id, limit, visible_ids)
async def _get_visible_ids(
self, db: AsyncSession, tenant_id: uuid.UUID, user_id: uuid.UUID
) -> set[uuid.UUID] | None:
"""Get visible entity IDs for the user."""
from app.services.entity_permission_service import get_visible_ids
visible, _ = await get_visible_ids(db, tenant_id, user_id, self.entity_type)
return visible if visible else None
async def _search_fts_filtered(
self,
db: AsyncSession,
tsquery: str,
tenant_id: uuid.UUID,
limit: int,
visible_ids: set[uuid.UUID] | None,
) -> list[dict[str, Any]]:
"""Override: FTS search filtered by visible_ids. If visible_ids is None, no filter."""
raise NotImplementedError
async def _search_vector_filtered(
self,
db: AsyncSession,
embedding: list[float],
tenant_id: uuid.UUID,
limit: int,
visible_ids: set[uuid.UUID] | None,
) -> list[dict[str, Any]]:
"""Override: Vector search filtered by visible_ids. If visible_ids is None, no filter."""
raise NotImplementedError
async def get_embedding_text(
self, db: AsyncSession, entity_id: uuid.UUID, tenant_id: uuid.UUID
) -> str:
"""Override: Get text for embedding generation."""
raise NotImplementedError
+21 -7
View File
@@ -24,12 +24,18 @@ async def list_addresses(
): ):
"""List all addresses for a given entity (company or contact).""" """List all addresses for a given entity (company or contact)."""
tenant_id = uuid.UUID(current_user["tenant_id"]) tenant_id = uuid.UUID(current_user["tenant_id"])
user_id = uuid.UUID(current_user["user_id"])
is_admin = current_user.get("is_system_admin", False)
try: try:
eid = uuid.UUID(entity_id) eid = uuid.UUID(entity_id)
except ValueError: except ValueError:
raise HTTPException(400, detail={"detail": "Invalid entity_id", "code": "invalid_id"}) from None raise HTTPException(400, detail={"detail": "Invalid entity_id", "code": "invalid_id"}) from None
return await address_service.list_addresses(db, tenant_id, entity_type, eid) try:
return await address_service.list_addresses(db, tenant_id, entity_type, eid, user_id=user_id, is_system_admin=is_admin)
except PermissionError as e:
raise HTTPException(status_code=403, detail=str(e)) from e
@router.post("", status_code=status.HTTP_201_CREATED) @router.post("", status_code=status.HTTP_201_CREATED)
@@ -41,11 +47,13 @@ async def create_address(
"""Create a new address for a company or contact.""" """Create a new address for a company or contact."""
tenant_id = uuid.UUID(current_user["tenant_id"]) tenant_id = uuid.UUID(current_user["tenant_id"])
user_id = uuid.UUID(current_user["user_id"]) user_id = uuid.UUID(current_user["user_id"])
is_admin = current_user.get("is_system_admin", False)
data = body.model_dump() data = body.model_dump()
try: try:
return await address_service.create_address(db, tenant_id, user_id, data) return await address_service.create_address(db, tenant_id, user_id, data, is_system_admin=is_admin)
except PermissionError as e:
raise HTTPException(status_code=403, detail=str(e)) from e
except ValueError as exc: except ValueError as exc:
raise HTTPException(400, detail={"detail": str(exc), "code": "invalid_value"}) from exc raise HTTPException(400, detail={"detail": str(exc), "code": "invalid_value"}) from exc
@@ -60,7 +68,7 @@ async def update_address(
"""Update an address.""" """Update an address."""
tenant_id = uuid.UUID(current_user["tenant_id"]) tenant_id = uuid.UUID(current_user["tenant_id"])
user_id = uuid.UUID(current_user["user_id"]) user_id = uuid.UUID(current_user["user_id"])
is_admin = current_user.get("is_system_admin", False)
try: try:
aid = uuid.UUID(address_id) aid = uuid.UUID(address_id)
@@ -68,7 +76,10 @@ async def update_address(
raise HTTPException(400, detail={"detail": "Invalid address_id", "code": "invalid_id"}) from None raise HTTPException(400, detail={"detail": "Invalid address_id", "code": "invalid_id"}) from None
data = body.model_dump(exclude_unset=True) data = body.model_dump(exclude_unset=True)
result = await address_service.update_address(db, tenant_id, user_id, aid, data) try:
result = await address_service.update_address(db, tenant_id, user_id, aid, data, is_system_admin=is_admin)
except PermissionError as e:
raise HTTPException(status_code=403, detail=str(e)) from e
if result is None: if result is None:
raise HTTPException(404, detail={"detail": "Address not found", "code": "not_found"}) raise HTTPException(404, detail={"detail": "Address not found", "code": "not_found"})
return result return result
@@ -83,13 +94,16 @@ async def delete_address(
"""Soft-delete an address.""" """Soft-delete an address."""
tenant_id = uuid.UUID(current_user["tenant_id"]) tenant_id = uuid.UUID(current_user["tenant_id"])
user_id = uuid.UUID(current_user["user_id"]) user_id = uuid.UUID(current_user["user_id"])
is_admin = current_user.get("is_system_admin", False)
try: try:
aid = uuid.UUID(address_id) aid = uuid.UUID(address_id)
except ValueError: except ValueError:
raise HTTPException(400, detail={"detail": "Invalid address_id", "code": "invalid_id"}) from None raise HTTPException(400, detail={"detail": "Invalid address_id", "code": "invalid_id"}) from None
deleted = await address_service.delete_address(db, tenant_id, user_id, aid) try:
deleted = await address_service.delete_address(db, tenant_id, user_id, aid, is_system_admin=is_admin)
except PermissionError as e:
raise HTTPException(status_code=403, detail=str(e)) from e
if not deleted: if not deleted:
raise HTTPException(404, detail={"detail": "Address not found", "code": "not_found"}) raise HTTPException(404, detail={"detail": "Address not found", "code": "not_found"})
+26 -9
View File
@@ -27,7 +27,7 @@ async def upload_attachment(
"""Upload a file attachment. Multipart form data.""" """Upload a file attachment. Multipart form data."""
tenant_id = uuid.UUID(current_user["tenant_id"]) tenant_id = uuid.UUID(current_user["tenant_id"])
user_id = uuid.UUID(current_user["user_id"]) user_id = uuid.UUID(current_user["user_id"])
is_admin = current_user.get("is_system_admin", False)
try: try:
eid = uuid.UUID(entity_id) eid = uuid.UUID(entity_id)
@@ -37,10 +37,14 @@ async def upload_attachment(
file_content = await file.read() file_content = await file.read()
mime_type = file.content_type or "application/octet-stream" mime_type = file.content_type or "application/octet-stream"
return await attachment_service.save_attachment( try:
db, tenant_id, user_id, entity_type, eid, return await attachment_service.save_attachment(
file.filename or "unknown", file_content, mime_type, db, tenant_id, user_id, entity_type, eid,
) file.filename or "unknown", file_content, mime_type,
is_system_admin=is_admin,
)
except PermissionError as e:
raise HTTPException(status_code=403, detail=str(e)) from e
@router.get("") @router.get("")
@@ -52,13 +56,18 @@ async def list_attachments(
): ):
"""List attachments for a specific entity.""" """List attachments for a specific entity."""
tenant_id = uuid.UUID(current_user["tenant_id"]) tenant_id = uuid.UUID(current_user["tenant_id"])
user_id = uuid.UUID(current_user["user_id"])
is_admin = current_user.get("is_system_admin", False)
try: try:
eid = uuid.UUID(entity_id) eid = uuid.UUID(entity_id)
except ValueError: except ValueError:
raise HTTPException(400, detail={"detail": "Invalid entity_id", "code": "invalid_id"}) from None raise HTTPException(400, detail={"detail": "Invalid entity_id", "code": "invalid_id"}) from None
return await attachment_service.list_attachments(db, tenant_id, entity_type, eid) try:
return await attachment_service.list_attachments(db, tenant_id, entity_type, eid, user_id=user_id, is_system_admin=is_admin)
except PermissionError as e:
raise HTTPException(status_code=403, detail=str(e)) from e
@router.get("/{attachment_id}") @router.get("/{attachment_id}")
@@ -69,13 +78,18 @@ async def download_attachment(
): ):
"""Download an attachment file.""" """Download an attachment file."""
tenant_id = uuid.UUID(current_user["tenant_id"]) tenant_id = uuid.UUID(current_user["tenant_id"])
user_id = uuid.UUID(current_user["user_id"])
is_admin = current_user.get("is_system_admin", False)
try: try:
aid = uuid.UUID(attachment_id) aid = uuid.UUID(attachment_id)
except ValueError: except ValueError:
raise HTTPException(400, detail={"detail": "Invalid attachment_id", "code": "invalid_id"}) from None raise HTTPException(400, detail={"detail": "Invalid attachment_id", "code": "invalid_id"}) from None
data = await attachment_service.get_attachment(db, tenant_id, aid) try:
data = await attachment_service.get_attachment(db, tenant_id, aid, user_id=user_id, is_system_admin=is_admin)
except PermissionError as e:
raise HTTPException(status_code=403, detail=str(e)) from e
if data is None: if data is None:
raise HTTPException(404, detail={"detail": "Attachment not found", "code": "not_found"}) raise HTTPException(404, detail={"detail": "Attachment not found", "code": "not_found"})
@@ -99,13 +113,16 @@ async def delete_attachment(
"""Delete an attachment.""" """Delete an attachment."""
tenant_id = uuid.UUID(current_user["tenant_id"]) tenant_id = uuid.UUID(current_user["tenant_id"])
user_id = uuid.UUID(current_user["user_id"]) user_id = uuid.UUID(current_user["user_id"])
is_admin = current_user.get("is_system_admin", False)
try: try:
aid = uuid.UUID(attachment_id) aid = uuid.UUID(attachment_id)
except ValueError: except ValueError:
raise HTTPException(400, detail={"detail": "Invalid attachment_id", "code": "invalid_id"}) from None raise HTTPException(400, detail={"detail": "Invalid attachment_id", "code": "invalid_id"}) from None
deleted = await attachment_service.delete_attachment(db, tenant_id, user_id, aid) try:
deleted = await attachment_service.delete_attachment(db, tenant_id, user_id, aid, is_system_admin=is_admin)
except PermissionError as e:
raise HTTPException(status_code=403, detail=str(e)) from e
if not deleted: if not deleted:
raise HTTPException(404, detail={"detail": "Attachment not found", "code": "not_found"}) raise HTTPException(404, detail={"detail": "Attachment not found", "code": "not_found"})
+21 -4
View File
@@ -22,7 +22,13 @@ async def list_bank_accounts(
): ):
"""List all bank accounts for the current tenant.""" """List all bank accounts for the current tenant."""
tenant_id = uuid.UUID(current_user["tenant_id"]) tenant_id = uuid.UUID(current_user["tenant_id"])
return await bank_account_service.list_bank_accounts(db, tenant_id) user_id = uuid.UUID(current_user["user_id"])
is_admin = current_user.get("is_system_admin", False)
try:
return await bank_account_service.list_bank_accounts(db, tenant_id, user_id=user_id, is_system_admin=is_admin)
except PermissionError as e:
raise HTTPException(status_code=403, detail=str(e)) from e
@router.post("", status_code=status.HTTP_201_CREATED) @router.post("", status_code=status.HTTP_201_CREATED)
@@ -34,10 +40,13 @@ async def create_bank_account(
"""Create a new bank account.""" """Create a new bank account."""
tenant_id = uuid.UUID(current_user["tenant_id"]) tenant_id = uuid.UUID(current_user["tenant_id"])
user_id = uuid.UUID(current_user["user_id"]) user_id = uuid.UUID(current_user["user_id"])
is_admin = current_user.get("is_system_admin", False)
data = body.model_dump() data = body.model_dump()
try: try:
return await bank_account_service.create_bank_account(db, tenant_id, user_id, data) return await bank_account_service.create_bank_account(db, tenant_id, user_id, data, is_system_admin=is_admin)
except PermissionError as e:
raise HTTPException(status_code=403, detail=str(e)) from e
except ValueError as exc: except ValueError as exc:
raise HTTPException(400, detail={"detail": str(exc), "code": "invalid_value"}) from exc raise HTTPException(400, detail={"detail": str(exc), "code": "invalid_value"}) from exc
@@ -52,6 +61,7 @@ async def update_bank_account(
"""Update a bank account.""" """Update a bank account."""
tenant_id = uuid.UUID(current_user["tenant_id"]) tenant_id = uuid.UUID(current_user["tenant_id"])
user_id = uuid.UUID(current_user["user_id"]) user_id = uuid.UUID(current_user["user_id"])
is_admin = current_user.get("is_system_admin", False)
try: try:
aid = uuid.UUID(account_id) aid = uuid.UUID(account_id)
@@ -59,7 +69,10 @@ async def update_bank_account(
raise HTTPException(400, detail={"detail": "Invalid account_id", "code": "invalid_id"}) from None raise HTTPException(400, detail={"detail": "Invalid account_id", "code": "invalid_id"}) from None
data = body.model_dump(exclude_unset=True) data = body.model_dump(exclude_unset=True)
result = await bank_account_service.update_bank_account(db, tenant_id, user_id, aid, data) try:
result = await bank_account_service.update_bank_account(db, tenant_id, user_id, aid, data, is_system_admin=is_admin)
except PermissionError as e:
raise HTTPException(status_code=403, detail=str(e)) from e
if result is None: if result is None:
raise HTTPException(404, detail={"detail": "Bank account not found", "code": "not_found"}) raise HTTPException(404, detail={"detail": "Bank account not found", "code": "not_found"})
return result return result
@@ -74,12 +87,16 @@ async def delete_bank_account(
"""Soft-delete a bank account.""" """Soft-delete a bank account."""
tenant_id = uuid.UUID(current_user["tenant_id"]) tenant_id = uuid.UUID(current_user["tenant_id"])
user_id = uuid.UUID(current_user["user_id"]) user_id = uuid.UUID(current_user["user_id"])
is_admin = current_user.get("is_system_admin", False)
try: try:
aid = uuid.UUID(account_id) aid = uuid.UUID(account_id)
except ValueError: except ValueError:
raise HTTPException(400, detail={"detail": "Invalid account_id", "code": "invalid_id"}) from None raise HTTPException(400, detail={"detail": "Invalid account_id", "code": "invalid_id"}) from None
deleted = await bank_account_service.delete_bank_account(db, tenant_id, user_id, aid) try:
deleted = await bank_account_service.delete_bank_account(db, tenant_id, user_id, aid, is_system_admin=is_admin)
except PermissionError as e:
raise HTTPException(status_code=403, detail=str(e)) from e
if not deleted: if not deleted:
raise HTTPException(404, detail={"detail": "Bank account not found", "code": "not_found"}) raise HTTPException(404, detail={"detail": "Bank account not found", "code": "not_found"})
+61 -49
View File
@@ -53,19 +53,23 @@ async def list_saved_filters(
"""List saved filters for the current user, optionally filtered by entity_type.""" """List saved filters for the current user, optionally filtered by entity_type."""
tenant_id = uuid.UUID(current_user["tenant_id"]) tenant_id = uuid.UUID(current_user["tenant_id"])
user_id = uuid.UUID(current_user["user_id"]) user_id = uuid.UUID(current_user["user_id"])
is_admin = current_user.get("is_system_admin", False)
query = select(SavedFilter).where( try:
SavedFilter.tenant_id == tenant_id, query = select(SavedFilter).where(
SavedFilter.user_id == user_id, SavedFilter.tenant_id == tenant_id,
SavedFilter.deleted_at.is_(None), SavedFilter.user_id == user_id,
) SavedFilter.deleted_at.is_(None),
if entity_type: )
query = query.where(SavedFilter.entity_type == entity_type) if entity_type:
query = query.order_by(SavedFilter.name) query = query.where(SavedFilter.entity_type == entity_type)
query = query.order_by(SavedFilter.name)
result = await db.execute(query) result = await db.execute(query)
filters = result.scalars().all() filters = result.scalars().all()
return [_filter_to_dict(f) for f in filters] return [_filter_to_dict(f) for f in filters]
except PermissionError as e:
raise HTTPException(status_code=403, detail=str(e)) from e
@router.post("", status_code=status.HTTP_201_CREATED, dependencies=[Depends(require_permission("contacts:read"))]) @router.post("", status_code=status.HTTP_201_CREATED, dependencies=[Depends(require_permission("contacts:read"))])
@@ -77,30 +81,34 @@ async def create_saved_filter(
"""Create a new saved filter for the current user.""" """Create a new saved filter for the current user."""
tenant_id = uuid.UUID(current_user["tenant_id"]) tenant_id = uuid.UUID(current_user["tenant_id"])
user_id = uuid.UUID(current_user["user_id"]) user_id = uuid.UUID(current_user["user_id"])
is_admin = current_user.get("is_system_admin", False)
# Check uniqueness within user+entity try:
existing = await db.execute( # Check uniqueness within user+entity
select(SavedFilter).where( existing = await db.execute(
SavedFilter.tenant_id == tenant_id, select(SavedFilter).where(
SavedFilter.user_id == user_id, SavedFilter.tenant_id == tenant_id,
SavedFilter.entity_type == body.entity_type, SavedFilter.user_id == user_id,
SavedFilter.name == body.name, SavedFilter.entity_type == body.entity_type,
SavedFilter.deleted_at.is_(None), SavedFilter.name == body.name,
SavedFilter.deleted_at.is_(None),
)
) )
) if existing.scalar_one_or_none() is not None:
if existing.scalar_one_or_none() is not None: raise HTTPException(409, detail={"detail": "Filter name already exists", "code": "duplicate"})
raise HTTPException(409, detail={"detail": "Filter name already exists", "code": "duplicate"})
saved = SavedFilter( saved = SavedFilter(
tenant_id=tenant_id, tenant_id=tenant_id,
user_id=user_id, user_id=user_id,
name=body.name, name=body.name,
entity_type=body.entity_type, entity_type=body.entity_type,
filter_criteria=body.filter_criteria, filter_criteria=body.filter_criteria,
) )
db.add(saved) db.add(saved)
await db.flush() await db.flush()
return _filter_to_dict(saved) return _filter_to_dict(saved)
except PermissionError as e:
raise HTTPException(status_code=403, detail=str(e)) from e
@router.delete("/{filter_id}", status_code=status.HTTP_204_NO_CONTENT, dependencies=[Depends(require_permission("contacts:read"))]) @router.delete("/{filter_id}", status_code=status.HTTP_204_NO_CONTENT, dependencies=[Depends(require_permission("contacts:read"))])
@@ -112,25 +120,29 @@ async def delete_saved_filter(
"""Delete a saved filter (soft-delete).""" """Delete a saved filter (soft-delete)."""
tenant_id = uuid.UUID(current_user["tenant_id"]) tenant_id = uuid.UUID(current_user["tenant_id"])
user_id = uuid.UUID(current_user["user_id"]) user_id = uuid.UUID(current_user["user_id"])
is_admin = current_user.get("is_system_admin", False)
try: try:
fid = uuid.UUID(filter_id) try:
except (ValueError, TypeError): fid = uuid.UUID(filter_id)
raise HTTPException(400, detail={"detail": "Invalid filter_id", "code": "invalid_id"}) from None except (ValueError, TypeError):
raise HTTPException(400, detail={"detail": "Invalid filter_id", "code": "invalid_id"}) from None
result = await db.execute( result = await db.execute(
select(SavedFilter).where( select(SavedFilter).where(
SavedFilter.id == fid, SavedFilter.id == fid,
SavedFilter.tenant_id == tenant_id, SavedFilter.tenant_id == tenant_id,
SavedFilter.user_id == user_id, SavedFilter.user_id == user_id,
SavedFilter.deleted_at.is_(None), SavedFilter.deleted_at.is_(None),
)
) )
) saved = result.scalar_one_or_none()
saved = result.scalar_one_or_none() if saved is None:
if saved is None: raise HTTPException(404, detail={"detail": "Saved filter not found", "code": "not_found"})
raise HTTPException(404, detail={"detail": "Saved filter not found", "code": "not_found"})
from datetime import datetime, timezone from datetime import datetime, timezone
saved.deleted_at = datetime.now(timezone.utc) saved.deleted_at = datetime.now(timezone.utc)
await db.flush() await db.flush()
return Response(status_code=status.HTTP_204_NO_CONTENT) return Response(status_code=status.HTTP_204_NO_CONTENT)
except PermissionError as e:
raise HTTPException(status_code=403, detail=str(e)) from e
+84 -68
View File
@@ -53,19 +53,23 @@ async def list_saved_views(
"""List saved views for the current user, optionally filtered by entity_type.""" """List saved views for the current user, optionally filtered by entity_type."""
tenant_id = uuid.UUID(current_user["tenant_id"]) tenant_id = uuid.UUID(current_user["tenant_id"])
user_id = uuid.UUID(current_user["user_id"]) user_id = uuid.UUID(current_user["user_id"])
is_admin = current_user.get("is_system_admin", False)
query = select(SavedView).where( try:
SavedView.tenant_id == tenant_id, query = select(SavedView).where(
SavedView.user_id == user_id, SavedView.tenant_id == tenant_id,
SavedView.deleted_at.is_(None), SavedView.user_id == user_id,
) SavedView.deleted_at.is_(None),
if entity_type: )
query = query.where(SavedView.entity_type == entity_type) if entity_type:
query = query.order_by(SavedView.name) query = query.where(SavedView.entity_type == entity_type)
query = query.order_by(SavedView.name)
result = await db.execute(query) result = await db.execute(query)
views = result.scalars().all() views = result.scalars().all()
return [_view_to_dict(v) for v in views] return [_view_to_dict(v) for v in views]
except PermissionError as e:
raise HTTPException(status_code=403, detail=str(e)) from e
@router.post("", status_code=status.HTTP_201_CREATED, dependencies=[Depends(require_permission("contacts:read"))]) @router.post("", status_code=status.HTTP_201_CREATED, dependencies=[Depends(require_permission("contacts:read"))])
@@ -77,30 +81,34 @@ async def create_saved_view(
"""Create a new saved view for the current user.""" """Create a new saved view for the current user."""
tenant_id = uuid.UUID(current_user["tenant_id"]) tenant_id = uuid.UUID(current_user["tenant_id"])
user_id = uuid.UUID(current_user["user_id"]) user_id = uuid.UUID(current_user["user_id"])
is_admin = current_user.get("is_system_admin", False)
# Check uniqueness within user+entity try:
existing = await db.execute( # Check uniqueness within user+entity
select(SavedView).where( existing = await db.execute(
SavedView.tenant_id == tenant_id, select(SavedView).where(
SavedView.user_id == user_id, SavedView.tenant_id == tenant_id,
SavedView.entity_type == body.entity_type, SavedView.user_id == user_id,
SavedView.name == body.name, SavedView.entity_type == body.entity_type,
SavedView.deleted_at.is_(None), SavedView.name == body.name,
SavedView.deleted_at.is_(None),
)
) )
) if existing.scalar_one_or_none() is not None:
if existing.scalar_one_or_none() is not None: raise HTTPException(409, detail={"detail": "View name already exists", "code": "duplicate"})
raise HTTPException(409, detail={"detail": "View name already exists", "code": "duplicate"})
saved = SavedView( saved = SavedView(
tenant_id=tenant_id, tenant_id=tenant_id,
user_id=user_id, user_id=user_id,
name=body.name, name=body.name,
entity_type=body.entity_type, entity_type=body.entity_type,
view_config=body.view_config, view_config=body.view_config,
) )
db.add(saved) db.add(saved)
await db.flush() await db.flush()
return _view_to_dict(saved) return _view_to_dict(saved)
except PermissionError as e:
raise HTTPException(status_code=403, detail=str(e)) from e
@router.put("/{view_id}", dependencies=[Depends(require_permission("contacts:read"))]) @router.put("/{view_id}", dependencies=[Depends(require_permission("contacts:read"))])
@@ -113,30 +121,34 @@ async def update_saved_view(
"""Update a saved view.""" """Update a saved view."""
tenant_id = uuid.UUID(current_user["tenant_id"]) tenant_id = uuid.UUID(current_user["tenant_id"])
user_id = uuid.UUID(current_user["user_id"]) user_id = uuid.UUID(current_user["user_id"])
is_admin = current_user.get("is_system_admin", False)
try: try:
vid = uuid.UUID(view_id) try:
except (ValueError, TypeError): vid = uuid.UUID(view_id)
raise HTTPException(400, detail={"detail": "Invalid view_id", "code": "invalid_id"}) from None except (ValueError, TypeError):
raise HTTPException(400, detail={"detail": "Invalid view_id", "code": "invalid_id"}) from None
result = await db.execute( result = await db.execute(
select(SavedView).where( select(SavedView).where(
SavedView.id == vid, SavedView.id == vid,
SavedView.tenant_id == tenant_id, SavedView.tenant_id == tenant_id,
SavedView.user_id == user_id, SavedView.user_id == user_id,
SavedView.deleted_at.is_(None), SavedView.deleted_at.is_(None),
)
) )
) saved = result.scalar_one_or_none()
saved = result.scalar_one_or_none() if saved is None:
if saved is None: raise HTTPException(404, detail={"detail": "Saved view not found", "code": "not_found"})
raise HTTPException(404, detail={"detail": "Saved view not found", "code": "not_found"})
if body.name is not None: if body.name is not None:
saved.name = body.name saved.name = body.name
if body.view_config is not None: if body.view_config is not None:
saved.view_config = body.view_config saved.view_config = body.view_config
await db.flush() await db.flush()
return _view_to_dict(saved) return _view_to_dict(saved)
except PermissionError as e:
raise HTTPException(status_code=403, detail=str(e)) from e
@router.delete("/{view_id}", status_code=status.HTTP_204_NO_CONTENT, dependencies=[Depends(require_permission("contacts:read"))]) @router.delete("/{view_id}", status_code=status.HTTP_204_NO_CONTENT, dependencies=[Depends(require_permission("contacts:read"))])
@@ -148,25 +160,29 @@ async def delete_saved_view(
"""Delete a saved view (soft-delete).""" """Delete a saved view (soft-delete)."""
tenant_id = uuid.UUID(current_user["tenant_id"]) tenant_id = uuid.UUID(current_user["tenant_id"])
user_id = uuid.UUID(current_user["user_id"]) user_id = uuid.UUID(current_user["user_id"])
is_admin = current_user.get("is_system_admin", False)
try: try:
vid = uuid.UUID(view_id) try:
except (ValueError, TypeError): vid = uuid.UUID(view_id)
raise HTTPException(400, detail={"detail": "Invalid view_id", "code": "invalid_id"}) from None except (ValueError, TypeError):
raise HTTPException(400, detail={"detail": "Invalid view_id", "code": "invalid_id"}) from None
result = await db.execute( result = await db.execute(
select(SavedView).where( select(SavedView).where(
SavedView.id == vid, SavedView.id == vid,
SavedView.tenant_id == tenant_id, SavedView.tenant_id == tenant_id,
SavedView.user_id == user_id, SavedView.user_id == user_id,
SavedView.deleted_at.is_(None), SavedView.deleted_at.is_(None),
)
) )
) saved = result.scalar_one_or_none()
saved = result.scalar_one_or_none() if saved is None:
if saved is None: raise HTTPException(404, detail={"detail": "Saved view not found", "code": "not_found"})
raise HTTPException(404, detail={"detail": "Saved view not found", "code": "not_found"})
from datetime import datetime, timezone from datetime import datetime, timezone
saved.deleted_at = datetime.now(timezone.utc) saved.deleted_at = datetime.now(timezone.utc)
await db.flush() await db.flush()
return Response(status_code=status.HTTP_204_NO_CONTENT) return Response(status_code=status.HTTP_204_NO_CONTENT)
except PermissionError as e:
raise HTTPException(status_code=403, detail=str(e)) from e
+21 -8
View File
@@ -22,9 +22,13 @@ async def list_sequences(
): ):
"""List all sequences for the current tenant. Admin only.""" """List all sequences for the current tenant. Admin only."""
tenant_id = uuid.UUID(current_user["tenant_id"]) tenant_id = uuid.UUID(current_user["tenant_id"])
user_id = uuid.UUID(current_user["user_id"])
is_admin = current_user.get("is_system_admin", False)
try:
return await sequence_service.list_sequences(db, tenant_id) return await sequence_service.list_sequences(db, tenant_id, user_id=user_id, is_system_admin=is_admin)
except PermissionError as e:
raise HTTPException(status_code=403, detail=str(e)) from e
@router.post("", status_code=status.HTTP_201_CREATED) @router.post("", status_code=status.HTTP_201_CREATED)
@@ -36,10 +40,13 @@ async def create_sequence(
"""Create a new sequence. Admin only.""" """Create a new sequence. Admin only."""
tenant_id = uuid.UUID(current_user["tenant_id"]) tenant_id = uuid.UUID(current_user["tenant_id"])
user_id = uuid.UUID(current_user["user_id"]) user_id = uuid.UUID(current_user["user_id"])
is_admin = current_user.get("is_system_admin", False)
data = body.model_dump() data = body.model_dump()
return await sequence_service.create_sequence(db, tenant_id, user_id, data) try:
return await sequence_service.create_sequence(db, tenant_id, user_id, data, is_system_admin=is_admin)
except PermissionError as e:
raise HTTPException(status_code=403, detail=str(e)) from e
@router.patch("/{sequence_id}") @router.patch("/{sequence_id}")
@@ -52,7 +59,7 @@ async def update_sequence(
"""Update a sequence (name, prefix, padding only). Admin only.""" """Update a sequence (name, prefix, padding only). Admin only."""
tenant_id = uuid.UUID(current_user["tenant_id"]) tenant_id = uuid.UUID(current_user["tenant_id"])
user_id = uuid.UUID(current_user["user_id"]) user_id = uuid.UUID(current_user["user_id"])
is_admin = current_user.get("is_system_admin", False)
try: try:
sid = uuid.UUID(sequence_id) sid = uuid.UUID(sequence_id)
@@ -60,7 +67,10 @@ async def update_sequence(
raise HTTPException(400, detail={"detail": "Invalid sequence_id", "code": "invalid_id"}) from None raise HTTPException(400, detail={"detail": "Invalid sequence_id", "code": "invalid_id"}) from None
data = body.model_dump(exclude_unset=True) data = body.model_dump(exclude_unset=True)
result = await sequence_service.update_sequence(db, tenant_id, user_id, sid, data) try:
result = await sequence_service.update_sequence(db, tenant_id, user_id, sid, data, is_system_admin=is_admin)
except PermissionError as e:
raise HTTPException(status_code=403, detail=str(e)) from e
if result is None: if result is None:
raise HTTPException(404, detail={"detail": "Sequence not found", "code": "not_found"}) raise HTTPException(404, detail={"detail": "Sequence not found", "code": "not_found"})
return result return result
@@ -75,13 +85,16 @@ async def delete_sequence(
"""Delete a sequence (soft-delete). Admin only.""" """Delete a sequence (soft-delete). Admin only."""
tenant_id = uuid.UUID(current_user["tenant_id"]) tenant_id = uuid.UUID(current_user["tenant_id"])
user_id = uuid.UUID(current_user["user_id"]) user_id = uuid.UUID(current_user["user_id"])
is_admin = current_user.get("is_system_admin", False)
try: try:
sid = uuid.UUID(sequence_id) sid = uuid.UUID(sequence_id)
except ValueError: except ValueError:
raise HTTPException(400, detail={"detail": "Invalid sequence_id", "code": "invalid_id"}) from None raise HTTPException(400, detail={"detail": "Invalid sequence_id", "code": "invalid_id"}) from None
deleted = await sequence_service.delete_sequence(db, tenant_id, user_id, sid) try:
deleted = await sequence_service.delete_sequence(db, tenant_id, user_id, sid, is_system_admin=is_admin)
except PermissionError as e:
raise HTTPException(status_code=403, detail=str(e)) from e
if not deleted: if not deleted:
raise HTTPException(404, detail={"detail": "Sequence not found", "code": "not_found"}) raise HTTPException(404, detail={"detail": "Sequence not found", "code": "not_found"})
+50 -13
View File
@@ -31,8 +31,14 @@ async def list_webhooks(
): ):
"""List all webhooks for the current tenant.""" """List all webhooks for the current tenant."""
tenant_id = uuid.UUID(current_user["tenant_id"]) tenant_id = uuid.UUID(current_user["tenant_id"])
webhooks = await webhook_service.list_webhooks(db, tenant_id, event=event) user_id = uuid.UUID(current_user["user_id"])
return webhooks is_admin = current_user.get("is_system_admin", False)
try:
webhooks = await webhook_service.list_webhooks(db, tenant_id, event=event, user_id=user_id, is_system_admin=is_admin)
return webhooks
except PermissionError as e:
raise HTTPException(status_code=403, detail=str(e)) from e
@router.post( @router.post(
@@ -49,10 +55,15 @@ async def create_webhook(
"""Create a new webhook subscription.""" """Create a new webhook subscription."""
tenant_id = uuid.UUID(current_user["tenant_id"]) tenant_id = uuid.UUID(current_user["tenant_id"])
user_id = uuid.UUID(current_user["user_id"]) user_id = uuid.UUID(current_user["user_id"])
webhook = await webhook_service.create_webhook( is_admin = current_user.get("is_system_admin", False)
db, tenant_id, user_id, body.model_dump()
) try:
return webhook webhook = await webhook_service.create_webhook(
db, tenant_id, user_id, body.model_dump(), is_system_admin=is_admin
)
return webhook
except PermissionError as e:
raise HTTPException(status_code=403, detail=str(e)) from e
@router.get( @router.get(
@@ -67,12 +78,18 @@ async def get_webhook(
): ):
"""Get a single webhook by ID.""" """Get a single webhook by ID."""
tenant_id = uuid.UUID(current_user["tenant_id"]) tenant_id = uuid.UUID(current_user["tenant_id"])
user_id = uuid.UUID(current_user["user_id"])
is_admin = current_user.get("is_system_admin", False)
try: try:
wh_id = uuid.UUID(webhook_id) wh_id = uuid.UUID(webhook_id)
except (ValueError, TypeError): except (ValueError, TypeError):
raise HTTPException(400, detail={"detail": "Invalid webhook_id", "code": "invalid_id"}) from None raise HTTPException(400, detail={"detail": "Invalid webhook_id", "code": "invalid_id"}) from None
webhook = await webhook_service.get_webhook(db, tenant_id, wh_id) try:
webhook = await webhook_service.get_webhook(db, tenant_id, wh_id, user_id=user_id, is_system_admin=is_admin)
except PermissionError as e:
raise HTTPException(status_code=403, detail=str(e)) from e
if webhook is None: if webhook is None:
raise HTTPException(404, detail={"detail": "Webhook not found", "code": "not_found"}) raise HTTPException(404, detail={"detail": "Webhook not found", "code": "not_found"})
return webhook return webhook
@@ -92,6 +109,8 @@ async def update_webhook(
"""Update an existing webhook subscription.""" """Update an existing webhook subscription."""
tenant_id = uuid.UUID(current_user["tenant_id"]) tenant_id = uuid.UUID(current_user["tenant_id"])
user_id = uuid.UUID(current_user["user_id"]) user_id = uuid.UUID(current_user["user_id"])
is_admin = current_user.get("is_system_admin", False)
try: try:
wh_id = uuid.UUID(webhook_id) wh_id = uuid.UUID(webhook_id)
except (ValueError, TypeError): except (ValueError, TypeError):
@@ -101,9 +120,12 @@ async def update_webhook(
if not update_data: if not update_data:
raise HTTPException(400, detail={"detail": "No fields to update", "code": "no_updates"}) raise HTTPException(400, detail={"detail": "No fields to update", "code": "no_updates"})
webhook = await webhook_service.update_webhook( try:
db, tenant_id, wh_id, update_data, user_id=user_id webhook = await webhook_service.update_webhook(
) db, tenant_id, wh_id, update_data, user_id=user_id, is_system_admin=is_admin
)
except PermissionError as e:
raise HTTPException(status_code=403, detail=str(e)) from e
if webhook is None: if webhook is None:
raise HTTPException(404, detail={"detail": "Webhook not found", "code": "not_found"}) raise HTTPException(404, detail={"detail": "Webhook not found", "code": "not_found"})
return webhook return webhook
@@ -121,12 +143,18 @@ async def delete_webhook(
): ):
"""Delete a webhook subscription.""" """Delete a webhook subscription."""
tenant_id = uuid.UUID(current_user["tenant_id"]) tenant_id = uuid.UUID(current_user["tenant_id"])
user_id = uuid.UUID(current_user["user_id"])
is_admin = current_user.get("is_system_admin", False)
try: try:
wh_id = uuid.UUID(webhook_id) wh_id = uuid.UUID(webhook_id)
except (ValueError, TypeError): except (ValueError, TypeError):
raise HTTPException(400, detail={"detail": "Invalid webhook_id", "code": "invalid_id"}) from None raise HTTPException(400, detail={"detail": "Invalid webhook_id", "code": "invalid_id"}) from None
deleted = await webhook_service.delete_webhook(db, tenant_id, wh_id) try:
deleted = await webhook_service.delete_webhook(db, tenant_id, wh_id, user_id=user_id, is_system_admin=is_admin)
except PermissionError as e:
raise HTTPException(status_code=403, detail=str(e)) from e
if not deleted: if not deleted:
raise HTTPException(404, detail={"detail": "Webhook not found", "code": "not_found"}) raise HTTPException(404, detail={"detail": "Webhook not found", "code": "not_found"})
return None return None
@@ -143,12 +171,18 @@ async def test_webhook(
): ):
"""Send a test payload to a webhook to verify connectivity.""" """Send a test payload to a webhook to verify connectivity."""
tenant_id = uuid.UUID(current_user["tenant_id"]) tenant_id = uuid.UUID(current_user["tenant_id"])
user_id = uuid.UUID(current_user["user_id"])
is_admin = current_user.get("is_system_admin", False)
try: try:
wh_id = uuid.UUID(webhook_id) wh_id = uuid.UUID(webhook_id)
except (ValueError, TypeError): except (ValueError, TypeError):
raise HTTPException(400, detail={"detail": "Invalid webhook_id", "code": "invalid_id"}) from None raise HTTPException(400, detail={"detail": "Invalid webhook_id", "code": "invalid_id"}) from None
webhook = await webhook_service.get_webhook(db, tenant_id, wh_id) try:
webhook = await webhook_service.get_webhook(db, tenant_id, wh_id, user_id=user_id, is_system_admin=is_admin)
except PermissionError as e:
raise HTTPException(status_code=403, detail=str(e)) from e
if webhook is None: if webhook is None:
raise HTTPException(404, detail={"detail": "Webhook not found", "code": "not_found"}) raise HTTPException(404, detail={"detail": "Webhook not found", "code": "not_found"})
@@ -157,5 +191,8 @@ async def test_webhook(
"message": "This is a test webhook from LeoCRM", "message": "This is a test webhook from LeoCRM",
"webhook_id": str(webhook.id), "webhook_id": str(webhook.id),
} }
result = await webhook_service.send_webhook(webhook, "webhook.test", test_payload) try:
result = await webhook_service.send_webhook(webhook, "webhook.test", test_payload, user_id=user_id, is_system_admin=is_admin)
except PermissionError as e:
raise HTTPException(status_code=403, detail=str(e)) from e
return result return result
+96 -44
View File
@@ -28,13 +28,21 @@ async def list_workflows(
): ):
"""List workflows with pagination.""" """List workflows with pagination."""
tenant_id = uuid.UUID(current_user["tenant_id"]) tenant_id = uuid.UUID(current_user["tenant_id"])
return await workflow_service.list_workflows( user_id = uuid.UUID(current_user["user_id"])
db, is_admin = current_user.get("is_system_admin", False)
tenant_id,
page=page, try:
page_size=page_size, return await workflow_service.list_workflows(
is_active=is_active, db,
) tenant_id,
page=page,
page_size=page_size,
is_active=is_active,
user_id=user_id,
is_system_admin=is_admin,
)
except PermissionError as e:
raise HTTPException(status_code=403, detail=str(e)) from e
@router.post("", status_code=status.HTTP_201_CREATED) @router.post("", status_code=status.HTTP_201_CREATED)
@@ -46,10 +54,13 @@ async def create_workflow(
"""Create a new workflow definition. Requires write permission.""" """Create a new workflow definition. Requires write permission."""
tenant_id = uuid.UUID(current_user["tenant_id"]) tenant_id = uuid.UUID(current_user["tenant_id"])
user_id = uuid.UUID(current_user["user_id"]) user_id = uuid.UUID(current_user["user_id"])
is_admin = current_user.get("is_system_admin", False)
data = body.model_dump() data = body.model_dump()
return await workflow_service.create_workflow(db, tenant_id, user_id, data) try:
return await workflow_service.create_workflow(db, tenant_id, user_id, data, is_system_admin=is_admin)
except PermissionError as e:
raise HTTPException(status_code=403, detail=str(e)) from e
@router.get("/instances") @router.get("/instances")
@@ -62,13 +73,21 @@ async def list_instances(
): ):
"""List workflow instances with optional status filter.""" """List workflow instances with optional status filter."""
tenant_id = uuid.UUID(current_user["tenant_id"]) tenant_id = uuid.UUID(current_user["tenant_id"])
return await workflow_service.list_instances( user_id = uuid.UUID(current_user["user_id"])
db, is_admin = current_user.get("is_system_admin", False)
tenant_id,
page=page, try:
page_size=page_size, return await workflow_service.list_instances(
status_filter=status, db,
) tenant_id,
page=page,
page_size=page_size,
status_filter=status,
user_id=user_id,
is_system_admin=is_admin,
)
except PermissionError as e:
raise HTTPException(status_code=403, detail=str(e)) from e
@router.get("/{workflow_id}") @router.get("/{workflow_id}")
@@ -79,7 +98,13 @@ async def get_workflow(
): ):
"""Get a single workflow by ID.""" """Get a single workflow by ID."""
tenant_id = uuid.UUID(current_user["tenant_id"]) tenant_id = uuid.UUID(current_user["tenant_id"])
result = await workflow_service.get_workflow(db, tenant_id, workflow_id) user_id = uuid.UUID(current_user["user_id"])
is_admin = current_user.get("is_system_admin", False)
try:
result = await workflow_service.get_workflow(db, tenant_id, workflow_id, user_id=user_id, is_system_admin=is_admin)
except PermissionError as e:
raise HTTPException(status_code=403, detail=str(e)) from e
if result is None: if result is None:
raise HTTPException( raise HTTPException(
status_code=status.HTTP_404_NOT_FOUND, status_code=status.HTTP_404_NOT_FOUND,
@@ -98,10 +123,13 @@ async def update_workflow(
"""Update a workflow definition.""" """Update a workflow definition."""
tenant_id = uuid.UUID(current_user["tenant_id"]) tenant_id = uuid.UUID(current_user["tenant_id"])
user_id = uuid.UUID(current_user["user_id"]) user_id = uuid.UUID(current_user["user_id"])
is_admin = current_user.get("is_system_admin", False)
data = body.model_dump(exclude_unset=True) data = body.model_dump(exclude_unset=True)
result = await workflow_service.update_workflow(db, tenant_id, user_id, workflow_id, data) try:
result = await workflow_service.update_workflow(db, tenant_id, user_id, workflow_id, data, is_system_admin=is_admin)
except PermissionError as e:
raise HTTPException(status_code=403, detail=str(e)) from e
if result is None: if result is None:
raise HTTPException( raise HTTPException(
status_code=status.HTTP_404_NOT_FOUND, status_code=status.HTTP_404_NOT_FOUND,
@@ -119,9 +147,12 @@ async def delete_workflow(
"""Delete a workflow definition.""" """Delete a workflow definition."""
tenant_id = uuid.UUID(current_user["tenant_id"]) tenant_id = uuid.UUID(current_user["tenant_id"])
user_id = uuid.UUID(current_user["user_id"]) user_id = uuid.UUID(current_user["user_id"])
is_admin = current_user.get("is_system_admin", False)
try:
deleted = await workflow_service.delete_workflow(db, tenant_id, user_id, workflow_id) deleted = await workflow_service.delete_workflow(db, tenant_id, user_id, workflow_id, is_system_admin=is_admin)
except PermissionError as e:
raise HTTPException(status_code=403, detail=str(e)) from e
if not deleted: if not deleted:
raise HTTPException( raise HTTPException(
status_code=status.HTTP_404_NOT_FOUND, status_code=status.HTTP_404_NOT_FOUND,
@@ -143,15 +174,20 @@ async def create_instance(
"""Create a new workflow instance.""" """Create a new workflow instance."""
tenant_id = uuid.UUID(current_user["tenant_id"]) tenant_id = uuid.UUID(current_user["tenant_id"])
user_id = uuid.UUID(current_user["user_id"]) user_id = uuid.UUID(current_user["user_id"])
is_admin = current_user.get("is_system_admin", False)
result = await workflow_service.create_instance( try:
db, result = await workflow_service.create_instance(
tenant_id, db,
user_id, tenant_id,
workflow_id=workflow_id, user_id,
context=body.context, workflow_id=workflow_id,
timeout_hours=body.timeout_hours, context=body.context,
) timeout_hours=body.timeout_hours,
is_system_admin=is_admin,
)
except PermissionError as e:
raise HTTPException(status_code=403, detail=str(e)) from e
if result is None: if result is None:
raise HTTPException( raise HTTPException(
status_code=status.HTTP_404_NOT_FOUND, status_code=status.HTTP_404_NOT_FOUND,
@@ -168,7 +204,13 @@ async def get_instance(
): ):
"""Get a workflow instance with step history.""" """Get a workflow instance with step history."""
tenant_id = uuid.UUID(current_user["tenant_id"]) tenant_id = uuid.UUID(current_user["tenant_id"])
result = await workflow_service.get_instance(db, tenant_id, instance_id) user_id = uuid.UUID(current_user["user_id"])
is_admin = current_user.get("is_system_admin", False)
try:
result = await workflow_service.get_instance(db, tenant_id, instance_id, user_id=user_id, is_system_admin=is_admin)
except PermissionError as e:
raise HTTPException(status_code=403, detail=str(e)) from e
if result is None: if result is None:
raise HTTPException( raise HTTPException(
status_code=status.HTTP_404_NOT_FOUND, status_code=status.HTTP_404_NOT_FOUND,
@@ -191,15 +233,20 @@ async def advance_instance(
""" """
tenant_id = uuid.UUID(current_user["tenant_id"]) tenant_id = uuid.UUID(current_user["tenant_id"])
user_id = uuid.UUID(current_user["user_id"]) user_id = uuid.UUID(current_user["user_id"])
is_admin = current_user.get("is_system_admin", False)
result = await workflow_service.advance_instance( try:
db, result = await workflow_service.advance_instance(
tenant_id, db,
user_id, tenant_id,
instance_id=instance_id, user_id,
decision=body.decision, instance_id=instance_id,
comment=body.comment, decision=body.decision,
) comment=body.comment,
is_system_admin=is_admin,
)
except PermissionError as e:
raise HTTPException(status_code=403, detail=str(e)) from e
if result is None: if result is None:
raise HTTPException( raise HTTPException(
status_code=status.HTTP_404_NOT_FOUND, status_code=status.HTTP_404_NOT_FOUND,
@@ -222,13 +269,18 @@ async def cancel_instance(
"""Cancel a workflow instance. Returns 200 with cancelled instance.""" """Cancel a workflow instance. Returns 200 with cancelled instance."""
tenant_id = uuid.UUID(current_user["tenant_id"]) tenant_id = uuid.UUID(current_user["tenant_id"])
user_id = uuid.UUID(current_user["user_id"]) user_id = uuid.UUID(current_user["user_id"])
is_admin = current_user.get("is_system_admin", False)
result = await workflow_service.cancel_instance( try:
db, result = await workflow_service.cancel_instance(
tenant_id, db,
user_id, tenant_id,
instance_id=instance_id, user_id,
) instance_id=instance_id,
is_system_admin=is_admin,
)
except PermissionError as e:
raise HTTPException(status_code=403, detail=str(e)) from e
if result is None: if result is None:
raise HTTPException( raise HTTPException(
status_code=status.HTTP_404_NOT_FOUND, status_code=status.HTTP_404_NOT_FOUND,
+24
View File
@@ -11,6 +11,7 @@ from sqlalchemy.ext.asyncio import AsyncSession
from app.core.audit import log_audit from app.core.audit import log_audit
from app.models.address import Address from app.models.address import Address
from app.core.visibility import apply_visibility_filter, check_single_entity_access
VALID_ENTITY_TYPES = {"contact"} VALID_ENTITY_TYPES = {"contact"}
@@ -42,6 +43,8 @@ async def list_addresses(
tenant_id: uuid.UUID, tenant_id: uuid.UUID,
entity_type: str, entity_type: str,
entity_id: uuid.UUID, entity_id: uuid.UUID,
user_id: uuid.UUID | None = None,
is_system_admin: bool = False,
) -> dict[str, Any]: ) -> dict[str, Any]:
"""List all addresses for a given entity within a tenant.""" """List all addresses for a given entity within a tenant."""
q = ( q = (
@@ -54,6 +57,10 @@ async def list_addresses(
) )
.order_by(Address.is_default.desc(), Address.label.asc()) .order_by(Address.is_default.desc(), Address.label.asc())
) )
if user_id and not is_system_admin:
q = await apply_visibility_filter(
db, q, "address", Address, user_id, tenant_id, is_system_admin
)
result = await db.execute(q) result = await db.execute(q)
addresses = result.scalars().all() addresses = result.scalars().all()
return { return {
@@ -104,6 +111,7 @@ async def create_address(
state=data.get("state"), state=data.get("state"),
country=data.get("country"), country=data.get("country"),
is_default=data.get("is_default", False), is_default=data.get("is_default", False),
owner_id=user_id,
) )
db.add(address) db.add(address)
await db.flush() await db.flush()
@@ -121,6 +129,7 @@ async def update_address(
user_id: uuid.UUID, user_id: uuid.UUID,
address_id: uuid.UUID, address_id: uuid.UUID,
data: dict[str, Any], data: dict[str, Any],
is_system_admin: bool = False,
) -> dict[str, Any] | None: ) -> dict[str, Any] | None:
"""Update an address. If setting is_default=True, unset other defaults of same type first.""" """Update an address. If setting is_default=True, unset other defaults of same type first."""
q = select(Address).where( q = select(Address).where(
@@ -133,6 +142,13 @@ async def update_address(
if address is None: if address is None:
return None return None
if not is_system_admin:
has_access = await check_single_entity_access(
db, "address", address.id, user_id, tenant_id, "write", is_system_admin
)
if not has_access:
raise PermissionError("No access")
if data.get("is_default") is True and not address.is_default: if data.get("is_default") is True and not address.is_default:
await db.execute( await db.execute(
update(Address) update(Address)
@@ -166,6 +182,7 @@ async def delete_address(
tenant_id: uuid.UUID, tenant_id: uuid.UUID,
user_id: uuid.UUID, user_id: uuid.UUID,
address_id: uuid.UUID, address_id: uuid.UUID,
is_system_admin: bool = False,
) -> bool: ) -> bool:
"""Soft-delete an address.""" """Soft-delete an address."""
q = select(Address).where( q = select(Address).where(
@@ -178,6 +195,13 @@ async def delete_address(
if address is None: if address is None:
return False return False
if not is_system_admin:
has_access = await check_single_entity_access(
db, "address", address.id, user_id, tenant_id, "admin", is_system_admin
)
if not has_access:
raise PermissionError("No access")
address.deleted_at = datetime.now(UTC) address.deleted_at = datetime.now(UTC)
await db.flush() await db.flush()
await log_audit( await log_audit(
+24
View File
@@ -13,6 +13,7 @@ from sqlalchemy.ext.asyncio import AsyncSession
from app.core.audit import log_audit from app.core.audit import log_audit
from app.core.storage import get_storage_backend from app.core.storage import get_storage_backend
from app.models.attachment import Attachment from app.models.attachment import Attachment
from app.core.visibility import apply_visibility_filter, check_single_entity_access
def _attachment_to_dict(a: Attachment) -> dict[str, Any]: def _attachment_to_dict(a: Attachment) -> dict[str, Any]:
@@ -68,6 +69,7 @@ async def save_attachment(
mime_type=mime_type, mime_type=mime_type,
file_size=file_size, file_size=file_size,
uploaded_by=user_id, uploaded_by=user_id,
owner_id=user_id,
) )
db.add(attachment) db.add(attachment)
await db.flush() await db.flush()
@@ -84,6 +86,8 @@ async def list_attachments(
tenant_id: uuid.UUID, tenant_id: uuid.UUID,
entity_type: str, entity_type: str,
entity_id: uuid.UUID, entity_id: uuid.UUID,
user_id: uuid.UUID | None = None,
is_system_admin: bool = False,
) -> dict[str, Any]: ) -> dict[str, Any]:
"""List attachments for a specific entity.""" """List attachments for a specific entity."""
q = select(Attachment).where( q = select(Attachment).where(
@@ -92,6 +96,10 @@ async def list_attachments(
Attachment.entity_id == entity_id, Attachment.entity_id == entity_id,
Attachment.deleted_at.is_(None), Attachment.deleted_at.is_(None),
).order_by(Attachment.created_at.desc()) ).order_by(Attachment.created_at.desc())
if user_id and not is_system_admin:
q = await apply_visibility_filter(
db, q, "attachment", Attachment, user_id, tenant_id, is_system_admin
)
result = await db.execute(q) result = await db.execute(q)
attachments = result.scalars().all() attachments = result.scalars().all()
return { return {
@@ -104,6 +112,8 @@ async def get_attachment(
db: AsyncSession, db: AsyncSession,
tenant_id: uuid.UUID, tenant_id: uuid.UUID,
attachment_id: uuid.UUID, attachment_id: uuid.UUID,
user_id: uuid.UUID | None = None,
is_system_admin: bool = False,
) -> dict[str, Any] | None: ) -> dict[str, Any] | None:
"""Get a single attachment by ID.""" """Get a single attachment by ID."""
q = select(Attachment).where( q = select(Attachment).where(
@@ -115,6 +125,12 @@ async def get_attachment(
attachment = result.scalar_one_or_none() attachment = result.scalar_one_or_none()
if attachment is None: if attachment is None:
return None return None
if user_id and not is_system_admin:
has_access = await check_single_entity_access(
db, "attachment", attachment.id, user_id, tenant_id, "read", is_system_admin
)
if not has_access:
raise PermissionError("No access")
return _attachment_to_dict(attachment) return _attachment_to_dict(attachment)
@@ -123,6 +139,7 @@ async def delete_attachment(
tenant_id: uuid.UUID, tenant_id: uuid.UUID,
user_id: uuid.UUID, user_id: uuid.UUID,
attachment_id: uuid.UUID, attachment_id: uuid.UUID,
is_system_admin: bool = False,
) -> bool: ) -> bool:
"""Soft-delete an attachment (keeps file on disk for audit trail).""" """Soft-delete an attachment (keeps file on disk for audit trail)."""
q = select(Attachment).where( q = select(Attachment).where(
@@ -135,6 +152,13 @@ async def delete_attachment(
if attachment is None: if attachment is None:
return False return False
if not is_system_admin:
has_access = await check_single_entity_access(
db, "attachment", attachment.id, user_id, tenant_id, "admin", is_system_admin
)
if not has_access:
raise PermissionError("No access")
attachment.deleted_at = datetime.now(UTC) attachment.deleted_at = datetime.now(UTC)
await db.flush() await db.flush()
await log_audit( await log_audit(
+24
View File
@@ -11,6 +11,7 @@ from sqlalchemy.ext.asyncio import AsyncSession
from app.core.audit import log_audit from app.core.audit import log_audit
from app.models.bank_account import BankAccount from app.models.bank_account import BankAccount
from app.core.visibility import apply_visibility_filter, check_single_entity_access
def _account_to_dict(a: BankAccount) -> dict[str, Any]: def _account_to_dict(a: BankAccount) -> dict[str, Any]:
@@ -31,6 +32,8 @@ def _account_to_dict(a: BankAccount) -> dict[str, Any]:
async def list_bank_accounts( async def list_bank_accounts(
db: AsyncSession, db: AsyncSession,
tenant_id: uuid.UUID, tenant_id: uuid.UUID,
user_id: uuid.UUID | None = None,
is_system_admin: bool = False,
) -> dict[str, Any]: ) -> dict[str, Any]:
"""List all bank accounts for a tenant.""" """List all bank accounts for a tenant."""
q = ( q = (
@@ -41,6 +44,10 @@ async def list_bank_accounts(
) )
.order_by(BankAccount.is_default.desc(), BankAccount.bank_name.asc()) .order_by(BankAccount.is_default.desc(), BankAccount.bank_name.asc())
) )
if user_id and not is_system_admin:
q = await apply_visibility_filter(
db, q, "bank_account", BankAccount, user_id, tenant_id, is_system_admin
)
result = await db.execute(q) result = await db.execute(q)
accounts = result.scalars().all() accounts = result.scalars().all()
return { return {
@@ -75,6 +82,7 @@ async def create_bank_account(
account_holder=data.get("account_holder"), account_holder=data.get("account_holder"),
default_tax=data.get("default_tax"), default_tax=data.get("default_tax"),
is_default=data.get("is_default", False), is_default=data.get("is_default", False),
owner_id=user_id,
) )
db.add(account) db.add(account)
await db.flush() await db.flush()
@@ -92,6 +100,7 @@ async def update_bank_account(
user_id: uuid.UUID, user_id: uuid.UUID,
account_id: uuid.UUID, account_id: uuid.UUID,
data: dict[str, Any], data: dict[str, Any],
is_system_admin: bool = False,
) -> dict[str, Any] | None: ) -> dict[str, Any] | None:
"""Update a bank account. If setting is_default=True, unset other defaults first.""" """Update a bank account. If setting is_default=True, unset other defaults first."""
q = select(BankAccount).where( q = select(BankAccount).where(
@@ -104,6 +113,13 @@ async def update_bank_account(
if account is None: if account is None:
return None return None
if not is_system_admin:
has_access = await check_single_entity_access(
db, "bank_account", account.id, user_id, tenant_id, "write", is_system_admin
)
if not has_access:
raise PermissionError("No access")
if data.get("is_default") is True and not account.is_default: if data.get("is_default") is True and not account.is_default:
await db.execute( await db.execute(
update(BankAccount) update(BankAccount)
@@ -134,6 +150,7 @@ async def delete_bank_account(
tenant_id: uuid.UUID, tenant_id: uuid.UUID,
user_id: uuid.UUID, user_id: uuid.UUID,
account_id: uuid.UUID, account_id: uuid.UUID,
is_system_admin: bool = False,
) -> bool: ) -> bool:
"""Soft-delete a bank account.""" """Soft-delete a bank account."""
q = select(BankAccount).where( q = select(BankAccount).where(
@@ -146,6 +163,13 @@ async def delete_bank_account(
if account is None: if account is None:
return False return False
if not is_system_admin:
has_access = await check_single_entity_access(
db, "bank_account", account.id, user_id, tenant_id, "admin", is_system_admin
)
if not has_access:
raise PermissionError("No access")
account.deleted_at = datetime.now(UTC) account.deleted_at = datetime.now(UTC)
await db.flush() await db.flush()
await log_audit( await log_audit(
+162
View File
@@ -0,0 +1,162 @@
"""SavedFilter service — CRUD with tenant isolation and visibility filter."""
from __future__ import annotations
import uuid
from datetime import UTC, datetime
from typing import Any
from sqlalchemy import select
from sqlalchemy.ext.asyncio import AsyncSession
from app.core.visibility import apply_visibility_filter, check_single_entity_access
from app.models.saved_filter import SavedFilter
def _filter_to_dict(f: SavedFilter) -> dict[str, Any]:
"""Serialize a SavedFilter ORM object to dict."""
return {
"id": str(f.id),
"name": f.name,
"entity_type": f.entity_type,
"filter_criteria": f.filter_criteria,
"user_id": str(f.user_id),
"created_at": f.created_at.isoformat() if f.created_at else None,
"updated_at": f.updated_at.isoformat() if f.updated_at else None,
}
async def list_saved_filters(
db: AsyncSession,
tenant_id: uuid.UUID,
entity_type: str | None = None,
user_id: uuid.UUID | None = None,
is_system_admin: bool = False,
) -> list[dict[str, Any]]:
"""List saved filters for a tenant, optionally filtered by entity_type."""
q = select(SavedFilter).where(
SavedFilter.tenant_id == tenant_id,
SavedFilter.deleted_at.is_(None),
)
if entity_type:
q = q.where(SavedFilter.entity_type == entity_type)
if user_id and not is_system_admin:
q = await apply_visibility_filter(
db, q, "saved_filter", SavedFilter, user_id, tenant_id, is_system_admin
)
q = q.order_by(SavedFilter.name)
result = await db.execute(q)
return [_filter_to_dict(f) for f in result.scalars().all()]
async def get_saved_filter(
db: AsyncSession,
tenant_id: uuid.UUID,
filter_id: uuid.UUID,
user_id: uuid.UUID | None = None,
is_system_admin: bool = False,
) -> dict[str, Any] | None:
"""Get a single saved filter by ID."""
q = select(SavedFilter).where(
SavedFilter.id == filter_id,
SavedFilter.tenant_id == tenant_id,
SavedFilter.deleted_at.is_(None),
)
result = await db.execute(q)
saved = result.scalar_one_or_none()
if saved is None:
return None
if user_id and not is_system_admin:
has_access = await check_single_entity_access(
db, "saved_filter", saved.id, user_id, tenant_id, "read", is_system_admin
)
if not has_access:
raise PermissionError("No access")
return _filter_to_dict(saved)
async def create_saved_filter(
db: AsyncSession,
tenant_id: uuid.UUID,
user_id: uuid.UUID,
data: dict[str, Any],
) -> dict[str, Any]:
"""Create a new saved filter."""
saved = SavedFilter(
tenant_id=tenant_id,
user_id=user_id,
name=data["name"],
entity_type=data["entity_type"],
filter_criteria=data.get("filter_criteria", {}),
owner_id=user_id,
)
db.add(saved)
await db.flush()
await db.refresh(saved)
return _filter_to_dict(saved)
async def update_saved_filter(
db: AsyncSession,
tenant_id: uuid.UUID,
user_id: uuid.UUID,
filter_id: uuid.UUID,
data: dict[str, Any],
is_system_admin: bool = False,
) -> dict[str, Any] | None:
"""Update a saved filter."""
q = select(SavedFilter).where(
SavedFilter.id == filter_id,
SavedFilter.tenant_id == tenant_id,
SavedFilter.deleted_at.is_(None),
)
result = await db.execute(q)
saved = result.scalar_one_or_none()
if saved is None:
return None
if not is_system_admin:
has_access = await check_single_entity_access(
db, "saved_filter", saved.id, user_id, tenant_id, "write", is_system_admin
)
if not has_access:
raise PermissionError("No access")
if "name" in data and data["name"] is not None:
saved.name = data["name"]
if "filter_criteria" in data and data["filter_criteria"] is not None:
saved.filter_criteria = data["filter_criteria"]
await db.flush()
await db.refresh(saved)
return _filter_to_dict(saved)
async def delete_saved_filter(
db: AsyncSession,
tenant_id: uuid.UUID,
user_id: uuid.UUID,
filter_id: uuid.UUID,
is_system_admin: bool = False,
) -> bool:
"""Soft-delete a saved filter."""
q = select(SavedFilter).where(
SavedFilter.id == filter_id,
SavedFilter.tenant_id == tenant_id,
SavedFilter.deleted_at.is_(None),
)
result = await db.execute(q)
saved = result.scalar_one_or_none()
if saved is None:
return False
if not is_system_admin:
has_access = await check_single_entity_access(
db, "saved_filter", saved.id, user_id, tenant_id, "admin", is_system_admin
)
if not has_access:
raise PermissionError("No access")
saved.deleted_at = datetime.now(UTC)
await db.flush()
return True
+162
View File
@@ -0,0 +1,162 @@
"""SavedView service — CRUD with tenant isolation and visibility filter."""
from __future__ import annotations
import uuid
from datetime import UTC, datetime
from typing import Any
from sqlalchemy import select
from sqlalchemy.ext.asyncio import AsyncSession
from app.core.visibility import apply_visibility_filter, check_single_entity_access
from app.models.saved_view import SavedView
def _view_to_dict(v: SavedView) -> dict[str, Any]:
"""Serialize a SavedView ORM object to dict."""
return {
"id": str(v.id),
"name": v.name,
"entity_type": v.entity_type,
"view_config": v.view_config,
"user_id": str(v.user_id),
"created_at": v.created_at.isoformat() if v.created_at else None,
"updated_at": v.updated_at.isoformat() if v.updated_at else None,
}
async def list_saved_views(
db: AsyncSession,
tenant_id: uuid.UUID,
entity_type: str | None = None,
user_id: uuid.UUID | None = None,
is_system_admin: bool = False,
) -> list[dict[str, Any]]:
"""List saved views for a tenant, optionally filtered by entity_type."""
q = select(SavedView).where(
SavedView.tenant_id == tenant_id,
SavedView.deleted_at.is_(None),
)
if entity_type:
q = q.where(SavedView.entity_type == entity_type)
if user_id and not is_system_admin:
q = await apply_visibility_filter(
db, q, "saved_view", SavedView, user_id, tenant_id, is_system_admin
)
q = q.order_by(SavedView.name)
result = await db.execute(q)
return [_view_to_dict(v) for v in result.scalars().all()]
async def get_saved_view(
db: AsyncSession,
tenant_id: uuid.UUID,
view_id: uuid.UUID,
user_id: uuid.UUID | None = None,
is_system_admin: bool = False,
) -> dict[str, Any] | None:
"""Get a single saved view by ID."""
q = select(SavedView).where(
SavedView.id == view_id,
SavedView.tenant_id == tenant_id,
SavedView.deleted_at.is_(None),
)
result = await db.execute(q)
saved = result.scalar_one_or_none()
if saved is None:
return None
if user_id and not is_system_admin:
has_access = await check_single_entity_access(
db, "saved_view", saved.id, user_id, tenant_id, "read", is_system_admin
)
if not has_access:
raise PermissionError("No access")
return _view_to_dict(saved)
async def create_saved_view(
db: AsyncSession,
tenant_id: uuid.UUID,
user_id: uuid.UUID,
data: dict[str, Any],
) -> dict[str, Any]:
"""Create a new saved view."""
saved = SavedView(
tenant_id=tenant_id,
user_id=user_id,
name=data["name"],
entity_type=data["entity_type"],
view_config=data.get("view_config", {}),
owner_id=user_id,
)
db.add(saved)
await db.flush()
await db.refresh(saved)
return _view_to_dict(saved)
async def update_saved_view(
db: AsyncSession,
tenant_id: uuid.UUID,
user_id: uuid.UUID,
view_id: uuid.UUID,
data: dict[str, Any],
is_system_admin: bool = False,
) -> dict[str, Any] | None:
"""Update a saved view."""
q = select(SavedView).where(
SavedView.id == view_id,
SavedView.tenant_id == tenant_id,
SavedView.deleted_at.is_(None),
)
result = await db.execute(q)
saved = result.scalar_one_or_none()
if saved is None:
return None
if not is_system_admin:
has_access = await check_single_entity_access(
db, "saved_view", saved.id, user_id, tenant_id, "write", is_system_admin
)
if not has_access:
raise PermissionError("No access")
if "name" in data and data["name"] is not None:
saved.name = data["name"]
if "view_config" in data and data["view_config"] is not None:
saved.view_config = data["view_config"]
await db.flush()
await db.refresh(saved)
return _view_to_dict(saved)
async def delete_saved_view(
db: AsyncSession,
tenant_id: uuid.UUID,
user_id: uuid.UUID,
view_id: uuid.UUID,
is_system_admin: bool = False,
) -> bool:
"""Soft-delete a saved view."""
q = select(SavedView).where(
SavedView.id == view_id,
SavedView.tenant_id == tenant_id,
SavedView.deleted_at.is_(None),
)
result = await db.execute(q)
saved = result.scalar_one_or_none()
if saved is None:
return False
if not is_system_admin:
has_access = await check_single_entity_access(
db, "saved_view", saved.id, user_id, tenant_id, "admin", is_system_admin
)
if not has_access:
raise PermissionError("No access")
saved.deleted_at = datetime.now(UTC)
await db.flush()
return True
+24
View File
@@ -11,6 +11,7 @@ from sqlalchemy.ext.asyncio import AsyncSession
from app.core.audit import log_audit from app.core.audit import log_audit
from app.models.sequence import Sequence from app.models.sequence import Sequence
from app.core.visibility import apply_visibility_filter, check_single_entity_access
def _sequence_to_dict(s: Sequence) -> dict[str, Any]: def _sequence_to_dict(s: Sequence) -> dict[str, Any]:
@@ -73,6 +74,7 @@ async def create_sequence(
prefix=data.get("prefix", ""), prefix=data.get("prefix", ""),
next_number=1, next_number=1,
padding=data.get("padding", 4), padding=data.get("padding", 4),
owner_id=user_id,
) )
db.add(sequence) db.add(sequence)
await db.flush() await db.flush()
@@ -87,12 +89,18 @@ async def create_sequence(
async def list_sequences( async def list_sequences(
db: AsyncSession, db: AsyncSession,
tenant_id: uuid.UUID, tenant_id: uuid.UUID,
user_id: uuid.UUID | None = None,
is_system_admin: bool = False,
) -> dict[str, Any]: ) -> dict[str, Any]:
"""List all sequences for a tenant.""" """List all sequences for a tenant."""
q = select(Sequence).where( q = select(Sequence).where(
Sequence.tenant_id == tenant_id, Sequence.tenant_id == tenant_id,
Sequence.deleted_at.is_(None), Sequence.deleted_at.is_(None),
).order_by(Sequence.name.asc()) ).order_by(Sequence.name.asc())
if user_id and not is_system_admin:
q = await apply_visibility_filter(
db, q, "sequence", Sequence, user_id, tenant_id, is_system_admin
)
result = await db.execute(q) result = await db.execute(q)
sequences = result.scalars().all() sequences = result.scalars().all()
return { return {
@@ -107,6 +115,7 @@ async def update_sequence(
user_id: uuid.UUID, user_id: uuid.UUID,
sequence_id: uuid.UUID, sequence_id: uuid.UUID,
data: dict[str, Any], data: dict[str, Any],
is_system_admin: bool = False,
) -> dict[str, Any] | None: ) -> dict[str, Any] | None:
"""Update a sequence (name, prefix, padding only — NOT next_number).""" """Update a sequence (name, prefix, padding only — NOT next_number)."""
q = select(Sequence).where( q = select(Sequence).where(
@@ -119,6 +128,13 @@ async def update_sequence(
if sequence is None: if sequence is None:
return None return None
if not is_system_admin:
has_access = await check_single_entity_access(
db, "sequence", sequence.id, user_id, tenant_id, "write", is_system_admin
)
if not has_access:
raise PermissionError("No access")
changes: dict[str, Any] = {} changes: dict[str, Any] = {}
for field in ("name", "prefix", "padding"): for field in ("name", "prefix", "padding"):
if field in data and data[field] is not None: if field in data and data[field] is not None:
@@ -137,6 +153,7 @@ async def delete_sequence(
tenant_id: uuid.UUID, tenant_id: uuid.UUID,
user_id: uuid.UUID, user_id: uuid.UUID,
sequence_id: uuid.UUID, sequence_id: uuid.UUID,
is_system_admin: bool = False,
) -> bool: ) -> bool:
"""Soft-delete a sequence.""" """Soft-delete a sequence."""
q = select(Sequence).where( q = select(Sequence).where(
@@ -149,6 +166,13 @@ async def delete_sequence(
if sequence is None: if sequence is None:
return False return False
if not is_system_admin:
has_access = await check_single_entity_access(
db, "sequence", sequence.id, user_id, tenant_id, "admin", is_system_admin
)
if not has_access:
raise PermissionError("No access")
sequence.deleted_at = datetime.now(UTC) sequence.deleted_at = datetime.now(UTC)
await db.flush() await db.flush()
await log_audit( await log_audit(
+38 -1
View File
@@ -17,6 +17,7 @@ from sqlalchemy import select, delete
from sqlalchemy.ext.asyncio import AsyncSession from sqlalchemy.ext.asyncio import AsyncSession
from app.models.webhook import Webhook from app.models.webhook import Webhook
from app.core.visibility import apply_visibility_filter, check_single_entity_access
logger = logging.getLogger(__name__) logger = logging.getLogger(__name__)
@@ -64,6 +65,8 @@ async def list_webhooks(
db: AsyncSession, db: AsyncSession,
tenant_id: uuid.UUID, tenant_id: uuid.UUID,
event: str | None = None, event: str | None = None,
user_id: uuid.UUID | None = None,
is_system_admin: bool = False,
) -> list[Webhook]: ) -> list[Webhook]:
"""List webhooks for a tenant, optionally filtered by event.""" """List webhooks for a tenant, optionally filtered by event."""
stmt = select(Webhook).where( stmt = select(Webhook).where(
@@ -71,6 +74,10 @@ async def list_webhooks(
) )
if event: if event:
stmt = stmt.where(Webhook.events.any(event)) stmt = stmt.where(Webhook.events.any(event))
if user_id and not is_system_admin:
stmt = await apply_visibility_filter(
db, stmt, "webhook", Webhook, user_id, tenant_id, is_system_admin
)
stmt = stmt.order_by(Webhook.created_at.desc()) stmt = stmt.order_by(Webhook.created_at.desc())
result = await db.execute(stmt) result = await db.execute(stmt)
return list(result.scalars().all()) return list(result.scalars().all())
@@ -80,6 +87,8 @@ async def get_webhook(
db: AsyncSession, db: AsyncSession,
tenant_id: uuid.UUID, tenant_id: uuid.UUID,
webhook_id: uuid.UUID, webhook_id: uuid.UUID,
user_id: uuid.UUID | None = None,
is_system_admin: bool = False,
) -> Webhook | None: ) -> Webhook | None:
"""Get a single webhook by ID.""" """Get a single webhook by ID."""
stmt = select(Webhook).where( stmt = select(Webhook).where(
@@ -87,7 +96,16 @@ async def get_webhook(
Webhook.tenant_id == tenant_id, Webhook.tenant_id == tenant_id,
) )
result = await db.execute(stmt) result = await db.execute(stmt)
return result.scalar_one_or_none() webhook = result.scalar_one_or_none()
if webhook is None:
return None
if user_id and not is_system_admin:
has_access = await check_single_entity_access(
db, "webhook", webhook.id, user_id, tenant_id, "read", is_system_admin
)
if not has_access:
raise PermissionError("No access")
return webhook
async def create_webhook( async def create_webhook(
@@ -107,6 +125,7 @@ async def create_webhook(
timeout_seconds=data.get("timeout_seconds", 30), timeout_seconds=data.get("timeout_seconds", 30),
created_by=user_id, created_by=user_id,
updated_by=user_id, updated_by=user_id,
owner_id=user_id,
) )
db.add(webhook) db.add(webhook)
await db.flush() await db.flush()
@@ -120,12 +139,20 @@ async def update_webhook(
webhook_id: uuid.UUID, webhook_id: uuid.UUID,
data: dict[str, Any], data: dict[str, Any],
user_id: uuid.UUID | None = None, user_id: uuid.UUID | None = None,
is_system_admin: bool = False,
) -> Webhook | None: ) -> Webhook | None:
"""Update an existing webhook subscription.""" """Update an existing webhook subscription."""
webhook = await get_webhook(db, tenant_id, webhook_id) webhook = await get_webhook(db, tenant_id, webhook_id)
if webhook is None: if webhook is None:
return None return None
if not is_system_admin:
has_access = await check_single_entity_access(
db, "webhook", webhook.id, user_id, tenant_id, "write", is_system_admin
)
if not has_access:
raise PermissionError("No access")
update_fields = ["url", "events", "secret", "is_active", "retry_count", "timeout_seconds"] update_fields = ["url", "events", "secret", "is_active", "retry_count", "timeout_seconds"]
for field in update_fields: for field in update_fields:
if field in data: if field in data:
@@ -143,6 +170,8 @@ async def delete_webhook(
db: AsyncSession, db: AsyncSession,
tenant_id: uuid.UUID, tenant_id: uuid.UUID,
webhook_id: uuid.UUID, webhook_id: uuid.UUID,
user_id: uuid.UUID | None = None,
is_system_admin: bool = False,
) -> bool: ) -> bool:
"""Delete a webhook subscription.""" """Delete a webhook subscription."""
stmt = select(Webhook).where( stmt = select(Webhook).where(
@@ -153,6 +182,14 @@ async def delete_webhook(
webhook = result.scalar_one_or_none() webhook = result.scalar_one_or_none()
if webhook is None: if webhook is None:
return False return False
if not is_system_admin:
has_access = await check_single_entity_access(
db, "webhook", webhook.id, user_id, tenant_id, "admin", is_system_admin
)
if not has_access:
raise PermissionError("No access")
await db.delete(webhook) await db.delete(webhook)
await db.flush() await db.flush()
return True return True
+33
View File
@@ -12,6 +12,7 @@ from sqlalchemy.ext.asyncio import AsyncSession
from app.core.audit import log_audit from app.core.audit import log_audit
from app.models.notification import Notification from app.models.notification import Notification
from app.models.workflow import Workflow, WorkflowInstance, WorkflowStepHistory from app.models.workflow import Workflow, WorkflowInstance, WorkflowStepHistory
from app.core.visibility import apply_visibility_filter, check_single_entity_access
def _safe_iso(dt) -> str | None: def _safe_iso(dt) -> str | None:
@@ -135,6 +136,7 @@ async def create_workflow(
steps=steps_json, steps=steps_json,
is_active=data.get("is_active", True), is_active=data.get("is_active", True),
created_by=user_id, created_by=user_id,
owner_id=user_id,
) )
db.add(workflow) db.add(workflow)
await db.flush() await db.flush()
@@ -158,6 +160,8 @@ async def list_workflows(
page: int = 1, page: int = 1,
page_size: int = 20, page_size: int = 20,
is_active: bool | None = None, is_active: bool | None = None,
user_id: uuid.UUID | None = None,
is_system_admin: bool = False,
) -> dict[str, Any]: ) -> dict[str, Any]:
"""List workflows with pagination.""" """List workflows with pagination."""
page = max(1, page) page = max(1, page)
@@ -167,6 +171,11 @@ async def list_workflows(
if is_active is not None: if is_active is not None:
base = base.where(Workflow.is_active == is_active) base = base.where(Workflow.is_active == is_active)
if user_id and not is_system_admin:
base = await apply_visibility_filter(
db, base, "workflow", Workflow, user_id, tenant_id, is_system_admin
)
count_q = select(func.count()).select_from(base.subquery()) count_q = select(func.count()).select_from(base.subquery())
total_result = await db.execute(count_q) total_result = await db.execute(count_q)
total = total_result.scalar_one() total = total_result.scalar_one()
@@ -188,6 +197,8 @@ async def get_workflow(
db: AsyncSession, db: AsyncSession,
tenant_id: uuid.UUID, tenant_id: uuid.UUID,
workflow_id: str, workflow_id: str,
user_id: uuid.UUID | None = None,
is_system_admin: bool = False,
) -> dict[str, Any] | None: ) -> dict[str, Any] | None:
"""Get a single workflow by ID.""" """Get a single workflow by ID."""
wf_uuid = uuid.UUID(workflow_id) wf_uuid = uuid.UUID(workflow_id)
@@ -200,6 +211,12 @@ async def get_workflow(
workflow = result.scalar_one_or_none() workflow = result.scalar_one_or_none()
if workflow is None: if workflow is None:
return None return None
if user_id and not is_system_admin:
has_access = await check_single_entity_access(
db, "workflow", workflow.id, user_id, tenant_id, "read", is_system_admin
)
if not has_access:
raise PermissionError("No access")
return _workflow_to_dict(workflow) return _workflow_to_dict(workflow)
@@ -209,6 +226,7 @@ async def update_workflow(
user_id: uuid.UUID, user_id: uuid.UUID,
workflow_id: str, workflow_id: str,
data: dict[str, Any], data: dict[str, Any],
is_system_admin: bool = False,
) -> dict[str, Any] | None: ) -> dict[str, Any] | None:
"""Update a workflow definition.""" """Update a workflow definition."""
wf_uuid = uuid.UUID(workflow_id) wf_uuid = uuid.UUID(workflow_id)
@@ -222,6 +240,13 @@ async def update_workflow(
if workflow is None: if workflow is None:
return None return None
if not is_system_admin:
has_access = await check_single_entity_access(
db, "workflow", workflow.id, user_id, tenant_id, "write", is_system_admin
)
if not has_access:
raise PermissionError("No access")
if "name" in data: if "name" in data:
workflow.name = data["name"] workflow.name = data["name"]
if "description" in data: if "description" in data:
@@ -254,6 +279,7 @@ async def delete_workflow(
tenant_id: uuid.UUID, tenant_id: uuid.UUID,
user_id: uuid.UUID, user_id: uuid.UUID,
workflow_id: str, workflow_id: str,
is_system_admin: bool = False,
) -> bool: ) -> bool:
"""Delete a workflow definition.""" """Delete a workflow definition."""
wf_uuid = uuid.UUID(workflow_id) wf_uuid = uuid.UUID(workflow_id)
@@ -267,6 +293,13 @@ async def delete_workflow(
if workflow is None: if workflow is None:
return False return False
if not is_system_admin:
has_access = await check_single_entity_access(
db, "workflow", workflow.id, user_id, tenant_id, "admin", is_system_admin
)
if not has_access:
raise PermissionError("No access")
await db.delete(workflow) await db.delete(workflow)
await db.flush() await db.flush()