fix(audit): P0-P3 audit fixes — 838 ruff errors → 0, 30 F821 bugs fixed, 118 files changed

- P0: hooks.py 3-tuple fix, trigger_dispatcher Contract, contacts/plugin unregister_actions_by_owner
- P0: 5 test files — check_permission mocks removed, hardcoded DB credential → env var
- P1: attachment_service DmsFile via Contract helper, restore_registry/history_hooks dedup
- P1: mail/plugin restore unregister, mcp_client datetime.now(UTC), saved_views/filters patterns
- P1: ProtectedRoute fail-closed, 13 test assertion fixes (bcrypt, DB-URLs, SECRET_KEYs)
- P2: deprecated notifications → post_system_message (3 files), forgejo Base, report_generator lazy import
- P2: webhooks permissions, deps.py/roles.py plugin perms removed, import_export default
- P2: address/tags/entity_links patterns removed, worker.py Contract-Umgehungen fixed
- P2: 28 frontend TODOs (hardcoded constants, deprecated notification API)
- P3: dead code, duplicates, deprecated imports, private attr, __import__ inline
- P3: 8 frontend TODOs (LucideIcons, inline styles, XSS, i18n)
- ruff: 838 → 0 (612 auto-fix + 246 manual + 27 F821 regression fix)
- F821: 30 → 0 (AutomationDefinition, DmsFile, user_id, Path, Any, String)
- Contract-Umgehungen: 2 neue gefunden (worker.py:169, worker.py:280) und gefixt
This commit is contained in:
Agent Zero
2026-08-16 01:17:18 +02:00
parent 3d9b76cea4
commit abbe7a18fc
306 changed files with 5912 additions and 1827 deletions
+4 -4
View File
@@ -27,7 +27,7 @@ from __future__ import annotations
import logging
import uuid
from datetime import datetime, timedelta, timezone
from datetime import UTC, datetime, timedelta
from typing import Any
import redis.asyncio as aioredis
@@ -318,7 +318,7 @@ async def _process_single_outbox_event(
already_succeeded = {row[0] for row in succeeded_q}
# Filter out handlers that already succeeded (per-handler idempotency)
pending_handlers = [(h, name) for h, name in zip(handlers, handler_names) if name not in already_succeeded]
pending_handlers = [(h, name) for h, name in zip(handlers, handler_names, strict=False) if name not in already_succeeded]
pending_names = [name for _, name in pending_handlers]
pending_callables = [h for h, _ in pending_handlers]
@@ -345,7 +345,7 @@ async def _process_single_outbox_event(
"status": "delivered",
"attempt_count": current_attempt,
"last_error": None,
"processed_at": datetime.now(timezone.utc),
"processed_at": datetime.now(UTC),
},
)
# Per-handler consumer_inbox for idempotency
@@ -408,7 +408,7 @@ async def _process_single_outbox_event(
)
else:
backoff = timedelta(seconds=(2 ** new_attempts) * 10)
next_retry = datetime.now(timezone.utc) + backoff
next_retry = datetime.now(UTC) + backoff
await db.execute(
_RETRY_SQL,
{