fix(audit): P0-P3 audit fixes — 838 ruff errors → 0, 30 F821 bugs fixed, 118 files changed
- P0: hooks.py 3-tuple fix, trigger_dispatcher Contract, contacts/plugin unregister_actions_by_owner - P0: 5 test files — check_permission mocks removed, hardcoded DB credential → env var - P1: attachment_service DmsFile via Contract helper, restore_registry/history_hooks dedup - P1: mail/plugin restore unregister, mcp_client datetime.now(UTC), saved_views/filters patterns - P1: ProtectedRoute fail-closed, 13 test assertion fixes (bcrypt, DB-URLs, SECRET_KEYs) - P2: deprecated notifications → post_system_message (3 files), forgejo Base, report_generator lazy import - P2: webhooks permissions, deps.py/roles.py plugin perms removed, import_export default - P2: address/tags/entity_links patterns removed, worker.py Contract-Umgehungen fixed - P2: 28 frontend TODOs (hardcoded constants, deprecated notification API) - P3: dead code, duplicates, deprecated imports, private attr, __import__ inline - P3: 8 frontend TODOs (LucideIcons, inline styles, XSS, i18n) - ruff: 838 → 0 (612 auto-fix + 246 manual + 27 F821 regression fix) - F821: 30 → 0 (AutomationDefinition, DmsFile, user_id, Path, Any, String) - Contract-Umgehungen: 2 neue gefunden (worker.py:169, worker.py:280) und gefixt
This commit is contained in:
@@ -113,7 +113,12 @@ class TriggerDispatcher:
|
||||
) -> None:
|
||||
"""Query DB for active automations matching *event_name* and dispatch."""
|
||||
from app.core.db import get_session_factory
|
||||
from app.plugins.builtins.automation.models import AutomationDefinition
|
||||
from app.plugins.builtins.contracts import get_contract
|
||||
automation_contract = get_contract("automation")
|
||||
AutomationDefinition = automation_contract.Automation # noqa: N806
|
||||
if automation_contract is None:
|
||||
logger.debug("Automation plugin not available — trigger skipped")
|
||||
return
|
||||
|
||||
factory = get_session_factory()
|
||||
tenant_id = payload.get("tenant_id")
|
||||
@@ -171,15 +176,16 @@ class TriggerDispatcher:
|
||||
For production workloads with back-pressure, the caller may
|
||||
alternatively enqueue via ``enqueue_job``.
|
||||
"""
|
||||
from app.plugins.builtins.automation.execution_engine import run_automation
|
||||
|
||||
try:
|
||||
await run_automation(
|
||||
ctx={},
|
||||
automation_id=automation_id,
|
||||
trigger_type=trigger_type,
|
||||
trigger_data=trigger_data,
|
||||
)
|
||||
from app.plugins.builtins.contracts import get_contract
|
||||
automation_contract = get_contract("automation")
|
||||
if automation_contract is not None:
|
||||
await automation_contract.run_automation(
|
||||
ctx={},
|
||||
automation_id=automation_id,
|
||||
trigger_type=trigger_type,
|
||||
trigger_data=trigger_data,
|
||||
)
|
||||
except Exception:
|
||||
logger.exception(
|
||||
"TriggerDispatcher: run_automation failed for automation_id=%s",
|
||||
|
||||
Reference in New Issue
Block a user