fix(audit): P0-P3 audit fixes — 838 ruff errors → 0, 30 F821 bugs fixed, 118 files changed

- P0: hooks.py 3-tuple fix, trigger_dispatcher Contract, contacts/plugin unregister_actions_by_owner
- P0: 5 test files — check_permission mocks removed, hardcoded DB credential → env var
- P1: attachment_service DmsFile via Contract helper, restore_registry/history_hooks dedup
- P1: mail/plugin restore unregister, mcp_client datetime.now(UTC), saved_views/filters patterns
- P1: ProtectedRoute fail-closed, 13 test assertion fixes (bcrypt, DB-URLs, SECRET_KEYs)
- P2: deprecated notifications → post_system_message (3 files), forgejo Base, report_generator lazy import
- P2: webhooks permissions, deps.py/roles.py plugin perms removed, import_export default
- P2: address/tags/entity_links patterns removed, worker.py Contract-Umgehungen fixed
- P2: 28 frontend TODOs (hardcoded constants, deprecated notification API)
- P3: dead code, duplicates, deprecated imports, private attr, __import__ inline
- P3: 8 frontend TODOs (LucideIcons, inline styles, XSS, i18n)
- ruff: 838 → 0 (612 auto-fix + 246 manual + 27 F821 regression fix)
- F821: 30 → 0 (AutomationDefinition, DmsFile, user_id, Path, Any, String)
- Contract-Umgehungen: 2 neue gefunden (worker.py:169, worker.py:280) und gefixt

app/plugins/builtins/ai_assistant/external_api.py

@@ -11,7 +11,7 @@ import logging
 import uuid
 from typing import Any
 
-from fastapi import APIRouter, Depends, HTTPException, Query, Request
+from fastapi import APIRouter, Depends, HTTPException, Request
 from fastapi.responses import StreamingResponse
 from sqlalchemy import select
 from sqlalchemy.ext.asyncio import AsyncSession
@@ -61,7 +61,7 @@ async def run_agent_external(
     try:
         aid = uuid.UUID(agent_id)
     except (ValueError, TypeError):
-        raise HTTPException(status_code=400, detail="Invalid agent ID")
+        raise HTTPException(status_code=400, detail="Invalid agent ID") from None
 
     # Find the agent
     from app.plugins.builtins.ai_assistant.models import AIAgent
@@ -79,8 +79,8 @@ async def run_agent_external(
         raise HTTPException(status_code=400, detail="Agent is not active")
 
     # Create or find a session for this external interaction
-    from app.plugins.builtins.ai_assistant.models import AIChatSession, AIChatMessage
-    from datetime import datetime, timezone
+
+    from app.plugins.builtins.ai_assistant.models import AIChatMessage, AIChatSession
 
     session = AIChatSession(
         user_id=uuid.UUID(current_user["user_id"]),
@@ -168,7 +168,7 @@ async def get_agent_status_external(
     try:
         aid = uuid.UUID(agent_id)
     except (ValueError, TypeError):
-        raise HTTPException(status_code=400, detail="Invalid agent ID")
+        raise HTTPException(status_code=400, detail="Invalid agent ID") from None
 
     from app.plugins.builtins.ai_assistant.models import AIAgent
 
@@ -183,9 +183,10 @@ async def get_agent_status_external(
         raise HTTPException(status_code=404, detail="Agent not found")
 
     # Get recent run stats
-    from app.plugins.builtins.automation.contracts import AutomationContract
     from sqlalchemy import func
 
+    from app.plugins.builtins.automation.contracts import AutomationContract
+
     recent_runs = await db.execute(
         select(func.count())
         .select_from(AutomationContract.AgentRun)
@@ -232,7 +233,7 @@ async def stream_agent_external(
     try:
         aid = uuid.UUID(agent_id)
     except (ValueError, TypeError):
-        raise HTTPException(status_code=400, detail="Invalid agent ID")
+        raise HTTPException(status_code=400, detail="Invalid agent ID") from None
 
     from app.plugins.builtins.ai_assistant.models import AIAgent