fix(audit): P0-P3 audit fixes — 838 ruff errors → 0, 30 F821 bugs fixed, 118 files changed

- P0: hooks.py 3-tuple fix, trigger_dispatcher Contract, contacts/plugin unregister_actions_by_owner
- P0: 5 test files — check_permission mocks removed, hardcoded DB credential → env var
- P1: attachment_service DmsFile via Contract helper, restore_registry/history_hooks dedup
- P1: mail/plugin restore unregister, mcp_client datetime.now(UTC), saved_views/filters patterns
- P1: ProtectedRoute fail-closed, 13 test assertion fixes (bcrypt, DB-URLs, SECRET_KEYs)
- P2: deprecated notifications → post_system_message (3 files), forgejo Base, report_generator lazy import
- P2: webhooks permissions, deps.py/roles.py plugin perms removed, import_export default
- P2: address/tags/entity_links patterns removed, worker.py Contract-Umgehungen fixed
- P2: 28 frontend TODOs (hardcoded constants, deprecated notification API)
- P3: dead code, duplicates, deprecated imports, private attr, __import__ inline
- P3: 8 frontend TODOs (LucideIcons, inline styles, XSS, i18n)
- ruff: 838 → 0 (612 auto-fix + 246 manual + 27 F821 regression fix)
- F821: 30 → 0 (AutomationDefinition, DmsFile, user_id, Path, Any, String)
- Contract-Umgehungen: 2 neue gefunden (worker.py:169, worker.py:280) und gefixt

app/plugins/builtins/ai_assistant/services.py

@@ -10,16 +10,15 @@ from __future__ import annotations
 import json
 import logging
 import uuid
-from typing import Any, AsyncGenerator
+from collections.abc import AsyncGenerator
+from typing import Any
 
 import aiofiles
-
 import litellm
 from sqlalchemy import select
 from sqlalchemy.ext.asyncio import AsyncSession
 
 from app.ai.llm_client import llm_complete
-
 from app.core.permissions import check_permission
 from app.plugins.builtins.ai_assistant.models import (
     AIAgent,
@@ -169,7 +168,7 @@ async def get_default_provider(db: AsyncSession, tenant_id: uuid.UUID) -> AIProv
     result = await db.execute(
         select(AIProvider)
         .where(AIProvider.tenant_id == tenant_id)
-        .where(AIProvider.is_default == True)
+        .where(AIProvider.is_default.is_(True))
         .limit(1)
     )
     return result.scalar_one_or_none()
@@ -209,7 +208,7 @@ async def get_default_agent(db: AsyncSession, tenant_id: uuid.UUID) -> AIAgent |
     result = await db.execute(
         select(AIAgent)
         .where(AIAgent.tenant_id == tenant_id)
-        .where(AIAgent.is_default == True)
+        .where(AIAgent.is_default.is_(True))
         .limit(1)
     )
     return result.scalar_one_or_none()
@@ -394,8 +393,9 @@ async def _extract_attachment_content(
                 text_content = content.decode("utf-8", errors="replace")
             elif mime == "application/pdf" or att.filename.endswith(".pdf"):
                 try:
-                    from pypdf import PdfReader
                     from io import BytesIO
+
+                    from pypdf import PdfReader
                     reader = PdfReader(BytesIO(content))
                     text_content = "\n".join(page.extract_text() or "" for page in reader.pages)
                 except ImportError: