fix(audit): P0-P3 audit fixes — 838 ruff errors → 0, 30 F821 bugs fixed, 118 files changed

- P0: hooks.py 3-tuple fix, trigger_dispatcher Contract, contacts/plugin unregister_actions_by_owner
- P0: 5 test files — check_permission mocks removed, hardcoded DB credential → env var
- P1: attachment_service DmsFile via Contract helper, restore_registry/history_hooks dedup
- P1: mail/plugin restore unregister, mcp_client datetime.now(UTC), saved_views/filters patterns
- P1: ProtectedRoute fail-closed, 13 test assertion fixes (bcrypt, DB-URLs, SECRET_KEYs)
- P2: deprecated notifications → post_system_message (3 files), forgejo Base, report_generator lazy import
- P2: webhooks permissions, deps.py/roles.py plugin perms removed, import_export default
- P2: address/tags/entity_links patterns removed, worker.py Contract-Umgehungen fixed
- P2: 28 frontend TODOs (hardcoded constants, deprecated notification API)
- P3: dead code, duplicates, deprecated imports, private attr, __import__ inline
- P3: 8 frontend TODOs (LucideIcons, inline styles, XSS, i18n)
- ruff: 838 → 0 (612 auto-fix + 246 manual + 27 F821 regression fix)
- F821: 30 → 0 (AutomationDefinition, DmsFile, user_id, Path, Any, String)
- Contract-Umgehungen: 2 neue gefunden (worker.py:169, worker.py:280) und gefixt

app/plugins/builtins/ai_proactive/services.py

@@ -6,30 +6,28 @@ suggestions, pushes via SSE, and manages suggestion lifecycle.
 
 from __future__ import annotations
 
-import os
 import asyncio
 import json
 import logging
+import os
 import uuid
-from datetime import UTC, datetime, timedelta
+from datetime import UTC, datetime
 from typing import Any
 
 import litellm
-from app.ai.llm_client import llm_complete
 from sqlalchemy import func, select, text
 from sqlalchemy.ext.asyncio import AsyncSession
 
-from app.core.cache import get_cache
-from app.core.db import create_db_session, get_session_factory
+from app.ai.llm_client import llm_complete
+from app.core.db import create_db_session
 from app.core.notifications import create_notification
 from app.models.audit import AuditLog
 from app.models.contact import Contact, ContactPerson
-from app.models.contact import Contact, ContactPerson
 from app.plugins.builtins.ai_proactive.models import (
-    ContextLog,
     ProactiveSettings,
     ProactiveSuggestion,
 )
+
 logger = logging.getLogger(__name__)
 
 litellm.suppress_debug_info = True
@@ -81,9 +79,10 @@ async def is_rate_limited(
     and ``window_seconds=rate_limit_seconds``.
     Returns ``True`` if rate-limited, ``False`` if allowed.
     """
-    from app.core.rate_limit import check_rate_limit
     from fastapi import HTTPException
 
+    from app.core.rate_limit import check_rate_limit
+
     redis_key = f"rate:ai_proactive:{tenant_id}:{user_id}"
     try:
         await check_rate_limit(redis_key, max_attempts=1, window_seconds=rate_limit_seconds)
@@ -208,18 +207,18 @@ async def gather_context(
         # Upcoming calendar events
         from app.plugins.builtins.calendar.contracts import get_contract as get_calendar_contract
         _cal = get_calendar_contract()
-        CalendarEntry = _cal.CalendarEntry
-        CalendarEntryLink = _cal.CalendarEntryLink
+        calendar_entry = _cal.calendar_entry
+        calendar_entry_link = _cal.calendar_entry_link
 
         now = datetime.now(UTC)
         event_result = await db.execute(
-            select(CalendarEntry)
-            .join(CalendarEntryLink, CalendarEntryLink.entry_id == CalendarEntry.id)
-            .where(CalendarEntryLink.entity_type == "contact")
-            .where(CalendarEntryLink.entity_id == entity_id)
-            .where(CalendarEntry.tenant_id == tenant_id)
-            .where(CalendarEntry.start_at > now)
-            .order_by(CalendarEntry.start_at.asc())
+            select(calendar_entry)
+            .join(calendar_entry_link, calendar_entry_link.entry_id == calendar_entry.id)
+            .where(calendar_entry_link.entity_type == "contact")
+            .where(calendar_entry_link.entity_id == entity_id)
+            .where(calendar_entry.tenant_id == tenant_id)
+            .where(calendar_entry.start_at > now)
+            .order_by(calendar_entry.start_at.asc())
             .limit(5)
         )
         context["events"] = [_serialize_row(e) for e in event_result.scalars().all()]
@@ -323,18 +322,18 @@ async def gather_context(
         # Upcoming events
         from app.plugins.builtins.calendar.contracts import get_contract as get_calendar_contract
         _cal = get_calendar_contract()
-        CalendarEntry = _cal.CalendarEntry
-        CalendarEntryLink = _cal.CalendarEntryLink
+        calendar_entry = _cal.calendar_entry
+        calendar_entry_link = _cal.calendar_entry_link
 
         now = datetime.now(UTC)
         event_result = await db.execute(
-            select(CalendarEntry)
-            .join(CalendarEntryLink, CalendarEntryLink.entry_id == CalendarEntry.id)
-            .where(CalendarEntryLink.entity_type == "contact")
-            .where(CalendarEntryLink.entity_id == entity_id)
-            .where(CalendarEntry.tenant_id == tenant_id)
-            .where(CalendarEntry.start_at > now)
-            .order_by(CalendarEntry.start_at.asc())
+            select(calendar_entry)
+            .join(calendar_entry_link, calendar_entry_link.entry_id == calendar_entry.id)
+            .where(calendar_entry_link.entity_type == "contact")
+            .where(calendar_entry_link.entity_id == entity_id)
+            .where(calendar_entry.tenant_id == tenant_id)
+            .where(calendar_entry.start_at > now)
+            .order_by(calendar_entry.start_at.asc())
             .limit(5)
         )
         context["events"] = [_serialize_row(e) for e in event_result.scalars().all()]
@@ -365,7 +364,9 @@ async def gather_context(
 
     # Semantically similar entities via unified_search
     try:
-        from app.plugins.builtins.unified_search.contracts import get_contract as get_search_contract
+        from app.plugins.builtins.unified_search.contracts import (
+            get_contract as get_search_contract,
+        )
         _search = get_search_contract()
         find_similar_all_types = _search.hybrid_search