fix(audit): P0-P3 audit fixes — 838 ruff errors → 0, 30 F821 bugs fixed, 118 files changed
- P0: hooks.py 3-tuple fix, trigger_dispatcher Contract, contacts/plugin unregister_actions_by_owner - P0: 5 test files — check_permission mocks removed, hardcoded DB credential → env var - P1: attachment_service DmsFile via Contract helper, restore_registry/history_hooks dedup - P1: mail/plugin restore unregister, mcp_client datetime.now(UTC), saved_views/filters patterns - P1: ProtectedRoute fail-closed, 13 test assertion fixes (bcrypt, DB-URLs, SECRET_KEYs) - P2: deprecated notifications → post_system_message (3 files), forgejo Base, report_generator lazy import - P2: webhooks permissions, deps.py/roles.py plugin perms removed, import_export default - P2: address/tags/entity_links patterns removed, worker.py Contract-Umgehungen fixed - P2: 28 frontend TODOs (hardcoded constants, deprecated notification API) - P3: dead code, duplicates, deprecated imports, private attr, __import__ inline - P3: 8 frontend TODOs (LucideIcons, inline styles, XSS, i18n) - ruff: 838 → 0 (612 auto-fix + 246 manual + 27 F821 regression fix) - F821: 30 → 0 (AutomationDefinition, DmsFile, user_id, Path, Any, String) - Contract-Umgehungen: 2 neue gefunden (worker.py:169, worker.py:280) und gefixt
This commit is contained in:
@@ -5,7 +5,9 @@ Exposes models, services, scheduler, and agent communication for other plugins.
|
||||
|
||||
from __future__ import annotations
|
||||
|
||||
from app.plugins.builtins.contracts import get_contract_registry
|
||||
from app.plugins.builtins.automation.agent_comm import send_agent_message
|
||||
from app.plugins.builtins.automation.agent_runner import run_agent
|
||||
from app.plugins.builtins.automation.execution_engine import run_automation
|
||||
from app.plugins.builtins.automation.models import (
|
||||
AgentDefinition,
|
||||
AgentRun,
|
||||
@@ -15,19 +17,17 @@ from app.plugins.builtins.automation.models import (
|
||||
AutomationRun,
|
||||
AutomationVersion,
|
||||
)
|
||||
from app.plugins.builtins.automation.scheduler import (
|
||||
calculate_next_run,
|
||||
scheduler_tick,
|
||||
)
|
||||
from app.plugins.builtins.automation.services import (
|
||||
AgentService,
|
||||
AutomationService,
|
||||
CronJobService,
|
||||
RunLogService,
|
||||
)
|
||||
from app.plugins.builtins.automation.agent_runner import run_agent
|
||||
from app.plugins.builtins.automation.execution_engine import run_automation
|
||||
from app.plugins.builtins.automation.scheduler import (
|
||||
calculate_next_run,
|
||||
scheduler_tick,
|
||||
)
|
||||
from app.plugins.builtins.automation.agent_comm import send_agent_message
|
||||
from app.plugins.builtins.contracts import get_contract_registry
|
||||
|
||||
|
||||
class AutomationContract:
|
||||
@@ -73,8 +73,6 @@ get_contract_registry().register("automation", _contract)
|
||||
__all__ = [
|
||||
"AutomationContract",
|
||||
"AgentDefinition",
|
||||
"Automation",
|
||||
"CronJob",
|
||||
"AgentService",
|
||||
"AutomationService",
|
||||
"CronJobService",
|
||||
|
||||
Reference in New Issue
Block a user