fix(audit): P0-P3 audit fixes — 838 ruff errors → 0, 30 F821 bugs fixed, 118 files changed

- P0: hooks.py 3-tuple fix, trigger_dispatcher Contract, contacts/plugin unregister_actions_by_owner
- P0: 5 test files — check_permission mocks removed, hardcoded DB credential → env var
- P1: attachment_service DmsFile via Contract helper, restore_registry/history_hooks dedup
- P1: mail/plugin restore unregister, mcp_client datetime.now(UTC), saved_views/filters patterns
- P1: ProtectedRoute fail-closed, 13 test assertion fixes (bcrypt, DB-URLs, SECRET_KEYs)
- P2: deprecated notifications → post_system_message (3 files), forgejo Base, report_generator lazy import
- P2: webhooks permissions, deps.py/roles.py plugin perms removed, import_export default
- P2: address/tags/entity_links patterns removed, worker.py Contract-Umgehungen fixed
- P2: 28 frontend TODOs (hardcoded constants, deprecated notification API)
- P3: dead code, duplicates, deprecated imports, private attr, __import__ inline
- P3: 8 frontend TODOs (LucideIcons, inline styles, XSS, i18n)
- ruff: 838 → 0 (612 auto-fix + 246 manual + 27 F821 regression fix)
- F821: 30 → 0 (AutomationDefinition, DmsFile, user_id, Path, Any, String)
- Contract-Umgehungen: 2 neue gefunden (worker.py:169, worker.py:280) und gefixt

app/plugins/builtins/automation/tests/test_automation.py

@@ -7,33 +7,24 @@ since PostgreSQL may not be available in the dev container.
 from __future__ import annotations
 
 import uuid
+from collections.abc import AsyncGenerator
 from datetime import UTC, datetime, timedelta
-from typing import Any, AsyncGenerator
 
 import pytest
 import pytest_asyncio
-from sqlalchemy import create_engine, event
 from sqlalchemy.ext.asyncio import AsyncSession, async_sessionmaker, create_async_engine
-from sqlalchemy.orm import sessionmaker
 
 from app.core.db import Base
 from app.plugins.builtins.automation.models import (
-    AgentDefinition,
     AgentRun,
-    AgentVersion,
-    AutomationCronJob,
-    AutomationDefinition,
     AutomationRun,
-    AutomationVersion,
 )
 from app.plugins.builtins.automation.services import (
     AgentService,
     AutomationService,
     CronJobService,
-    RunLogService,
 )
 
-
 # ─── Fixtures ───
 
 
@@ -536,12 +527,12 @@ class TestInfiniteLoopDetection:
         tool_call_count: dict[str, int] = {}
         tool_name = "send_email"
 
-        for i in range(5):
+        for _i in range(5):
             tool_call_count[tool_name] = tool_call_count.get(tool_name, 0) + 1
             if tool_call_count[tool_name] >= 5:
                 assert True
                 return
-        assert False, "Loop detection should have triggered"
+        raise AssertionError("Loop detection should have triggered")
 
     def test_different_tools_not_detected(self):
         """Test that different tool calls don't trigger loop detection."""
@@ -549,5 +540,5 @@ class TestInfiniteLoopDetection:
         for i in range(5):
             tool_call_count[f"tool_{i}"] = tool_call_count.get(f"tool_{i}", 0) + 1
             if tool_call_count[f"tool_{i}"] >= 5:
-                assert False, "Different tools should not trigger loop detection"
+                raise AssertionError("Different tools should not trigger loop detection")
         assert True