fix(audit): P0-P3 audit fixes — 838 ruff errors → 0, 30 F821 bugs fixed, 118 files changed

- P0: hooks.py 3-tuple fix, trigger_dispatcher Contract, contacts/plugin unregister_actions_by_owner
- P0: 5 test files — check_permission mocks removed, hardcoded DB credential → env var
- P1: attachment_service DmsFile via Contract helper, restore_registry/history_hooks dedup
- P1: mail/plugin restore unregister, mcp_client datetime.now(UTC), saved_views/filters patterns
- P1: ProtectedRoute fail-closed, 13 test assertion fixes (bcrypt, DB-URLs, SECRET_KEYs)
- P2: deprecated notifications → post_system_message (3 files), forgejo Base, report_generator lazy import
- P2: webhooks permissions, deps.py/roles.py plugin perms removed, import_export default
- P2: address/tags/entity_links patterns removed, worker.py Contract-Umgehungen fixed
- P2: 28 frontend TODOs (hardcoded constants, deprecated notification API)
- P3: dead code, duplicates, deprecated imports, private attr, __import__ inline
- P3: 8 frontend TODOs (LucideIcons, inline styles, XSS, i18n)
- ruff: 838 → 0 (612 auto-fix + 246 manual + 27 F821 regression fix)
- F821: 30 → 0 (AutomationDefinition, DmsFile, user_id, Path, Any, String)
- Contract-Umgehungen: 2 neue gefunden (worker.py:169, worker.py:280) und gefixt

app/plugins/builtins/mcp_server/contracts.py

@@ -6,19 +6,19 @@ Exposes tool definitions and schemas for other plugins.
 from __future__ import annotations
 
 from app.plugins.builtins.contracts import get_contract_registry
-from app.plugins.builtins.mcp_server.tool_definitions import (
-    TOOL_DEFINITIONS,
-    TOOL_HANDLERS,
-    get_all_tool_names,
-    get_tool_definition,
-)
 from app.plugins.builtins.mcp_server.schemas import (
+    McpServerConfig,
     McpToolDefinition,
     McpToolExecuteRequest,
     McpToolExecuteResponse,
     McpToolListResponse,
     McpToolParameter,
-    McpServerConfig,
+)
+from app.plugins.builtins.mcp_server.tool_definitions import (
+    TOOL_DEFINITIONS,
+    TOOL_HANDLERS,
+    get_all_tool_names,
+    get_tool_definition,
 )
 
 
@@ -50,7 +50,6 @@ get_contract_registry().register("mcp_server", _contract)
 
 __all__ = [
     "McpServerContract",
-    "ToolDefinitions",
     "McpToolDefinition",
     "McpToolParameter",
     "McpServerConfig",

app/plugins/builtins/mcp_server/plugin.py

@@ -28,7 +28,7 @@ class McpServerPlugin(BasePlugin):
             "mcp:read",
             "mcp:write",
         ],
-    
+
         author="LeoCRM Team",
         min_app_version="1.0.0",
         contract_version="1.0.0")

app/plugins/builtins/mcp_server/routes.py

@@ -6,14 +6,13 @@ import logging
 import uuid
 from typing import Any
 
-from fastapi import APIRouter, Depends, Header, HTTPException, status
+from fastapi import APIRouter, Depends, HTTPException, status
 from sqlalchemy.ext.asyncio import AsyncSession
 
 from app.core.db import get_db
-from app.deps import get_current_user, get_current_user_or_bearer, require_permission
+from app.deps import get_current_user, get_current_user_or_bearer
 from app.plugins.builtins.mcp_server.schemas import (
     McpServerConfig,
-    McpToolDefinition,
     McpToolExecuteRequest,
     McpToolExecuteResponse,
     McpToolListResponse,
@@ -101,8 +100,9 @@ async def execute_mcp_tool(
     }
 
     # Audit log
-    from app.core.audit import log_audit
     import uuid as uuid_mod
+
+    from app.core.audit import log_audit
     correlation_id = str(uuid_mod.uuid4())
     await log_audit(
         db,

app/plugins/builtins/mcp_server/tool_definitions.py

@@ -168,19 +168,21 @@ async def _handler_search(db: AsyncSession, arguments: dict[str, Any], context:
         return {"error": "invalid tenant/user context"}
 
     try:
-        from app.plugins.builtins.unified_search.query_understanding import llm_analyze_query
-        from app.plugins.builtins.unified_search.search_engine import hybrid_search
-
-        query_analysis = await llm_analyze_query(query, db=db, tenant_id=tenant_uuid)
-        results = await hybrid_search(
-            db=db,
-            query_analysis=query_analysis,
-            tenant_id=tenant_uuid,
-            entity_types=entity_types,
-            limit=limit,
-            user_id=user_uuid,
-            is_system_admin=is_system_admin,
-        )
+        from app.plugins.builtins.contracts import get_contract
+        search_contract = get_contract("unified_search")
+        if search_contract is not None:
+            query_analysis = await search_contract.llm_analyze_query(query, db=db, tenant_id=tenant_uuid)
+            results = await search_contract.hybrid_search(
+                db=db,
+                query_analysis=query_analysis,
+                tenant_id=tenant_uuid,
+                entity_types=entity_types,
+                limit=limit,
+                user_id=user_uuid,
+                is_system_admin=is_system_admin,
+            )
+        else:
+            return {"error": "search plugin not available"}
     except Exception as e:
         logger.exception("MCP search failed")
         return {"error": str(e)}