fix(audit): P0-P3 audit fixes — 838 ruff errors → 0, 30 F821 bugs fixed, 118 files changed
- P0: hooks.py 3-tuple fix, trigger_dispatcher Contract, contacts/plugin unregister_actions_by_owner - P0: 5 test files — check_permission mocks removed, hardcoded DB credential → env var - P1: attachment_service DmsFile via Contract helper, restore_registry/history_hooks dedup - P1: mail/plugin restore unregister, mcp_client datetime.now(UTC), saved_views/filters patterns - P1: ProtectedRoute fail-closed, 13 test assertion fixes (bcrypt, DB-URLs, SECRET_KEYs) - P2: deprecated notifications → post_system_message (3 files), forgejo Base, report_generator lazy import - P2: webhooks permissions, deps.py/roles.py plugin perms removed, import_export default - P2: address/tags/entity_links patterns removed, worker.py Contract-Umgehungen fixed - P2: 28 frontend TODOs (hardcoded constants, deprecated notification API) - P3: dead code, duplicates, deprecated imports, private attr, __import__ inline - P3: 8 frontend TODOs (LucideIcons, inline styles, XSS, i18n) - ruff: 838 → 0 (612 auto-fix + 246 manual + 27 F821 regression fix) - F821: 30 → 0 (AutomationDefinition, DmsFile, user_id, Path, Any, String) - Contract-Umgehungen: 2 neue gefunden (worker.py:169, worker.py:280) und gefixt
This commit is contained in:
@@ -25,7 +25,6 @@ import uuid
|
||||
from typing import Any
|
||||
|
||||
from sqlalchemy import select
|
||||
from sqlalchemy.ext.asyncio import AsyncSession
|
||||
|
||||
from app.core.db import create_db_session
|
||||
from app.core.job_registry import register_job
|
||||
@@ -76,9 +75,10 @@ async def generate_report_job(
|
||||
{"dms_file_id": ..., "filename": ..., "format": ..., "size": ...}
|
||||
"""
|
||||
import hashlib
|
||||
|
||||
from app.plugins.builtins.contracts import get_contract_registry
|
||||
_dms_contract = get_contract_registry().get("dms")
|
||||
DmsFile = _dms_contract.DmsFile
|
||||
dms_file = _dms_contract.dms_file
|
||||
|
||||
async with create_db_session() as db:
|
||||
# 1. Fetch template
|
||||
@@ -124,7 +124,7 @@ async def generate_report_job(
|
||||
storage = get_storage_backend()
|
||||
await storage.save(storage_path, raw_bytes)
|
||||
|
||||
dms_file = DmsFile(
|
||||
dms_file = dms_file(
|
||||
tenant_id=uuid.UUID(tenant_id),
|
||||
name=f"{template.name}.{ext}",
|
||||
folder_id=None,
|
||||
|
||||
Reference in New Issue
Block a user