fix(audit): P0-P3 audit fixes — 838 ruff errors → 0, 30 F821 bugs fixed, 118 files changed

- P0: hooks.py 3-tuple fix, trigger_dispatcher Contract, contacts/plugin unregister_actions_by_owner
- P0: 5 test files — check_permission mocks removed, hardcoded DB credential → env var
- P1: attachment_service DmsFile via Contract helper, restore_registry/history_hooks dedup
- P1: mail/plugin restore unregister, mcp_client datetime.now(UTC), saved_views/filters patterns
- P1: ProtectedRoute fail-closed, 13 test assertion fixes (bcrypt, DB-URLs, SECRET_KEYs)
- P2: deprecated notifications → post_system_message (3 files), forgejo Base, report_generator lazy import
- P2: webhooks permissions, deps.py/roles.py plugin perms removed, import_export default
- P2: address/tags/entity_links patterns removed, worker.py Contract-Umgehungen fixed
- P2: 28 frontend TODOs (hardcoded constants, deprecated notification API)
- P3: dead code, duplicates, deprecated imports, private attr, __import__ inline
- P3: 8 frontend TODOs (LucideIcons, inline styles, XSS, i18n)
- ruff: 838 → 0 (612 auto-fix + 246 manual + 27 F821 regression fix)
- F821: 30 → 0 (AutomationDefinition, DmsFile, user_id, Path, Any, String)
- Contract-Umgehungen: 2 neue gefunden (worker.py:169, worker.py:280) und gefixt

app/plugins/builtins/system_notif/plugin.py

@@ -6,7 +6,7 @@ import logging
 from typing import Any
 
 from app.plugins.base import BasePlugin
-from app.plugins.manifest import PluginManifest, FrontendSettingsPage
+from app.plugins.manifest import FrontendSettingsPage, PluginManifest
 
 logger = logging.getLogger(__name__)
 
@@ -47,7 +47,7 @@ class SystemNotifPlugin(BasePlugin):
         settings_pages=[
             FrontendSettingsPage(path='notifications', label_key='settings.notifications', label='Notifications', component='@/pages/SettingsNotifications', icon='Bell', order=40),
         ],
-    
+
         author="LeoCRM Team",
         min_app_version="1.0.0",
         contract_version="1.0.0")
@@ -60,8 +60,8 @@ class SystemNotifPlugin(BasePlugin):
         """Register as system participant and subscribe to events."""
         await super().on_activate(db, service_container, event_bus)
 
-        from app.plugins.builtins.system_notif.participant_handler import SystemParticipantHandler
         from app.plugins.builtins.kommunikation.contracts import get_participant_registry
+        from app.plugins.builtins.system_notif.participant_handler import SystemParticipantHandler
 
         self._system_handler = SystemParticipantHandler(service_container)
         registry = get_participant_registry()
@@ -231,13 +231,17 @@ class SystemNotifPlugin(BasePlugin):
 
             # Find the System room conversation
             from sqlalchemy import select
-            from app.plugins.builtins.kommunikation.contracts import CommConversation, CommParticipant
+
+            from app.plugins.builtins.kommunikation.contracts import (
+                CommConversation,
+                CommParticipant,
+            )
 
             result = await db.execute(
                 select(CommConversation).where(
                     CommConversation.tenant_id == tenant_id,
                     CommConversation.title == "System",
-                    CommConversation.is_locked == True,
+                    CommConversation.is_locked.is_(True),
                     CommConversation.locked_by == "system_notif",
                     CommConversation.deleted_at.is_(None),
                 ).join(CommParticipant, CommParticipant.conversation_id == CommConversation.id).where(