fix(audit): P0-P3 audit fixes — 838 ruff errors → 0, 30 F821 bugs fixed, 118 files changed

- P0: hooks.py 3-tuple fix, trigger_dispatcher Contract, contacts/plugin unregister_actions_by_owner
- P0: 5 test files — check_permission mocks removed, hardcoded DB credential → env var
- P1: attachment_service DmsFile via Contract helper, restore_registry/history_hooks dedup
- P1: mail/plugin restore unregister, mcp_client datetime.now(UTC), saved_views/filters patterns
- P1: ProtectedRoute fail-closed, 13 test assertion fixes (bcrypt, DB-URLs, SECRET_KEYs)
- P2: deprecated notifications → post_system_message (3 files), forgejo Base, report_generator lazy import
- P2: webhooks permissions, deps.py/roles.py plugin perms removed, import_export default
- P2: address/tags/entity_links patterns removed, worker.py Contract-Umgehungen fixed
- P2: 28 frontend TODOs (hardcoded constants, deprecated notification API)
- P3: dead code, duplicates, deprecated imports, private attr, __import__ inline
- P3: 8 frontend TODOs (LucideIcons, inline styles, XSS, i18n)
- ruff: 838 → 0 (612 auto-fix + 246 manual + 27 F821 regression fix)
- F821: 30 → 0 (AutomationDefinition, DmsFile, user_id, Path, Any, String)
- Contract-Umgehungen: 2 neue gefunden (worker.py:169, worker.py:280) und gefixt

app/plugins/builtins/tasks/jobs.py

@@ -3,7 +3,6 @@
 from __future__ import annotations
 
 import logging
-from datetime import datetime, timezone
 
 from app.core.db import get_session_factory
 
@@ -16,11 +15,12 @@ async def tasks_due_reminder(ctx: dict) -> None:
     Runs daily at 8:00 via cron. Finds all non-done tasks with due_date <= now
     and creates a notification for the assigned user.
     """
-    from app.plugins.builtins.tasks.services import get_due_tasks
-    from app.models.tenant import Tenant
-    from app.core.notifications import create_notification
     from sqlalchemy import select
 
+    from app.core.notifications import create_notification
+    from app.models.tenant import Tenant
+    from app.plugins.builtins.tasks.services import get_due_tasks
+
     factory = get_session_factory()
     async with factory() as db:
         result = await db.execute(select(Tenant))
@@ -62,6 +62,6 @@ async def tasks_due_reminder(ctx: dict) -> None:
 
 
 # Register all job functions with the job registry
-from app.core.job_registry import register_job
+from app.core.job_registry import register_job  # noqa: E402
 
 register_job("tasks_due_reminder", tasks_due_reminder)

app/plugins/builtins/tasks/plugin.py

@@ -4,11 +4,11 @@ from __future__ import annotations
 
 from app.plugins.base import BasePlugin
 from app.plugins.manifest import (
-    PluginManifest,
-    PluginRouteDef,
+    CronJobContribution,
     FrontendMenuItem,
     FrontendPageRoute,
-    CronJobContribution,
+    PluginManifest,
+    PluginRouteDef,
 )
 
 
@@ -62,17 +62,58 @@ class TasksPlugin(BasePlugin):
                 plugin_name="tasks",
             ),
         ],
-    
+
         author="LeoCRM Team",
         min_app_version="1.0.0",
         hooks=["contact.after_create"],
         contract_version="1.0.0")
 
+    def get_job_modules(self) -> list[str]:
+        return ["app.plugins.builtins.tasks.jobs"]
+
+    def get_entity_models(self) -> dict[str, type]:
+        from app.plugins.builtins.tasks.models import Task
+        return {"task": Task}
+
+    async def on_activate(self, db, service_container, event_bus) -> None:
+        """Activate plugin: register restore config + history hooks."""
+        await super().on_activate(db, service_container, event_bus)
+
+        # Register restore config for Task entities (P0-7 fix)
+        from app.core.restore_registry import RestoreConfig, get_restore_registry
+        from app.plugins.builtins.tasks.models import Task
+        get_restore_registry().register(RestoreConfig(
+            entity_type="task",
+            model_class=Task,
+            restore_permission="tasks:write",
+            excluded_fields=frozenset({"created_by", "assigned_to", "contact_id"}),
+        ))
+
+        # Register history hooks for Task entities (P0-8 fix)
+        from app.core.history_hooks import register_history_hooks
+        from app.core.hooks import get_hook_registry
+        register_history_hooks(
+            get_hook_registry(), "task",
+            "task.after_create", "task.after_update", "task.after_delete",
+            owner_tag="tasks",
+        )
+
     async def on_deactivate(
         self, db, service_container, event_bus
     ) -> None:
-        """Deactivate plugin: unregister contract and event listeners."""
+        """Deactivate plugin: unregister contract, restore, history, events."""
         # Contract abmelden
         from app.plugins.builtins.contracts import get_contract_registry
         get_contract_registry().unregister(self.manifest.name)
+
+        # Unregister restore config (P0-7 fix)
+        from app.core.restore_registry import get_restore_registry
+        get_restore_registry().unregister("task")
+
+        # Unregister history hooks (free functions, not bound methods)
+        from app.core.hooks import get_hook_registry
+        get_hook_registry().unregister_actions_by_owner("task.after_create", "tasks")
+        get_hook_registry().unregister_actions_by_owner("task.after_update", "tasks")
+        get_hook_registry().unregister_actions_by_owner("task.after_delete", "tasks")
+
         await super().on_deactivate(db, service_container, event_bus)

app/plugins/builtins/tasks/routes.py

@@ -8,7 +8,6 @@ from fastapi import APIRouter, Depends, HTTPException, Query, Response, status
 from sqlalchemy.ext.asyncio import AsyncSession
 
 from app.core.db import get_db
-from app.core.visibility import apply_visibility_filter
 from app.deps import get_current_user, require_permission
 from app.plugins.builtins.tasks import services
 from app.plugins.builtins.tasks.schemas import (

app/plugins/builtins/tasks/schemas.py

@@ -3,7 +3,6 @@
 from __future__ import annotations
 
 from datetime import datetime
-from typing import Any
 
 from pydantic import BaseModel, Field
 

app/plugins/builtins/tasks/services.py

@@ -3,7 +3,7 @@
 from __future__ import annotations
 
 import uuid
-from datetime import datetime, timezone
+from datetime import UTC, datetime
 from typing import Any
 
 from sqlalchemy import func, select
@@ -203,7 +203,7 @@ async def delete_task(db: AsyncSession, tenant_id: uuid.UUID, task_id: uuid.UUID
     await do_action("task.before_delete", db=db, tenant_id=tenant_id, task_id=str(task_id))
     # Capture snapshot before delete (D-PLUG)
     snapshot_before = _task_to_dict(task)
-    task.deleted_at = datetime.now(timezone.utc)
+    task.deleted_at = datetime.now(UTC)
     await db.flush()
     # Record history (D-PLUG)
     from app.services.entity_history_service import record_history as _rh
@@ -259,7 +259,7 @@ async def get_due_tasks(
     before: datetime | None = None,
 ) -> list[dict[str, Any]]:
     """Get tasks that are due (for ARQ reminder job)."""
-    now = before or datetime.now(timezone.utc)
+    now = before or datetime.now(UTC)
     result = await db.execute(
         select(Task).where(
             Task.tenant_id == tenant_id,