fix(audit): P0-P3 audit fixes — 838 ruff errors → 0, 30 F821 bugs fixed, 118 files changed
- P0: hooks.py 3-tuple fix, trigger_dispatcher Contract, contacts/plugin unregister_actions_by_owner - P0: 5 test files — check_permission mocks removed, hardcoded DB credential → env var - P1: attachment_service DmsFile via Contract helper, restore_registry/history_hooks dedup - P1: mail/plugin restore unregister, mcp_client datetime.now(UTC), saved_views/filters patterns - P1: ProtectedRoute fail-closed, 13 test assertion fixes (bcrypt, DB-URLs, SECRET_KEYs) - P2: deprecated notifications → post_system_message (3 files), forgejo Base, report_generator lazy import - P2: webhooks permissions, deps.py/roles.py plugin perms removed, import_export default - P2: address/tags/entity_links patterns removed, worker.py Contract-Umgehungen fixed - P2: 28 frontend TODOs (hardcoded constants, deprecated notification API) - P3: dead code, duplicates, deprecated imports, private attr, __import__ inline - P3: 8 frontend TODOs (LucideIcons, inline styles, XSS, i18n) - ruff: 838 → 0 (612 auto-fix + 246 manual + 27 F821 regression fix) - F821: 30 → 0 (AutomationDefinition, DmsFile, user_id, Path, Any, String) - Contract-Umgehungen: 2 neue gefunden (worker.py:169, worker.py:280) und gefixt
This commit is contained in:
@@ -4,11 +4,11 @@ from __future__ import annotations
|
||||
|
||||
from app.plugins.base import BasePlugin
|
||||
from app.plugins.manifest import (
|
||||
PluginManifest,
|
||||
PluginRouteDef,
|
||||
CronJobContribution,
|
||||
FrontendMenuItem,
|
||||
FrontendPageRoute,
|
||||
CronJobContribution,
|
||||
PluginManifest,
|
||||
PluginRouteDef,
|
||||
)
|
||||
|
||||
|
||||
@@ -62,17 +62,58 @@ class TasksPlugin(BasePlugin):
|
||||
plugin_name="tasks",
|
||||
),
|
||||
],
|
||||
|
||||
|
||||
author="LeoCRM Team",
|
||||
min_app_version="1.0.0",
|
||||
hooks=["contact.after_create"],
|
||||
contract_version="1.0.0")
|
||||
|
||||
def get_job_modules(self) -> list[str]:
|
||||
return ["app.plugins.builtins.tasks.jobs"]
|
||||
|
||||
def get_entity_models(self) -> dict[str, type]:
|
||||
from app.plugins.builtins.tasks.models import Task
|
||||
return {"task": Task}
|
||||
|
||||
async def on_activate(self, db, service_container, event_bus) -> None:
|
||||
"""Activate plugin: register restore config + history hooks."""
|
||||
await super().on_activate(db, service_container, event_bus)
|
||||
|
||||
# Register restore config for Task entities (P0-7 fix)
|
||||
from app.core.restore_registry import RestoreConfig, get_restore_registry
|
||||
from app.plugins.builtins.tasks.models import Task
|
||||
get_restore_registry().register(RestoreConfig(
|
||||
entity_type="task",
|
||||
model_class=Task,
|
||||
restore_permission="tasks:write",
|
||||
excluded_fields=frozenset({"created_by", "assigned_to", "contact_id"}),
|
||||
))
|
||||
|
||||
# Register history hooks for Task entities (P0-8 fix)
|
||||
from app.core.history_hooks import register_history_hooks
|
||||
from app.core.hooks import get_hook_registry
|
||||
register_history_hooks(
|
||||
get_hook_registry(), "task",
|
||||
"task.after_create", "task.after_update", "task.after_delete",
|
||||
owner_tag="tasks",
|
||||
)
|
||||
|
||||
async def on_deactivate(
|
||||
self, db, service_container, event_bus
|
||||
) -> None:
|
||||
"""Deactivate plugin: unregister contract and event listeners."""
|
||||
"""Deactivate plugin: unregister contract, restore, history, events."""
|
||||
# Contract abmelden
|
||||
from app.plugins.builtins.contracts import get_contract_registry
|
||||
get_contract_registry().unregister(self.manifest.name)
|
||||
|
||||
# Unregister restore config (P0-7 fix)
|
||||
from app.core.restore_registry import get_restore_registry
|
||||
get_restore_registry().unregister("task")
|
||||
|
||||
# Unregister history hooks (free functions, not bound methods)
|
||||
from app.core.hooks import get_hook_registry
|
||||
get_hook_registry().unregister_actions_by_owner("task.after_create", "tasks")
|
||||
get_hook_registry().unregister_actions_by_owner("task.after_update", "tasks")
|
||||
get_hook_registry().unregister_actions_by_owner("task.after_delete", "tasks")
|
||||
|
||||
await super().on_deactivate(db, service_container, event_bus)
|
||||
|
||||
Reference in New Issue
Block a user