fix(audit): P0-P3 audit fixes — 838 ruff errors → 0, 30 F821 bugs fixed, 118 files changed
- P0: hooks.py 3-tuple fix, trigger_dispatcher Contract, contacts/plugin unregister_actions_by_owner - P0: 5 test files — check_permission mocks removed, hardcoded DB credential → env var - P1: attachment_service DmsFile via Contract helper, restore_registry/history_hooks dedup - P1: mail/plugin restore unregister, mcp_client datetime.now(UTC), saved_views/filters patterns - P1: ProtectedRoute fail-closed, 13 test assertion fixes (bcrypt, DB-URLs, SECRET_KEYs) - P2: deprecated notifications → post_system_message (3 files), forgejo Base, report_generator lazy import - P2: webhooks permissions, deps.py/roles.py plugin perms removed, import_export default - P2: address/tags/entity_links patterns removed, worker.py Contract-Umgehungen fixed - P2: 28 frontend TODOs (hardcoded constants, deprecated notification API) - P3: dead code, duplicates, deprecated imports, private attr, __import__ inline - P3: 8 frontend TODOs (LucideIcons, inline styles, XSS, i18n) - ruff: 838 → 0 (612 auto-fix + 246 manual + 27 F821 regression fix) - F821: 30 → 0 (AutomationDefinition, DmsFile, user_id, Path, Any, String) - Contract-Umgehungen: 2 neue gefunden (worker.py:169, worker.py:280) und gefixt
This commit is contained in:
@@ -3,7 +3,7 @@
|
||||
from __future__ import annotations
|
||||
|
||||
import uuid
|
||||
from datetime import datetime, timezone
|
||||
from datetime import UTC, datetime
|
||||
from typing import Any
|
||||
|
||||
from sqlalchemy import func, select
|
||||
@@ -203,7 +203,7 @@ async def delete_task(db: AsyncSession, tenant_id: uuid.UUID, task_id: uuid.UUID
|
||||
await do_action("task.before_delete", db=db, tenant_id=tenant_id, task_id=str(task_id))
|
||||
# Capture snapshot before delete (D-PLUG)
|
||||
snapshot_before = _task_to_dict(task)
|
||||
task.deleted_at = datetime.now(timezone.utc)
|
||||
task.deleted_at = datetime.now(UTC)
|
||||
await db.flush()
|
||||
# Record history (D-PLUG)
|
||||
from app.services.entity_history_service import record_history as _rh
|
||||
@@ -259,7 +259,7 @@ async def get_due_tasks(
|
||||
before: datetime | None = None,
|
||||
) -> list[dict[str, Any]]:
|
||||
"""Get tasks that are due (for ARQ reminder job)."""
|
||||
now = before or datetime.now(timezone.utc)
|
||||
now = before or datetime.now(UTC)
|
||||
result = await db.execute(
|
||||
select(Task).where(
|
||||
Task.tenant_id == tenant_id,
|
||||
|
||||
Reference in New Issue
Block a user