fix(audit): P0-P3 audit fixes — 838 ruff errors → 0, 30 F821 bugs fixed, 118 files changed

- P0: hooks.py 3-tuple fix, trigger_dispatcher Contract, contacts/plugin unregister_actions_by_owner
- P0: 5 test files — check_permission mocks removed, hardcoded DB credential → env var
- P1: attachment_service DmsFile via Contract helper, restore_registry/history_hooks dedup
- P1: mail/plugin restore unregister, mcp_client datetime.now(UTC), saved_views/filters patterns
- P1: ProtectedRoute fail-closed, 13 test assertion fixes (bcrypt, DB-URLs, SECRET_KEYs)
- P2: deprecated notifications → post_system_message (3 files), forgejo Base, report_generator lazy import
- P2: webhooks permissions, deps.py/roles.py plugin perms removed, import_export default
- P2: address/tags/entity_links patterns removed, worker.py Contract-Umgehungen fixed
- P2: 28 frontend TODOs (hardcoded constants, deprecated notification API)
- P3: dead code, duplicates, deprecated imports, private attr, __import__ inline
- P3: 8 frontend TODOs (LucideIcons, inline styles, XSS, i18n)
- ruff: 838 → 0 (612 auto-fix + 246 manual + 27 F821 regression fix)
- F821: 30 → 0 (AutomationDefinition, DmsFile, user_id, Path, Any, String)
- Contract-Umgehungen: 2 neue gefunden (worker.py:169, worker.py:280) und gefixt

app/plugins/builtins/unified_search/plugin.py

@@ -7,7 +7,7 @@ import uuid
 from typing import Any
 
 from app.plugins.base import BasePlugin
-from app.plugins.manifest import PluginManifest, PluginRouteDef, FrontendPageRoute
+from app.plugins.manifest import FrontendPageRoute, PluginManifest, PluginRouteDef
 
 logger = logging.getLogger(__name__)
 
@@ -57,6 +57,11 @@ class UnifiedSearchPlugin(BasePlugin):
         contract_version="1.0.0",
     )
 
+    def get_job_modules(self) -> list[str]:
+        return [
+            "app.plugins.builtins.unified_search.jobs",
+        ]
+
     async def on_activate(self, db, service_container, event_bus) -> None:
         """Register search providers and AI tool on activation."""
         await super().on_activate(db, service_container, event_bus)
@@ -69,12 +74,14 @@ class UnifiedSearchPlugin(BasePlugin):
         except Exception:
             logger.exception("Failed to auto-register search providers")
 
-        # Register the unified_search AI tool
+        # Register the unified_search AI tool via contract
         try:
-            from app.plugins.builtins.ai_assistant.tool_registry import get_tool_registry
-            from app.plugins.builtins.unified_search.ai_tool import register_unified_search_tool
-            register_unified_search_tool(get_tool_registry())
-            logger.info("Unified Search AI tool registered")
+            from app.plugins.builtins.contracts import get_contract
+            ai_contract = get_contract("ai_assistant")
+            if ai_contract is not None:
+                from app.plugins.builtins.unified_search.ai_tool import register_unified_search_tool
+                register_unified_search_tool(ai_contract.get_tool_registry())
+                logger.info("Unified Search AI tool registered")
         except Exception:
             logger.exception("Failed to register unified_search AI tool")
 
@@ -172,8 +179,8 @@ class UnifiedSearchPlugin(BasePlugin):
 
     async def on_entity_deleted(self, payload: dict[str, Any]) -> None:
         """Handle entity.deleted lifecycle event — remove from search index."""
-        from app.plugins.builtins.unified_search.lifecycle import handle_entity_delete
         from app.core.db import get_session_factory
+        from app.plugins.builtins.unified_search.lifecycle import handle_entity_delete
 
         entity_type = payload.get("entity_type")
         entity_id = payload.get("entity_id")
@@ -188,8 +195,8 @@ class UnifiedSearchPlugin(BasePlugin):
 
     async def on_entity_restored(self, payload: dict[str, Any]) -> None:
         """Handle entity.restored lifecycle event — rebuild search index."""
-        from app.plugins.builtins.unified_search.lifecycle import handle_entity_restore
         from app.core.db import get_session_factory
+        from app.plugins.builtins.unified_search.lifecycle import handle_entity_restore
 
         entity_type = payload.get("entity_type")
         entity_id = payload.get("entity_id")
@@ -204,8 +211,8 @@ class UnifiedSearchPlugin(BasePlugin):
 
     async def on_entity_corrected(self, payload: dict[str, Any]) -> None:
         """Handle entity.corrected lifecycle event — rebuild search index."""
-        from app.plugins.builtins.unified_search.lifecycle import handle_entity_correction
         from app.core.db import get_session_factory
+        from app.plugins.builtins.unified_search.lifecycle import handle_entity_correction
 
         entity_type = payload.get("entity_type")
         entity_id = payload.get("entity_id")