fix(audit): P0-P3 audit fixes — 838 ruff errors → 0, 30 F821 bugs fixed, 118 files changed

- P0: hooks.py 3-tuple fix, trigger_dispatcher Contract, contacts/plugin unregister_actions_by_owner
- P0: 5 test files — check_permission mocks removed, hardcoded DB credential → env var
- P1: attachment_service DmsFile via Contract helper, restore_registry/history_hooks dedup
- P1: mail/plugin restore unregister, mcp_client datetime.now(UTC), saved_views/filters patterns
- P1: ProtectedRoute fail-closed, 13 test assertion fixes (bcrypt, DB-URLs, SECRET_KEYs)
- P2: deprecated notifications → post_system_message (3 files), forgejo Base, report_generator lazy import
- P2: webhooks permissions, deps.py/roles.py plugin perms removed, import_export default
- P2: address/tags/entity_links patterns removed, worker.py Contract-Umgehungen fixed
- P2: 28 frontend TODOs (hardcoded constants, deprecated notification API)
- P3: dead code, duplicates, deprecated imports, private attr, __import__ inline
- P3: 8 frontend TODOs (LucideIcons, inline styles, XSS, i18n)
- ruff: 838 → 0 (612 auto-fix + 246 manual + 27 F821 regression fix)
- F821: 30 → 0 (AutomationDefinition, DmsFile, user_id, Path, Any, String)
- Contract-Umgehungen: 2 neue gefunden (worker.py:169, worker.py:280) und gefixt

app/plugins/registry.py

@@ -4,6 +4,7 @@ from __future__ import annotations
 
 import importlib
 import logging
+from pathlib import Path
 from typing import Any
 
 from fastapi import FastAPI
@@ -31,9 +32,6 @@ class PluginRegistry:
         self._plugins: dict[str, BasePlugin] = {}
         # name -> PluginModel DB record (installed status)
         self._db_status: dict[str, PluginModel] = {}
-        # name -> list of actual route objects added to the FastAPI app
-        # (tracked by object identity to avoid cross-plugin route removal)
-        self._mounted_routes: dict[str, list[Any]] = {}
         self._engine: AsyncEngine | None = None
         self._event_bus: EventBus = get_event_bus()
         self._container: ServiceContainer = get_container()
@@ -531,8 +529,8 @@ class PluginRegistry:
             return existing
 
         # Check app version compatibility
-        from app.plugins.semver import SemVer
         from app.config import get_settings
+        from app.plugins.semver import SemVer
         settings = get_settings()
         app_version = getattr(settings, "app_version", "0.0.0")
         min_version = plugin.manifest.min_app_version
@@ -685,16 +683,9 @@ class PluginRegistry:
         # Call on_deactivate hook (unregisters event listeners)
         await plugin.on_deactivate(db, self._container, self._event_bus)
 
-        # Unregister only the specific route objects that belong to this plugin
-        # (by object identity, not by path — prevents cross-plugin route removal)
-        if self._app is not None and name in self._mounted_routes:
-            mounted_routes = self._mounted_routes.pop(name, [])
-            mounted_ids = {id(r) for r in mounted_routes}
-            self._app.router.routes = [
-                r
-                for r in self._app.router.routes
-                if id(r) not in mounted_ids
-            ]
+        # NOTE: Route removal is not implemented — routes stay mounted at runtime.
+        # The Gate model is used: require_active_plugin() returns 403 for inactive
+        # plugins. This is documented and intentional (see architecture-cleanup-plan.md).
 
         # Update DB record
         record.status = "inactive"