fix(audit): P0-P3 audit fixes — 838 ruff errors → 0, 30 F821 bugs fixed, 118 files changed

- P0: hooks.py 3-tuple fix, trigger_dispatcher Contract, contacts/plugin unregister_actions_by_owner
- P0: 5 test files — check_permission mocks removed, hardcoded DB credential → env var
- P1: attachment_service DmsFile via Contract helper, restore_registry/history_hooks dedup
- P1: mail/plugin restore unregister, mcp_client datetime.now(UTC), saved_views/filters patterns
- P1: ProtectedRoute fail-closed, 13 test assertion fixes (bcrypt, DB-URLs, SECRET_KEYs)
- P2: deprecated notifications → post_system_message (3 files), forgejo Base, report_generator lazy import
- P2: webhooks permissions, deps.py/roles.py plugin perms removed, import_export default
- P2: address/tags/entity_links patterns removed, worker.py Contract-Umgehungen fixed
- P2: 28 frontend TODOs (hardcoded constants, deprecated notification API)
- P3: dead code, duplicates, deprecated imports, private attr, __import__ inline
- P3: 8 frontend TODOs (LucideIcons, inline styles, XSS, i18n)
- ruff: 838 → 0 (612 auto-fix + 246 manual + 27 F821 regression fix)
- F821: 30 → 0 (AutomationDefinition, DmsFile, user_id, Path, Any, String)
- Contract-Umgehungen: 2 neue gefunden (worker.py:169, worker.py:280) und gefixt

app/routes/addresses.py

@@ -15,9 +15,20 @@ from app.services import address_service
 router = APIRouter(prefix="/api/v1/addresses", tags=["addresses"])
 
 
+def _validate_entity_type(entity_type: str) -> None:
+    """Validate entity_type against the ENTITY_MODELS registry."""
+    from app.services.entity_permission_service import ENTITY_MODELS
+
+    if entity_type not in ENTITY_MODELS:
+        raise HTTPException(
+            status_code=400,
+            detail={"detail": f"Invalid entity_type: {entity_type}", "code": "invalid_entity_type"},
+        )
+
+
 @router.get("")
 async def list_addresses(
-    entity_type: str = Query(..., pattern="^contact$"),
+    entity_type: str = Query(...),
     entity_id: str = Query(...),
     db: AsyncSession = Depends(get_db),
     current_user: dict = Depends(require_permission("addresses:read")),
@@ -27,6 +38,8 @@ async def list_addresses(
     user_id = uuid.UUID(current_user["user_id"])
     is_admin = current_user.get("is_system_admin", False)
 
+    _validate_entity_type(entity_type)
+
     try:
         eid = uuid.UUID(entity_id)
     except ValueError:
@@ -50,6 +63,7 @@ async def create_address(
     is_admin = current_user.get("is_system_admin", False)
 
     data = body.model_dump()
+    _validate_entity_type(data["entity_type"])
     try:
         return await address_service.create_address(db, tenant_id, user_id, data, is_system_admin=is_admin)
     except PermissionError as e: