fix(audit): P0-P3 audit fixes — 838 ruff errors → 0, 30 F821 bugs fixed, 118 files changed
- P0: hooks.py 3-tuple fix, trigger_dispatcher Contract, contacts/plugin unregister_actions_by_owner - P0: 5 test files — check_permission mocks removed, hardcoded DB credential → env var - P1: attachment_service DmsFile via Contract helper, restore_registry/history_hooks dedup - P1: mail/plugin restore unregister, mcp_client datetime.now(UTC), saved_views/filters patterns - P1: ProtectedRoute fail-closed, 13 test assertion fixes (bcrypt, DB-URLs, SECRET_KEYs) - P2: deprecated notifications → post_system_message (3 files), forgejo Base, report_generator lazy import - P2: webhooks permissions, deps.py/roles.py plugin perms removed, import_export default - P2: address/tags/entity_links patterns removed, worker.py Contract-Umgehungen fixed - P2: 28 frontend TODOs (hardcoded constants, deprecated notification API) - P3: dead code, duplicates, deprecated imports, private attr, __import__ inline - P3: 8 frontend TODOs (LucideIcons, inline styles, XSS, i18n) - ruff: 838 → 0 (612 auto-fix + 246 manual + 27 F821 regression fix) - F821: 30 → 0 (AutomationDefinition, DmsFile, user_id, Path, Any, String) - Contract-Umgehungen: 2 neue gefunden (worker.py:169, worker.py:280) und gefixt
This commit is contained in:
@@ -3,8 +3,7 @@
|
||||
from __future__ import annotations
|
||||
|
||||
import uuid
|
||||
from datetime import datetime, timedelta, timezone
|
||||
from typing import Any
|
||||
from datetime import UTC, datetime, timedelta
|
||||
|
||||
from fastapi import APIRouter, Depends, HTTPException, status
|
||||
from pydantic import BaseModel
|
||||
@@ -12,7 +11,7 @@ from sqlalchemy.ext.asyncio import AsyncSession
|
||||
|
||||
from app.core.api_token import create_api_token, list_api_tokens, revoke_api_token
|
||||
from app.core.db import get_db
|
||||
from app.deps import get_current_user, require_permission
|
||||
from app.deps import require_permission
|
||||
|
||||
router = APIRouter(prefix="/api/v1/tokens", tags=["api-tokens"])
|
||||
|
||||
@@ -39,7 +38,7 @@ async def create_token(
|
||||
|
||||
expires_at = None
|
||||
if body.expires_in_days is not None:
|
||||
expires_at = datetime.now(timezone.utc) + timedelta(days=body.expires_in_days)
|
||||
expires_at = datetime.now(UTC) + timedelta(days=body.expires_in_days)
|
||||
|
||||
result = await create_api_token(
|
||||
db, tenant_id, user_id, body.name, body.scopes, expires_at,
|
||||
@@ -71,7 +70,7 @@ async def revoke_token(
|
||||
try:
|
||||
tid = uuid.UUID(token_id)
|
||||
except ValueError:
|
||||
raise HTTPException(400, detail={"detail": "Invalid token_id", "code": "invalid_id"})
|
||||
raise HTTPException(400, detail={"detail": "Invalid token_id", "code": "invalid_id"}) from None
|
||||
revoked = await revoke_api_token(db, tenant_id, tid)
|
||||
if not revoked:
|
||||
raise HTTPException(404, detail={"detail": "Token not found or already revoked", "code": "not_found"})
|
||||
|
||||
Reference in New Issue
Block a user