fix(audit): P0-P3 audit fixes — 838 ruff errors → 0, 30 F821 bugs fixed, 118 files changed
- P0: hooks.py 3-tuple fix, trigger_dispatcher Contract, contacts/plugin unregister_actions_by_owner - P0: 5 test files — check_permission mocks removed, hardcoded DB credential → env var - P1: attachment_service DmsFile via Contract helper, restore_registry/history_hooks dedup - P1: mail/plugin restore unregister, mcp_client datetime.now(UTC), saved_views/filters patterns - P1: ProtectedRoute fail-closed, 13 test assertion fixes (bcrypt, DB-URLs, SECRET_KEYs) - P2: deprecated notifications → post_system_message (3 files), forgejo Base, report_generator lazy import - P2: webhooks permissions, deps.py/roles.py plugin perms removed, import_export default - P2: address/tags/entity_links patterns removed, worker.py Contract-Umgehungen fixed - P2: 28 frontend TODOs (hardcoded constants, deprecated notification API) - P3: dead code, duplicates, deprecated imports, private attr, __import__ inline - P3: 8 frontend TODOs (LucideIcons, inline styles, XSS, i18n) - ruff: 838 → 0 (612 auto-fix + 246 manual + 27 F821 regression fix) - F821: 30 → 0 (AutomationDefinition, DmsFile, user_id, Path, Any, String) - Contract-Umgehungen: 2 neue gefunden (worker.py:169, worker.py:280) und gefixt
This commit is contained in:
@@ -12,12 +12,12 @@ from datetime import UTC, datetime
|
||||
from typing import Any
|
||||
|
||||
from fastapi import APIRouter, Depends, HTTPException, Query, Response, status
|
||||
from sqlalchemy import select, func
|
||||
from sqlalchemy.orm import selectinload
|
||||
from sqlalchemy import func, select
|
||||
from sqlalchemy.ext.asyncio import AsyncSession
|
||||
from sqlalchemy.orm import selectinload
|
||||
|
||||
from app.core.db import get_db
|
||||
from app.deps import get_current_user, get_redis_dep, require_permission
|
||||
from app.deps import get_redis_dep, require_permission
|
||||
from app.models.audit import AuditLog
|
||||
from app.models.contact import Contact
|
||||
from app.services.entity_history_service import record_history
|
||||
@@ -44,8 +44,8 @@ def _serialize_company(c: Contact) -> dict[str, Any]:
|
||||
"mailing_country": c.mailing_country,
|
||||
"tags": c.tags,
|
||||
"custom": c.custom,
|
||||
|
||||
|
||||
|
||||
|
||||
}
|
||||
|
||||
|
||||
@@ -152,7 +152,7 @@ async def export_companies(
|
||||
try:
|
||||
import openpyxl
|
||||
except ImportError:
|
||||
raise HTTPException(status_code=500, detail="openpyxl not installed")
|
||||
raise HTTPException(status_code=500, detail="openpyxl not installed") from None
|
||||
wb = openpyxl.Workbook()
|
||||
ws = wb.active
|
||||
ws.title = "Companies"
|
||||
@@ -332,6 +332,7 @@ async def unlink_contact_from_company(
|
||||
raise HTTPException(status_code=404, detail="Company not found")
|
||||
# Remove ContactPerson link
|
||||
from sqlalchemy import delete as sa_delete
|
||||
|
||||
from app.models.contact import ContactPerson
|
||||
await db.execute(
|
||||
sa_delete(ContactPerson).where(
|
||||
|
||||
Reference in New Issue
Block a user