fix(audit): P0-P3 audit fixes — 838 ruff errors → 0, 30 F821 bugs fixed, 118 files changed

- P0: hooks.py 3-tuple fix, trigger_dispatcher Contract, contacts/plugin unregister_actions_by_owner
- P0: 5 test files — check_permission mocks removed, hardcoded DB credential → env var
- P1: attachment_service DmsFile via Contract helper, restore_registry/history_hooks dedup
- P1: mail/plugin restore unregister, mcp_client datetime.now(UTC), saved_views/filters patterns
- P1: ProtectedRoute fail-closed, 13 test assertion fixes (bcrypt, DB-URLs, SECRET_KEYs)
- P2: deprecated notifications → post_system_message (3 files), forgejo Base, report_generator lazy import
- P2: webhooks permissions, deps.py/roles.py plugin perms removed, import_export default
- P2: address/tags/entity_links patterns removed, worker.py Contract-Umgehungen fixed
- P2: 28 frontend TODOs (hardcoded constants, deprecated notification API)
- P3: dead code, duplicates, deprecated imports, private attr, __import__ inline
- P3: 8 frontend TODOs (LucideIcons, inline styles, XSS, i18n)
- ruff: 838 → 0 (612 auto-fix + 246 manual + 27 F821 regression fix)
- F821: 30 → 0 (AutomationDefinition, DmsFile, user_id, Path, Any, String)
- Contract-Umgehungen: 2 neue gefunden (worker.py:169, worker.py:280) und gefixt

app/routes/entity_permissions.py

@@ -3,9 +3,8 @@
 from __future__ import annotations
 
 import uuid
-from datetime import datetime
 
-from fastapi import APIRouter, Depends, HTTPException, Query, status
+from fastapi import APIRouter, Depends, HTTPException, status
 from sqlalchemy.ext.asyncio import AsyncSession
 
 from app.core.db import get_db
@@ -15,7 +14,7 @@ from app.schemas.entity_permission import (
     EntityPermissionCreate,
     EntityPermissionUpdate,
 )
-from app.services import entity_permission_service, bulk_permission_service
+from app.services import bulk_permission_service, entity_permission_service
 
 router = APIRouter(prefix="/api/v1/permissions", tags=["entity-permissions"])
 
@@ -38,7 +37,7 @@ async def list_entity_permissions(
             db, tenant_id, entity_type, entity_id
         )
     except ValueError as e:
-        raise HTTPException(status_code=400, detail=str(e))
+        raise HTTPException(status_code=400, detail=str(e)) from e
     return {"items": items, "total": len(items)}
 
 
@@ -83,7 +82,7 @@ async def create_entity_permission(
         )
         return result
     except ValueError as e:
-        raise HTTPException(status_code=400, detail=str(e))
+        raise HTTPException(status_code=400, detail=str(e)) from e
 
 
 async def _check_entity_ownership(
@@ -101,9 +100,10 @@ async def _check_entity_ownership(
     if is_system_admin:
         return
 
-    from app.models.entity_permission import ENTITY_MODELS
     from sqlalchemy import select
 
+    from app.models.entity_permission import ENTITY_MODELS
+
     model_info = ENTITY_MODELS.get(entity_type)
     if model_info is None:
         raise HTTPException(
@@ -171,7 +171,7 @@ async def update_entity_permission(
             body.expires_at,
         )
     except ValueError as e:
-        raise HTTPException(status_code=404, detail=str(e))
+        raise HTTPException(status_code=404, detail=str(e)) from e
 
 
 @router.delete("/{entity_type}/{entity_id}/{permission_id}", status_code=status.HTTP_204_NO_CONTENT)
@@ -193,7 +193,7 @@ async def delete_entity_permission(
     try:
         await entity_permission_service.delete_permission(db, tenant_id, permission_id)
     except ValueError as e:
-        raise HTTPException(status_code=404, detail=str(e))
+        raise HTTPException(status_code=404, detail=str(e)) from e
 
 
 @router.get("/{entity_type}/{entity_id}/access")
@@ -277,7 +277,7 @@ async def bulk_share_permissions(
         )
         return result
     except (ValueError, KeyError) as e:
-        raise HTTPException(status_code=400, detail=str(e))
+        raise HTTPException(status_code=400, detail=str(e)) from e
 
 
 @router.post("/bulk/unshare", status_code=status.HTTP_200_OK)
@@ -299,7 +299,7 @@ async def bulk_unshare_permissions(
         )
         return result
     except (ValueError, KeyError) as e:
-        raise HTTPException(status_code=400, detail=str(e))
+        raise HTTPException(status_code=400, detail=str(e)) from e
 
 
 @router.get("/analytics")
@@ -313,4 +313,4 @@ async def get_permission_analytics(
         result = await entity_permission_service.get_permission_analytics(db, tenant_id)
         return result
     except ValueError as e:
-        raise HTTPException(status_code=400, detail=str(e))
+        raise HTTPException(status_code=400, detail=str(e)) from e