fix(audit): P0-P3 audit fixes — 838 ruff errors → 0, 30 F821 bugs fixed, 118 files changed

- P0: hooks.py 3-tuple fix, trigger_dispatcher Contract, contacts/plugin unregister_actions_by_owner
- P0: 5 test files — check_permission mocks removed, hardcoded DB credential → env var
- P1: attachment_service DmsFile via Contract helper, restore_registry/history_hooks dedup
- P1: mail/plugin restore unregister, mcp_client datetime.now(UTC), saved_views/filters patterns
- P1: ProtectedRoute fail-closed, 13 test assertion fixes (bcrypt, DB-URLs, SECRET_KEYs)
- P2: deprecated notifications → post_system_message (3 files), forgejo Base, report_generator lazy import
- P2: webhooks permissions, deps.py/roles.py plugin perms removed, import_export default
- P2: address/tags/entity_links patterns removed, worker.py Contract-Umgehungen fixed
- P2: 28 frontend TODOs (hardcoded constants, deprecated notification API)
- P3: dead code, duplicates, deprecated imports, private attr, __import__ inline
- P3: 8 frontend TODOs (LucideIcons, inline styles, XSS, i18n)
- ruff: 838 → 0 (612 auto-fix + 246 manual + 27 F821 regression fix)
- F821: 30 → 0 (AutomationDefinition, DmsFile, user_id, Path, Any, String)
- Contract-Umgehungen: 2 neue gefunden (worker.py:169, worker.py:280) und gefixt

app/schemas/address.py

@@ -6,7 +6,7 @@ from pydantic import BaseModel, Field
 
 
 class AddressCreate(BaseModel):
-    entity_type: str = Field(..., pattern="^contact$", description="'contact'")
+    entity_type: str = Field(..., description="'contact'")
     entity_id: str = Field(..., description="UUID of the parent entity")
     label: str = Field(..., min_length=1, max_length=100)
     address_type: str = Field(

app/schemas/auth.py

@@ -3,6 +3,7 @@
 from __future__ import annotations
 
 from pydantic import BaseModel, EmailStr, Field, field_validator
+
 from app.schemas.user import _validate_password_complexity
 
 

app/schemas/common.py

@@ -19,6 +19,7 @@ class HealthResponse(BaseModel):
     checks: dict[str, Any] = {}
 
 
+# DEPRECATED: These schemas are for the legacy notification system. Use communication API schemas instead.
 class NotificationResponse(BaseModel):
     id: str
     type: str

app/schemas/contact.py

@@ -6,7 +6,6 @@ from decimal import Decimal
 
 from pydantic import BaseModel, Field
 
-
 # ── ContactPerson ──
 
 class ContactPersonCreate(BaseModel):

app/schemas/contact_folder.py

@@ -25,7 +25,7 @@ class ContactFolderResponse(BaseModel):
 
 
 class ContactFolderTreeResponse(ContactFolderResponse):
-    children: list["ContactFolderTreeResponse"] = Field(default_factory=list)
+    children: list[ContactFolderTreeResponse] = Field(default_factory=list)
     contact_count: int = 0
 
 

app/schemas/delegation.py

@@ -5,7 +5,7 @@ from __future__ import annotations
 from datetime import datetime
 from typing import Any
 
-from pydantic import BaseModel, Field
+from pydantic import BaseModel
 
 
 class DelegationCreate(BaseModel):

app/schemas/entity_policy.py

@@ -3,6 +3,7 @@
 from __future__ import annotations
 
 from typing import Any
+
 from pydantic import BaseModel
 
 

app/schemas/policy.py

@@ -2,7 +2,6 @@
 
 from __future__ import annotations
 
-from datetime import datetime
 from typing import Any
 
 from pydantic import BaseModel, Field

app/schemas/saved_filter.py

@@ -3,6 +3,7 @@
 from __future__ import annotations
 
 from typing import Any
+
 from pydantic import BaseModel
 
 

app/schemas/saved_view.py

@@ -3,6 +3,7 @@
 from __future__ import annotations
 
 from typing import Any
+
 from pydantic import BaseModel
 
 

app/schemas/system_settings.py

@@ -48,10 +48,6 @@ class SystemSettingsResponse(BaseModel):
     bic: str | None = None
     company_zip: str = ""
     company_country: str = ""
-    tax_number: str | None = None
-    vat_id: str | None = None
-    iban: str | None = None
-    bic: str | None = None
     bank_name: str | None = None
     ceo: str | None = None
     trade_register: str | None = None

app/schemas/user.py

@@ -3,6 +3,7 @@
 from __future__ import annotations
 
 import re
+
 from pydantic import BaseModel, EmailStr, Field, field_validator
 
 

app/schemas/user_preference.py

@@ -3,6 +3,7 @@
 from __future__ import annotations
 
 from typing import Any
+
 from pydantic import BaseModel