fix(audit): P0-P3 audit fixes — 838 ruff errors → 0, 30 F821 bugs fixed, 118 files changed
- P0: hooks.py 3-tuple fix, trigger_dispatcher Contract, contacts/plugin unregister_actions_by_owner - P0: 5 test files — check_permission mocks removed, hardcoded DB credential → env var - P1: attachment_service DmsFile via Contract helper, restore_registry/history_hooks dedup - P1: mail/plugin restore unregister, mcp_client datetime.now(UTC), saved_views/filters patterns - P1: ProtectedRoute fail-closed, 13 test assertion fixes (bcrypt, DB-URLs, SECRET_KEYs) - P2: deprecated notifications → post_system_message (3 files), forgejo Base, report_generator lazy import - P2: webhooks permissions, deps.py/roles.py plugin perms removed, import_export default - P2: address/tags/entity_links patterns removed, worker.py Contract-Umgehungen fixed - P2: 28 frontend TODOs (hardcoded constants, deprecated notification API) - P3: dead code, duplicates, deprecated imports, private attr, __import__ inline - P3: 8 frontend TODOs (LucideIcons, inline styles, XSS, i18n) - ruff: 838 → 0 (612 auto-fix + 246 manual + 27 F821 regression fix) - F821: 30 → 0 (AutomationDefinition, DmsFile, user_id, Path, Any, String) - Contract-Umgehungen: 2 neue gefunden (worker.py:169, worker.py:280) und gefixt
This commit is contained in:
@@ -3,15 +3,15 @@
|
||||
from __future__ import annotations
|
||||
|
||||
import uuid
|
||||
from typing import Any
|
||||
from datetime import UTC
|
||||
|
||||
from sqlalchemy import select, func, or_, text
|
||||
from sqlalchemy import func, select
|
||||
from sqlalchemy.ext.asyncio import AsyncSession
|
||||
from sqlalchemy.orm import selectinload
|
||||
|
||||
from app.core.hooks import apply_filters, do_action
|
||||
from app.models.contact import Contact, ContactPerson
|
||||
from app.services.entity_history_service import record_history
|
||||
from app.core.hooks import do_action, apply_filters
|
||||
|
||||
|
||||
def _compute_displayname(data: dict) -> str:
|
||||
@@ -243,7 +243,7 @@ async def get_contact(db: AsyncSession, tenant_id: uuid.UUID, contact_id: str,
|
||||
contact = result.scalar_one_or_none()
|
||||
if not contact:
|
||||
raise ValueError("Contact not found")
|
||||
|
||||
|
||||
# Check row-level access
|
||||
if user_id and not is_system_admin:
|
||||
from app.core.visibility import check_single_entity_access
|
||||
@@ -252,7 +252,7 @@ async def get_contact(db: AsyncSession, tenant_id: uuid.UUID, contact_id: str,
|
||||
)
|
||||
if not has_access:
|
||||
raise PermissionError("No access to this contact")
|
||||
|
||||
|
||||
return _serialize_contact_detail(contact)
|
||||
|
||||
|
||||
@@ -454,8 +454,8 @@ async def delete_contact(
|
||||
contact_full = result2.scalar_one()
|
||||
snapshot_before = _serialize_contact_detail(contact_full)
|
||||
|
||||
from datetime import datetime, timezone
|
||||
contact.deleted_at = datetime.now(timezone.utc)
|
||||
from datetime import datetime
|
||||
contact.deleted_at = datetime.now(UTC)
|
||||
await db.flush()
|
||||
|
||||
# Record history
|
||||
@@ -556,7 +556,7 @@ async def delete_contact_person(
|
||||
cp = result.scalar_one_or_none()
|
||||
if not cp:
|
||||
raise ValueError("Contact person not found")
|
||||
from datetime import datetime, timezone
|
||||
cp.deleted_at = datetime.now(timezone.utc)
|
||||
from datetime import datetime
|
||||
cp.deleted_at = datetime.now(UTC)
|
||||
await db.flush()
|
||||
|
||||
|
||||
Reference in New Issue
Block a user