fix(audit): P0-P3 audit fixes — 838 ruff errors → 0, 30 F821 bugs fixed, 118 files changed

- P0: hooks.py 3-tuple fix, trigger_dispatcher Contract, contacts/plugin unregister_actions_by_owner
- P0: 5 test files — check_permission mocks removed, hardcoded DB credential → env var
- P1: attachment_service DmsFile via Contract helper, restore_registry/history_hooks dedup
- P1: mail/plugin restore unregister, mcp_client datetime.now(UTC), saved_views/filters patterns
- P1: ProtectedRoute fail-closed, 13 test assertion fixes (bcrypt, DB-URLs, SECRET_KEYs)
- P2: deprecated notifications → post_system_message (3 files), forgejo Base, report_generator lazy import
- P2: webhooks permissions, deps.py/roles.py plugin perms removed, import_export default
- P2: address/tags/entity_links patterns removed, worker.py Contract-Umgehungen fixed
- P2: 28 frontend TODOs (hardcoded constants, deprecated notification API)
- P3: dead code, duplicates, deprecated imports, private attr, __import__ inline
- P3: 8 frontend TODOs (LucideIcons, inline styles, XSS, i18n)
- ruff: 838 → 0 (612 auto-fix + 246 manual + 27 F821 regression fix)
- F821: 30 → 0 (AutomationDefinition, DmsFile, user_id, Path, Any, String)
- Contract-Umgehungen: 2 neue gefunden (worker.py:169, worker.py:280) und gefixt

app/services/workflow_service.py

@@ -10,9 +10,9 @@ from sqlalchemy import desc, func, select
 from sqlalchemy.ext.asyncio import AsyncSession
 
 from app.core.audit import log_audit
-from app.models.notification import Notification
-from app.models.workflow import Workflow, WorkflowInstance, WorkflowStepHistory
+from app.core.notifications import post_system_message
 from app.core.visibility import apply_visibility_filter, check_single_entity_access
+from app.models.workflow import Workflow, WorkflowInstance, WorkflowStepHistory
 
 
 def _safe_iso(dt) -> str | None:
@@ -526,15 +526,14 @@ async def advance_instance(
 
         # Notify initiator
         if instance.initiated_by:
-            notification = Notification(
-                tenant_id=tenant_id,
-                user_id=instance.initiated_by,
-                type="workflow_rejected",
-                title=f"Workflow '{workflow.name}' rejected",
-                body=comment or f"Step {current_idx + 1} was rejected",
+            await post_system_message(
+                db,
+                tenant_id,
+                instance.initiated_by,
+                "workflow_rejected",
+                f"Workflow '{workflow.name}' rejected",
+                comment or f"Step {current_idx + 1} was rejected",
             )
-            db.add(notification)
-            await db.flush()
 
         await log_audit(
             db,
@@ -733,14 +732,14 @@ async def auto_reject_timeout(
 
     # Notify initiator
     if instance.initiated_by:
-        notification = Notification(
-            tenant_id=tenant_id,
-            user_id=instance.initiated_by,
-            type="workflow_timeout",
-            title=f"Workflow '{workflow.name if workflow else 'Unknown'}' auto-rejected",
-            body="The approval step timed out and was automatically rejected.",
+        await post_system_message(
+            db,
+            tenant_id,
+            instance.initiated_by,
+            "workflow_timeout",
+            f"Workflow '{workflow.name if workflow else 'Unknown'}' auto-rejected",
+            "The approval step timed out and was automatically rejected.",
         )
-        db.add(notification)
 
     await db.flush()
     await db.refresh(instance)