fix(audit): P0-P3 audit fixes — 838 ruff errors → 0, 30 F821 bugs fixed, 118 files changed

- P0: hooks.py 3-tuple fix, trigger_dispatcher Contract, contacts/plugin unregister_actions_by_owner
- P0: 5 test files — check_permission mocks removed, hardcoded DB credential → env var
- P1: attachment_service DmsFile via Contract helper, restore_registry/history_hooks dedup
- P1: mail/plugin restore unregister, mcp_client datetime.now(UTC), saved_views/filters patterns
- P1: ProtectedRoute fail-closed, 13 test assertion fixes (bcrypt, DB-URLs, SECRET_KEYs)
- P2: deprecated notifications → post_system_message (3 files), forgejo Base, report_generator lazy import
- P2: webhooks permissions, deps.py/roles.py plugin perms removed, import_export default
- P2: address/tags/entity_links patterns removed, worker.py Contract-Umgehungen fixed
- P2: 28 frontend TODOs (hardcoded constants, deprecated notification API)
- P3: dead code, duplicates, deprecated imports, private attr, __import__ inline
- P3: 8 frontend TODOs (LucideIcons, inline styles, XSS, i18n)
- ruff: 838 → 0 (612 auto-fix + 246 manual + 27 F821 regression fix)
- F821: 30 → 0 (AutomationDefinition, DmsFile, user_id, Path, Any, String)
- Contract-Umgehungen: 2 neue gefunden (worker.py:169, worker.py:280) und gefixt

app/workflows/engine.py

@@ -16,7 +16,7 @@ from sqlalchemy import select
 from sqlalchemy.ext.asyncio import AsyncSession
 
 from app.core.event_bus import get_event_bus
-from app.models.notification import Notification
+from app.core.notifications import post_system_message
 from app.models.workflow import Workflow, WorkflowInstance
 from app.services.workflow_service import (
     _instance_to_dict,
@@ -119,15 +119,14 @@ class WorkflowEngine:
                 str(instance.initiated_by) if instance.initiated_by else None
             )
             if user_id:
-                notification = Notification(
-                    tenant_id=self.tenant_id,
-                    user_id=uuid.UUID(user_id),
-                    type=config.get("notification_type", "workflow_action"),
-                    title=config.get("title", "Workflow notification"),
-                    body=config.get("body", ""),
+                await post_system_message(
+                    self.db,
+                    self.tenant_id,
+                    uuid.UUID(user_id),
+                    config.get("notification_type", "info"),
+                    config.get("notification_title", ""),
+                    config.get("notification_body", ""),
                 )
-                self.db.add(notification)
-                await self.db.flush()
 
         elif action_type == "noop":
             pass  # No operation — just advance
@@ -163,15 +162,14 @@ class WorkflowEngine:
         )
 
         if user_id:
-            notification = Notification(
-                tenant_id=self.tenant_id,
-                user_id=uuid.UUID(user_id),
-                type=config.get("notification_type", "workflow_notification"),
-                title=config.get("title", "Workflow notification"),
-                body=config.get("body", ""),
+            await post_system_message(
+                self.db,
+                self.tenant_id,
+                uuid.UUID(user_id),
+                config.get("notification_type", "workflow_notification"),
+                config.get("title", "Workflow notification"),
+                config.get("body", ""),
             )
-            self.db.add(notification)
-            await self.db.flush()
 
         await _log_step_history(
             self.db,