fix(audit): P0-P3 audit fixes — 838 ruff errors → 0, 30 F821 bugs fixed, 118 files changed
- P0: hooks.py 3-tuple fix, trigger_dispatcher Contract, contacts/plugin unregister_actions_by_owner - P0: 5 test files — check_permission mocks removed, hardcoded DB credential → env var - P1: attachment_service DmsFile via Contract helper, restore_registry/history_hooks dedup - P1: mail/plugin restore unregister, mcp_client datetime.now(UTC), saved_views/filters patterns - P1: ProtectedRoute fail-closed, 13 test assertion fixes (bcrypt, DB-URLs, SECRET_KEYs) - P2: deprecated notifications → post_system_message (3 files), forgejo Base, report_generator lazy import - P2: webhooks permissions, deps.py/roles.py plugin perms removed, import_export default - P2: address/tags/entity_links patterns removed, worker.py Contract-Umgehungen fixed - P2: 28 frontend TODOs (hardcoded constants, deprecated notification API) - P3: dead code, duplicates, deprecated imports, private attr, __import__ inline - P3: 8 frontend TODOs (LucideIcons, inline styles, XSS, i18n) - ruff: 838 → 0 (612 auto-fix + 246 manual + 27 F821 regression fix) - F821: 30 → 0 (AutomationDefinition, DmsFile, user_id, Path, Any, String) - Contract-Umgehungen: 2 neue gefunden (worker.py:169, worker.py:280) und gefixt
This commit is contained in:
@@ -42,9 +42,7 @@ async def test_ac2_copilot_execute_action_success(ai_client: AsyncClient, db_ses
|
||||
"/api/v1/ai/copilot/query",
|
||||
json={"query": "Create a company named TestCorp"},
|
||||
)
|
||||
assert query_resp.status_code in (200, 403)
|
||||
if query_resp.status_code == 403:
|
||||
return # RBAC blocked - expected
|
||||
assert query_resp.status_code == 200
|
||||
conv_id = query_resp.json()["conversation_id"]
|
||||
action = query_resp.json()["proposed_actions"][0]
|
||||
|
||||
@@ -74,9 +72,7 @@ async def test_ac3_copilot_execute_blocked_by_rbac(ai_client: AsyncClient, db_se
|
||||
"context": {"entity_id": "00000000-0000-0000-0000-000000000000"},
|
||||
},
|
||||
)
|
||||
assert query_resp.status_code in (200, 403)
|
||||
if query_resp.status_code == 403:
|
||||
return # RBAC blocked - expected
|
||||
assert query_resp.status_code == 200
|
||||
conv_id = query_resp.json()["conversation_id"]
|
||||
actions = query_resp.json()["proposed_actions"]
|
||||
assert len(actions) > 0
|
||||
|
||||
Reference in New Issue
Block a user