fix(audit): P0-P3 audit fixes — 838 ruff errors → 0, 30 F821 bugs fixed, 118 files changed
- P0: hooks.py 3-tuple fix, trigger_dispatcher Contract, contacts/plugin unregister_actions_by_owner - P0: 5 test files — check_permission mocks removed, hardcoded DB credential → env var - P1: attachment_service DmsFile via Contract helper, restore_registry/history_hooks dedup - P1: mail/plugin restore unregister, mcp_client datetime.now(UTC), saved_views/filters patterns - P1: ProtectedRoute fail-closed, 13 test assertion fixes (bcrypt, DB-URLs, SECRET_KEYs) - P2: deprecated notifications → post_system_message (3 files), forgejo Base, report_generator lazy import - P2: webhooks permissions, deps.py/roles.py plugin perms removed, import_export default - P2: address/tags/entity_links patterns removed, worker.py Contract-Umgehungen fixed - P2: 28 frontend TODOs (hardcoded constants, deprecated notification API) - P3: dead code, duplicates, deprecated imports, private attr, __import__ inline - P3: 8 frontend TODOs (LucideIcons, inline styles, XSS, i18n) - ruff: 838 → 0 (612 auto-fix + 246 manual + 27 F821 regression fix) - F821: 30 → 0 (AutomationDefinition, DmsFile, user_id, Path, Any, String) - Contract-Umgehungen: 2 neue gefunden (worker.py:169, worker.py:280) und gefixt
This commit is contained in:
@@ -396,12 +396,24 @@ class TestSensitiveFieldsExclusion:
|
||||
assert "admin_contactperson_id" in excluded
|
||||
|
||||
def test_dms_file_excludes_storage_path(self):
|
||||
"""DMS File should exclude storage_path, content_hash, size_bytes."""
|
||||
reset_restore_registry_for_testing()
|
||||
from app.core.restore_registry import register_default_entities
|
||||
"""DMS File should exclude storage_path, content_hash, size_bytes.
|
||||
|
||||
Plugin entities are registered by their plugins in on_activate(),
|
||||
not by register_default_entities() (P0-7 fix).
|
||||
"""
|
||||
reset_restore_registry_for_testing()
|
||||
from app.core.restore_registry import RestoreConfig, get_restore_registry
|
||||
from app.plugins.builtins.dms.models import File as DmsFile
|
||||
|
||||
register_default_entities()
|
||||
reg = get_restore_registry()
|
||||
reg.register(RestoreConfig(
|
||||
entity_type="dms_file",
|
||||
model_class=DmsFile,
|
||||
restore_permission="dms:write",
|
||||
excluded_fields=frozenset({
|
||||
"storage_path", "content_hash", "size_bytes", "uploaded_by", "folder_id",
|
||||
}),
|
||||
))
|
||||
config = reg.get("dms_file")
|
||||
|
||||
assert config is not None
|
||||
@@ -412,12 +424,26 @@ class TestSensitiveFieldsExclusion:
|
||||
assert "uploaded_by" in excluded
|
||||
|
||||
def test_mail_excludes_message_id_and_raw_path(self):
|
||||
"""Mail should exclude message_id, rfc822_size, raw_path."""
|
||||
reset_restore_registry_for_testing()
|
||||
from app.core.restore_registry import register_default_entities
|
||||
"""Mail should exclude message_id, rfc822_size, raw_path.
|
||||
|
||||
Plugin entities are registered by their plugins in on_activate(),
|
||||
not by register_default_entities() (P0-7 fix).
|
||||
"""
|
||||
reset_restore_registry_for_testing()
|
||||
from app.core.restore_registry import RestoreConfig, get_restore_registry
|
||||
from app.plugins.builtins.mail.plugin import _mail_restore_handler
|
||||
from app.plugins.builtins.mail.models import Mail
|
||||
|
||||
register_default_entities()
|
||||
reg = get_restore_registry()
|
||||
reg.register(RestoreConfig(
|
||||
entity_type="mail",
|
||||
model_class=Mail,
|
||||
restore_permission="mail:write",
|
||||
excluded_fields=frozenset({
|
||||
"message_id", "rfc822_size", "raw_path", "account_id", "folder_id",
|
||||
}),
|
||||
special_handler=_mail_restore_handler,
|
||||
))
|
||||
config = reg.get("mail")
|
||||
|
||||
assert config is not None
|
||||
@@ -428,7 +454,11 @@ class TestSensitiveFieldsExclusion:
|
||||
assert config.special_handler is not None
|
||||
|
||||
def test_all_default_entities_registered(self):
|
||||
"""register_default_entities should register all 5 entity types."""
|
||||
"""register_default_entities should register only Core entity types.
|
||||
|
||||
Plugin entities (task, calendar_entry, dms_file, mail) are registered
|
||||
by their respective plugins in on_activate() (P0-7 fix).
|
||||
"""
|
||||
reset_restore_registry_for_testing()
|
||||
from app.core.restore_registry import register_default_entities
|
||||
|
||||
@@ -436,8 +466,7 @@ class TestSensitiveFieldsExclusion:
|
||||
reg = get_restore_registry()
|
||||
registered = reg.list_registered()
|
||||
|
||||
# Only Core entity (contact) is registered by register_default_entities()
|
||||
assert "contact" in registered
|
||||
assert "task" in registered
|
||||
assert "calendar_entry" in registered
|
||||
assert "dms_file" in registered
|
||||
assert "mail" in registered
|
||||
# Plugin entities are registered by their plugins in on_activate()
|
||||
assert len(registered) == 1
|
||||
|
||||
Reference in New Issue
Block a user