fix(audit): P0-P3 audit fixes — 838 ruff errors → 0, 30 F821 bugs fixed, 118 files changed

- P0: hooks.py 3-tuple fix, trigger_dispatcher Contract, contacts/plugin unregister_actions_by_owner
- P0: 5 test files — check_permission mocks removed, hardcoded DB credential → env var
- P1: attachment_service DmsFile via Contract helper, restore_registry/history_hooks dedup
- P1: mail/plugin restore unregister, mcp_client datetime.now(UTC), saved_views/filters patterns
- P1: ProtectedRoute fail-closed, 13 test assertion fixes (bcrypt, DB-URLs, SECRET_KEYs)
- P2: deprecated notifications → post_system_message (3 files), forgejo Base, report_generator lazy import
- P2: webhooks permissions, deps.py/roles.py plugin perms removed, import_export default
- P2: address/tags/entity_links patterns removed, worker.py Contract-Umgehungen fixed
- P2: 28 frontend TODOs (hardcoded constants, deprecated notification API)
- P3: dead code, duplicates, deprecated imports, private attr, __import__ inline
- P3: 8 frontend TODOs (LucideIcons, inline styles, XSS, i18n)
- ruff: 838 → 0 (612 auto-fix + 246 manual + 27 F821 regression fix)
- F821: 30 → 0 (AutomationDefinition, DmsFile, user_id, Path, Any, String)
- Contract-Umgehungen: 2 neue gefunden (worker.py:169, worker.py:280) und gefixt

tests/test_user_service.py

@@ -35,8 +35,7 @@ class TestUserServiceCRUD:
         await login_client(client, "viewer@tenanta.com")
 
         resp = await client.get("/api/v1/users", headers=ORIGIN_HEADER)
-        # Viewer may have users:read permission by default in some configurations
-        assert resp.status_code in (200, 403)
+        assert resp.status_code == 403
 
     async def test_create_user_as_admin(self, client: AsyncClient, db_session):
         """Admin can create a new user in their tenant."""
@@ -79,25 +78,17 @@ class TestUserServiceCRUD:
         seed = await seed_tenant_and_users(db_session)
         await login_client(client, "admin@tenanta.com")
 
-        # The API may not catch IntegrityError, causing an unhandled exception
-        # This is a known bug — the test documents it
-        try:
-            resp = await client.post(
-                "/api/v1/users",
-                json={
-                    "email": "admin@tenanta.com",
-                    "name": "Duplicate",
-                    "password": "NewPass123!",
-                    "role": "viewer",
-                },
-                headers=ORIGIN_HEADER,
-            )
-            # If we get a response, it should be an error status
-            assert resp.status_code in (400, 409, 422, 500)
-        except Exception:
-            # IntegrityError propagates as unhandled exception — known bug
-            # The API should catch this and return 409
-            pass
+        resp = await client.post(
+            "/api/v1/users",
+            json={
+                "email": "admin@tenanta.com",
+                "name": "Duplicate",
+                "password": "NewPass123!",
+                "role": "viewer",
+            },
+            headers=ORIGIN_HEADER,
+        )
+        assert resp.status_code == 409
 
     async def test_update_user_as_admin(self, client: AsyncClient, db_session):
         """Admin can update a user."""