feat: notification preferences system with plugin registry
- Add NotificationType and NotificationPreference models
- Add get_notification_types() to BasePlugin for plugin registration
- Add sync_notification_types() to PluginRegistry
- Update create_notification() to check user preferences (returns Notification|None)
- Add API endpoints: GET /types, GET /preferences, PATCH /preferences/{type_key}
- Add NotificationPreferenceUpdate schema
- Mail plugin registers 10 notification types with metadata
- Add Alembic migration 0017 for new tables + seed data
- Frontend: SettingsNotifications page with toggle switches
- Frontend: Settings tab, route, hooks for notification preferences
- i18n: notification settings keys (de/en)
This commit is contained in:
@@ -72,6 +72,16 @@ class BasePlugin(ABC):
|
||||
"""
|
||||
return None
|
||||
|
||||
# ─── Notification Types ───
|
||||
|
||||
def get_notification_types(self) -> list[dict[str, Any]]:
|
||||
"""Return notification types this plugin registers.
|
||||
|
||||
Override in subclasses to register notification types.
|
||||
Each dict must have: type_key, category, label, description, is_enabled_by_default
|
||||
"""
|
||||
return []
|
||||
|
||||
# ─── Route Registration ───
|
||||
|
||||
def get_routes(self) -> list[APIRouter]:
|
||||
|
||||
@@ -4,6 +4,7 @@ from __future__ import annotations
|
||||
|
||||
import asyncio
|
||||
import logging
|
||||
from typing import Any
|
||||
|
||||
from app.plugins.base import BasePlugin
|
||||
from app.plugins.manifest import PluginManifest, PluginRouteDef
|
||||
@@ -59,6 +60,21 @@ class MailPlugin(BasePlugin):
|
||||
self._auto_sync_task = asyncio.create_task(_auto_sync_loop())
|
||||
logger.info("Mail plugin: auto-sync background task started")
|
||||
|
||||
def get_notification_types(self) -> list[dict[str, Any]]:
|
||||
"""Return the notification types this mail plugin registers."""
|
||||
return [
|
||||
{"type_key": "mail_new", "category": "mail", "label": "Neue E-Mail empfangen", "description": "Benachrichtigung bei neuen E-Mails", "is_enabled_by_default": True},
|
||||
{"type_key": "mail_error", "category": "mail", "label": "IMAP-Verbindungsfehler", "description": "Fehler bei der Verbindung zum Mailserver", "is_enabled_by_default": True},
|
||||
{"type_key": "mail_auth", "category": "mail", "label": "IMAP-Login-Fehler", "description": "Anmeldung am Mailserver fehlgeschlagen", "is_enabled_by_default": True},
|
||||
{"type_key": "mail_quota", "category": "mail", "label": "Postfach fast voll", "description": "Warnung bei hohem Postfach-Füllstand", "is_enabled_by_default": True},
|
||||
{"type_key": "mail_sync_error", "category": "mail", "label": "Sync-Fehler", "description": "Synchronisierung fehlgeschlagen", "is_enabled_by_default": True},
|
||||
{"type_key": "mail_sent", "category": "mail", "label": "E-Mail gesendet", "description": "Bestätigung beim Senden einer E-Mail", "is_enabled_by_default": False},
|
||||
{"type_key": "mail_send_error", "category": "mail", "label": "SMTP-Sendefehler", "description": "E-Mail konnte nicht gesendet werden", "is_enabled_by_default": True},
|
||||
{"type_key": "mail_draft", "category": "mail", "label": "Entwurf gespeichert", "description": "Bestätigung beim Speichern eines Entwurfs", "is_enabled_by_default": False},
|
||||
{"type_key": "mail_account", "category": "mail", "label": "Account deaktiviert", "description": "Warnung bei deaktiviertem Mail-Account", "is_enabled_by_default": True},
|
||||
{"type_key": "mail_folder", "category": "mail", "label": "Ordner erstellt/gelöscht", "description": "Bestätigung bei Ordner-Operationen", "is_enabled_by_default": False},
|
||||
]
|
||||
|
||||
async def on_deactivate(
|
||||
self, db, service_container, event_bus
|
||||
) -> None:
|
||||
|
||||
@@ -117,6 +117,73 @@ class PluginRegistry:
|
||||
"""List all discovered plugin names."""
|
||||
return list(self._plugins.keys())
|
||||
|
||||
# ── Notification Type Sync ──
|
||||
|
||||
async def sync_notification_types(self, db: AsyncSession) -> None:
|
||||
"""Sync notification types from all active plugins to DB.
|
||||
|
||||
For each active plugin, calls get_notification_types() and upserts
|
||||
the returned types into the notification_types table. Removes types
|
||||
belonging to plugins that are no longer active.
|
||||
"""
|
||||
from app.models.notification import NotificationType
|
||||
|
||||
# Collect all notification types from active plugins
|
||||
active_types: dict[str, dict[str, Any]] = {} # type_key -> type_data
|
||||
for name, plugin in self._plugins.items():
|
||||
record = await self._get_plugin_record(db, name)
|
||||
if record is None or not record.active:
|
||||
continue
|
||||
for nt in plugin.get_notification_types():
|
||||
key = nt.get("type_key", "")
|
||||
if not key:
|
||||
continue
|
||||
active_types[key] = {
|
||||
"type_key": key,
|
||||
"plugin_name": name,
|
||||
"category": nt.get("category", "general"),
|
||||
"label": nt.get("label", key),
|
||||
"description": nt.get("description"),
|
||||
"is_enabled_by_default": nt.get("is_enabled_by_default", True),
|
||||
}
|
||||
|
||||
# Fetch existing types from DB
|
||||
result = await db.execute(select(NotificationType))
|
||||
existing = {row.type_key: row for row in result.scalars().all()}
|
||||
|
||||
# Upsert active types
|
||||
for key, data in active_types.items():
|
||||
if key in existing:
|
||||
row = existing[key]
|
||||
row.plugin_name = data["plugin_name"]
|
||||
row.category = data["category"]
|
||||
row.label = data["label"]
|
||||
row.description = data["description"]
|
||||
row.is_enabled_by_default = data["is_enabled_by_default"]
|
||||
else:
|
||||
new_row = NotificationType(
|
||||
type_key=key,
|
||||
plugin_name=data["plugin_name"],
|
||||
category=data["category"],
|
||||
label=data["label"],
|
||||
description=data["description"],
|
||||
is_enabled_by_default=data["is_enabled_by_default"],
|
||||
)
|
||||
db.add(new_row)
|
||||
|
||||
# Remove types from plugins that are no longer active
|
||||
active_keys = set(active_types.keys())
|
||||
for key, row in existing.items():
|
||||
if key not in active_keys:
|
||||
# Check if the plugin is still active
|
||||
plugin_name = row.plugin_name
|
||||
plugin_record = await self._get_plugin_record(db, plugin_name)
|
||||
if plugin_record is None or not plugin_record.active:
|
||||
await db.delete(row)
|
||||
|
||||
await db.flush()
|
||||
logger.info("Synced %d notification types from active plugins", len(active_types))
|
||||
|
||||
# ── DB Status Sync ──
|
||||
|
||||
async def sync_db_status(self, db: AsyncSession) -> None:
|
||||
@@ -418,6 +485,9 @@ class PluginRegistry:
|
||||
mounted_routes.append(r)
|
||||
self._mounted_routes[name] = mounted_routes
|
||||
|
||||
# Sync notification types from this plugin
|
||||
await self.sync_notification_types(db)
|
||||
|
||||
# Update DB record
|
||||
record.status = "active"
|
||||
record.active = True
|
||||
|
||||
Reference in New Issue
Block a user