feat(audit): P1 cross-tenant/RBAC tests, P3 test fixes, P2/P3 frontend fixes
Check Cross-Plugin Imports / check (push) Has been cancelled
Check Cross-Plugin Imports / check (push) Has been cancelled
- P1-Tests: 12 test files with new cross-tenant isolation + RBAC tests - P3-Tests: 8 fixes (duplicate fixtures, sys.path.insert, unused imports, KeyError) - P3-Frontend: LucideIcons → ICON_MAP (2 files), inline styles → Tailwind (2 files) - P3-Frontend: DOMPurify for iframe XSS, redundant regex removed, console.log → console.debug - P2-Frontend: 2 notification API TODOs retained (requires larger refactor) - conftest.py: create_no_perm_user helper added - pyproject.toml: pythonpath for scripts/ added - All checks green: ruff 0, F821 0, tsc 0, app 495 routes, cross-plugin 0
This commit is contained in:
@@ -736,3 +736,38 @@ async def test_ac19_bulk_delete(authed_client):
|
||||
for fid in file_ids:
|
||||
resp = await client.get(f"/api/v1/dms/files/{fid}", headers=ORIGIN_HEADER)
|
||||
assert resp.status_code == 404
|
||||
|
||||
|
||||
# ─── Cross-tenant isolation test ───
|
||||
|
||||
|
||||
@pytest.mark.asyncio
|
||||
async def test_cross_tenant_dms_isolation(dms_app, db_session):
|
||||
"""File uploaded in tenant A is not visible to tenant B."""
|
||||
from httpx import ASGITransport, AsyncClient
|
||||
|
||||
from tests.conftest import seed_tenant_and_users
|
||||
|
||||
await seed_tenant_and_users(db_session)
|
||||
transport = ASGITransport(app=dms_app)
|
||||
|
||||
async with AsyncClient(transport=transport, base_url="http://test") as client_a:
|
||||
await login_client(client_a, "admin@tenanta.com")
|
||||
upload_resp = await client_a.post(
|
||||
"/api/v1/dms/files/upload",
|
||||
files={"file": ("tenant_a.pdf", PDF_CONTENT, "application/pdf")},
|
||||
headers=ORIGIN_HEADER,
|
||||
)
|
||||
assert upload_resp.status_code == 201
|
||||
file_id = upload_resp.json()["id"]
|
||||
|
||||
# Tenant B admin must not see tenant A's file in the list
|
||||
async with AsyncClient(transport=transport, base_url="http://test") as client_b:
|
||||
await login_client(client_b, "admin@tenantb.com")
|
||||
list_resp = await client_b.get("/api/v1/dms/files", headers=ORIGIN_HEADER)
|
||||
assert list_resp.status_code == 200
|
||||
assert all(f["id"] != file_id for f in list_resp.json())
|
||||
|
||||
# Direct access to tenant A's file → 404
|
||||
get_resp = await client_b.get(f"/api/v1/dms/files/{file_id}", headers=ORIGIN_HEADER)
|
||||
assert get_resp.status_code == 404
|
||||
|
||||
Reference in New Issue
Block a user