Files
leocrm/app/routes/contact_folder_permissions.py
T
Agent Zero abbe7a18fc fix(audit): P0-P3 audit fixes — 838 ruff errors → 0, 30 F821 bugs fixed, 118 files changed
- P0: hooks.py 3-tuple fix, trigger_dispatcher Contract, contacts/plugin unregister_actions_by_owner
- P0: 5 test files — check_permission mocks removed, hardcoded DB credential → env var
- P1: attachment_service DmsFile via Contract helper, restore_registry/history_hooks dedup
- P1: mail/plugin restore unregister, mcp_client datetime.now(UTC), saved_views/filters patterns
- P1: ProtectedRoute fail-closed, 13 test assertion fixes (bcrypt, DB-URLs, SECRET_KEYs)
- P2: deprecated notifications → post_system_message (3 files), forgejo Base, report_generator lazy import
- P2: webhooks permissions, deps.py/roles.py plugin perms removed, import_export default
- P2: address/tags/entity_links patterns removed, worker.py Contract-Umgehungen fixed
- P2: 28 frontend TODOs (hardcoded constants, deprecated notification API)
- P3: dead code, duplicates, deprecated imports, private attr, __import__ inline
- P3: 8 frontend TODOs (LucideIcons, inline styles, XSS, i18n)
- ruff: 838 → 0 (612 auto-fix + 246 manual + 27 F821 regression fix)
- F821: 30 → 0 (AutomationDefinition, DmsFile, user_id, Path, Any, String)
- Contract-Umgehungen: 2 neue gefunden (worker.py:169, worker.py:280) und gefixt
2026-08-16 01:17:18 +02:00

108 lines
3.6 KiB
Python

"""Contact folder permission routes — ACL management."""
from __future__ import annotations
import uuid
from fastapi import APIRouter, Depends, HTTPException, status
from sqlalchemy.ext.asyncio import AsyncSession
from app.core.db import get_db
from app.deps import require_permission
from app.schemas.contact_folder_permission import (
FolderPermissionCreate,
FolderPermissionUpdate,
)
from app.services import contact_folder_permission_service
router = APIRouter(prefix="/api/v1/contact-folders", tags=["contact-folder-permissions"])
@router.get("/{folder_id}/permissions")
async def list_folder_permissions(
folder_id: str,
db: AsyncSession = Depends(get_db),
current_user: dict = Depends(require_permission("contacts:read")),
):
"""List all permission entries for a folder."""
tenant_id = uuid.UUID(current_user["tenant_id"])
try:
items = await contact_folder_permission_service.list_permissions(db, tenant_id, folder_id)
except ValueError as e:
raise HTTPException(status_code=404, detail=str(e)) from e
return {"items": items, "total": len(items)}
@router.post("/{folder_id}/permissions", status_code=status.HTTP_201_CREATED)
async def create_folder_permission(
folder_id: str,
body: FolderPermissionCreate,
db: AsyncSession = Depends(get_db),
current_user: dict = Depends(require_permission("contacts:write")),
):
"""Grant or update a permission on a folder for a user or group."""
tenant_id = uuid.UUID(current_user["tenant_id"])
try:
return await contact_folder_permission_service.create_permission(
db,
tenant_id,
folder_id,
body.user_id,
body.group_id,
body.permission_level,
body.inherit_to_subfolders,
)
except ValueError as e:
raise HTTPException(status_code=400, detail=str(e)) from e
@router.put("/{folder_id}/permissions/{permission_id}")
async def update_folder_permission(
folder_id: str,
permission_id: str,
body: FolderPermissionUpdate,
db: AsyncSession = Depends(get_db),
current_user: dict = Depends(require_permission("contacts:write")),
):
"""Update an existing permission entry."""
tenant_id = uuid.UUID(current_user["tenant_id"])
try:
return await contact_folder_permission_service.update_permission(
db,
tenant_id,
permission_id,
body.permission_level,
body.inherit_to_subfolders,
)
except ValueError as e:
raise HTTPException(status_code=404, detail=str(e)) from e
@router.delete("/{folder_id}/permissions/{permission_id}", status_code=status.HTTP_204_NO_CONTENT)
async def delete_folder_permission(
folder_id: str,
permission_id: str,
db: AsyncSession = Depends(get_db),
current_user: dict = Depends(require_permission("contacts:write")),
):
"""Revoke a permission entry."""
tenant_id = uuid.UUID(current_user["tenant_id"])
try:
await contact_folder_permission_service.delete_permission(db, tenant_id, permission_id)
except ValueError as e:
raise HTTPException(status_code=404, detail=str(e)) from e
@router.get("/{folder_id}/access")
async def get_folder_access(
folder_id: str,
db: AsyncSession = Depends(get_db),
current_user: dict = Depends(require_permission("contacts:read")),
):
"""Get effective access level for the current user on a folder."""
tenant_id = uuid.UUID(current_user["tenant_id"])
user_id = uuid.UUID(current_user["user_id"])
return await contact_folder_permission_service.get_effective_access(
db, tenant_id, user_id, uuid.UUID(folder_id)
)