abbe7a18fc
- P0: hooks.py 3-tuple fix, trigger_dispatcher Contract, contacts/plugin unregister_actions_by_owner - P0: 5 test files — check_permission mocks removed, hardcoded DB credential → env var - P1: attachment_service DmsFile via Contract helper, restore_registry/history_hooks dedup - P1: mail/plugin restore unregister, mcp_client datetime.now(UTC), saved_views/filters patterns - P1: ProtectedRoute fail-closed, 13 test assertion fixes (bcrypt, DB-URLs, SECRET_KEYs) - P2: deprecated notifications → post_system_message (3 files), forgejo Base, report_generator lazy import - P2: webhooks permissions, deps.py/roles.py plugin perms removed, import_export default - P2: address/tags/entity_links patterns removed, worker.py Contract-Umgehungen fixed - P2: 28 frontend TODOs (hardcoded constants, deprecated notification API) - P3: dead code, duplicates, deprecated imports, private attr, __import__ inline - P3: 8 frontend TODOs (LucideIcons, inline styles, XSS, i18n) - ruff: 838 → 0 (612 auto-fix + 246 manual + 27 F821 regression fix) - F821: 30 → 0 (AutomationDefinition, DmsFile, user_id, Path, Any, String) - Contract-Umgehungen: 2 neue gefunden (worker.py:169, worker.py:280) und gefixt
57 lines
1.9 KiB
Python
57 lines
1.9 KiB
Python
"""System settings routes — get and upsert (admin only)."""
|
|
|
|
from __future__ import annotations
|
|
|
|
import uuid
|
|
|
|
from fastapi import APIRouter, Depends
|
|
from sqlalchemy.ext.asyncio import AsyncSession
|
|
|
|
from app.core.db import get_db
|
|
from app.deps import require_permission
|
|
from app.schemas.system_settings import SystemSettingsResponse, SystemSettingsUpsert
|
|
from app.services import system_settings_service
|
|
|
|
router = APIRouter(prefix="/api/v1/system-settings", tags=["system-settings"])
|
|
|
|
|
|
@router.get("", response_model=SystemSettingsResponse)
|
|
async def get_system_settings(
|
|
db: AsyncSession = Depends(get_db),
|
|
current_user: dict = Depends(require_permission("settings:read")),
|
|
):
|
|
"""Get system settings for the current tenant.
|
|
|
|
Sensitive fields (tax_number, iban, bic) are masked for non-admin users.
|
|
"""
|
|
tenant_id = uuid.UUID(current_user["tenant_id"])
|
|
result = await system_settings_service.get_system_settings(db, tenant_id)
|
|
if result is None:
|
|
return SystemSettingsResponse()
|
|
|
|
# Mask sensitive fields for non-admin users
|
|
if not current_user.get("is_system_admin"):
|
|
if hasattr(result, "tax_number") and result.tax_number:
|
|
result.tax_number = "********"
|
|
if hasattr(result, "iban") and result.iban:
|
|
result.iban = "********"
|
|
if hasattr(result, "bic") and result.bic:
|
|
result.bic = "********"
|
|
|
|
return result
|
|
|
|
|
|
@router.put("", response_model=SystemSettingsResponse)
|
|
async def upsert_system_settings(
|
|
body: SystemSettingsUpsert,
|
|
db: AsyncSession = Depends(get_db),
|
|
current_user: dict = Depends(require_permission("settings:write")),
|
|
):
|
|
"""Upsert system settings. Requires admin permission."""
|
|
tenant_id = uuid.UUID(current_user["tenant_id"])
|
|
user_id = uuid.UUID(current_user["user_id"])
|
|
|
|
|
|
data = body.model_dump()
|
|
return await system_settings_service.upsert_system_settings(db, tenant_id, user_id, data)
|