Files
leocrm/app/routes/contact_folders.py
T
Agent Zero abbe7a18fc fix(audit): P0-P3 audit fixes — 838 ruff errors → 0, 30 F821 bugs fixed, 118 files changed
- P0: hooks.py 3-tuple fix, trigger_dispatcher Contract, contacts/plugin unregister_actions_by_owner
- P0: 5 test files — check_permission mocks removed, hardcoded DB credential → env var
- P1: attachment_service DmsFile via Contract helper, restore_registry/history_hooks dedup
- P1: mail/plugin restore unregister, mcp_client datetime.now(UTC), saved_views/filters patterns
- P1: ProtectedRoute fail-closed, 13 test assertion fixes (bcrypt, DB-URLs, SECRET_KEYs)
- P2: deprecated notifications → post_system_message (3 files), forgejo Base, report_generator lazy import
- P2: webhooks permissions, deps.py/roles.py plugin perms removed, import_export default
- P2: address/tags/entity_links patterns removed, worker.py Contract-Umgehungen fixed
- P2: 28 frontend TODOs (hardcoded constants, deprecated notification API)
- P3: dead code, duplicates, deprecated imports, private attr, __import__ inline
- P3: 8 frontend TODOs (LucideIcons, inline styles, XSS, i18n)
- ruff: 838 → 0 (612 auto-fix + 246 manual + 27 F821 regression fix)
- F821: 30 → 0 (AutomationDefinition, DmsFile, user_id, Path, Any, String)
- Contract-Umgehungen: 2 neue gefunden (worker.py:169, worker.py:280) und gefixt
2026-08-16 01:17:18 +02:00

111 lines
3.7 KiB
Python

"""Contact folder routes — CRUD, move contacts, reorder."""
from __future__ import annotations
import uuid
from fastapi import APIRouter, Depends, HTTPException, status
from sqlalchemy.ext.asyncio import AsyncSession
from app.core.db import get_db
from app.deps import require_permission
from app.schemas.contact_folder import (
ContactFolderCreate,
ContactFolderUpdate,
MoveContactRequest,
)
from app.services import contact_folder_service
router = APIRouter(prefix="/api/v1/contact-folders", tags=["contact-folders"])
@router.get("")
async def list_folders(
db: AsyncSession = Depends(get_db),
current_user: dict = Depends(require_permission("contacts:read")),
):
"""List all contact folders for the current user."""
tenant_id = uuid.UUID(current_user["tenant_id"])
user_id = uuid.UUID(current_user["user_id"])
items = await contact_folder_service.list_folders(db, tenant_id, user_id)
return {"items": items, "total": len(items)}
@router.post("", status_code=status.HTTP_201_CREATED)
async def create_folder(
body: ContactFolderCreate,
db: AsyncSession = Depends(get_db),
current_user: dict = Depends(require_permission("contacts:write")),
):
"""Create a new contact folder."""
tenant_id = uuid.UUID(current_user["tenant_id"])
user_id = uuid.UUID(current_user["user_id"])
return await contact_folder_service.create_folder(
db, tenant_id, user_id, body.name, body.parent_id
)
@router.put("/{folder_id}")
async def update_folder(
folder_id: str,
body: ContactFolderUpdate,
db: AsyncSession = Depends(get_db),
current_user: dict = Depends(require_permission("contacts:write")),
):
"""Update a contact folder (name, parent, sort_order)."""
tenant_id = uuid.UUID(current_user["tenant_id"])
user_id = uuid.UUID(current_user["user_id"])
data = body.model_dump(exclude_none=True)
try:
return await contact_folder_service.update_folder(
db, tenant_id, user_id, folder_id, data
)
except ValueError as e:
raise HTTPException(status_code=404, detail=str(e)) from e
@router.delete("/{folder_id}", status_code=status.HTTP_204_NO_CONTENT)
async def delete_folder(
folder_id: str,
db: AsyncSession = Depends(get_db),
current_user: dict = Depends(require_permission("contacts:write")),
):
"""Delete a contact folder. Contacts are unassigned."""
tenant_id = uuid.UUID(current_user["tenant_id"])
user_id = uuid.UUID(current_user["user_id"])
try:
await contact_folder_service.delete_folder(db, tenant_id, user_id, folder_id)
except ValueError as e:
raise HTTPException(status_code=404, detail=str(e)) from e
@router.put("/{folder_id}/reorder")
async def reorder_folders(
folder_id: str,
body: list[dict],
db: AsyncSession = Depends(get_db),
current_user: dict = Depends(require_permission("contacts:write")),
):
"""Batch reorder folders. Body: [{id, sort_order, parent_id?}, ...]."""
tenant_id = uuid.UUID(current_user["tenant_id"])
user_id = uuid.UUID(current_user["user_id"])
await contact_folder_service.reorder_folders(db, tenant_id, user_id, body)
return {"ok": True}
@router.put("/contacts/{contact_id}/move")
async def move_contact(
contact_id: str,
body: MoveContactRequest,
db: AsyncSession = Depends(get_db),
current_user: dict = Depends(require_permission("contacts:write")),
):
"""Move a contact to a folder (or unassign with folder_id=null)."""
tenant_id = uuid.UUID(current_user["tenant_id"])
try:
return await contact_folder_service.move_contact(
db, tenant_id, contact_id, body.folder_id
)
except ValueError as e:
raise HTTPException(status_code=404, detail=str(e)) from e