abbe7a18fc
- P0: hooks.py 3-tuple fix, trigger_dispatcher Contract, contacts/plugin unregister_actions_by_owner - P0: 5 test files — check_permission mocks removed, hardcoded DB credential → env var - P1: attachment_service DmsFile via Contract helper, restore_registry/history_hooks dedup - P1: mail/plugin restore unregister, mcp_client datetime.now(UTC), saved_views/filters patterns - P1: ProtectedRoute fail-closed, 13 test assertion fixes (bcrypt, DB-URLs, SECRET_KEYs) - P2: deprecated notifications → post_system_message (3 files), forgejo Base, report_generator lazy import - P2: webhooks permissions, deps.py/roles.py plugin perms removed, import_export default - P2: address/tags/entity_links patterns removed, worker.py Contract-Umgehungen fixed - P2: 28 frontend TODOs (hardcoded constants, deprecated notification API) - P3: dead code, duplicates, deprecated imports, private attr, __import__ inline - P3: 8 frontend TODOs (LucideIcons, inline styles, XSS, i18n) - ruff: 838 → 0 (612 auto-fix + 246 manual + 27 F821 regression fix) - F821: 30 → 0 (AutomationDefinition, DmsFile, user_id, Path, Any, String) - Contract-Umgehungen: 2 neue gefunden (worker.py:169, worker.py:280) und gefixt
48 lines
1.8 KiB
Python
48 lines
1.8 KiB
Python
"""Plugin error isolation wrapper."""
|
|
import functools
|
|
import inspect
|
|
import logging
|
|
|
|
from fastapi import (
|
|
UploadFile, # noqa: F401 — needed for ForwardRef resolution
|
|
WebSocket, # noqa: F401 — needed for ForwardRef resolution
|
|
)
|
|
from fastapi.responses import JSONResponse
|
|
|
|
logger = logging.getLogger(__name__)
|
|
|
|
|
|
def wrap_plugin_route(handler):
|
|
"""Decorator that isolates plugin route errors and returns structured JSON.
|
|
|
|
Copies the original handler's signature so FastAPI sees the correct
|
|
parameters (path params, query params, body, etc.) instead of *args/**kwargs.
|
|
UploadFile and WebSocket are imported in this module's namespace so
|
|
FastAPI can resolve ForwardRef('UploadFile') and ForwardRef('WebSocket').
|
|
"""
|
|
@functools.wraps(handler)
|
|
async def wrapper(*args, **kwargs):
|
|
try:
|
|
return await handler(*args, **kwargs)
|
|
except Exception as exc:
|
|
logger.error(f'Plugin route error: {exc}', exc_info=True)
|
|
return JSONResponse(
|
|
status_code=500,
|
|
content={'detail': f'Plugin error: {exc}', 'code': 'plugin_error'}
|
|
)
|
|
# Remove __wrapped__ so FastAPI doesn't try to resolve the original signature
|
|
# through the wrapper chain — we set __signature__ explicitly instead.
|
|
if hasattr(wrapper, '__wrapped__'):
|
|
delattr(wrapper, '__wrapped__')
|
|
# Copy the signature from the original handler so FastAPI sees correct params.
|
|
# Keep __annotations__ from functools.wraps (needed for ForwardRef resolution).
|
|
# Remove only the return annotation to avoid response_model issues.
|
|
try:
|
|
orig_sig = inspect.signature(handler)
|
|
wrapper.__signature__ = orig_sig.replace(
|
|
return_annotation=inspect.Signature.empty,
|
|
)
|
|
except (ValueError, TypeError):
|
|
pass
|
|
return wrapper
|