Files
leocrm/app/core/auth.py
T
Agent Zero 604a2b7648 Phase 2: Fix high-priority security and stability issues (H1-H7)
H1: Sanitize error endpoint context (strip tokens/passwords, limit depth/size)
H2: Rate limiter IP spoofing fix (trusted proxy CIDR check for X-Forwarded-For)
H3: CSRF middleware uses Redis singleton instead of per-request connection
H4: WebSocket origin verification added to both kommunikation and ai_ui_control
H5: Storage path traversal protection, get_url() returns relative URL not filesystem path
H6: Security headers middleware (HSTS, X-Content-Type-Options, X-Frame-Options, CSP, Referrer-Policy)
H7: Forward-repair migration 0045 for databases that ran original 0021/0027

Also: add trusted_proxy_cidrs to config, add verify_ws_origin to auth
2026-07-26 20:49:15 +02:00

246 lines
7.3 KiB
Python

"""Session-based authentication, password hashing, and RBAC."""
from __future__ import annotations
import hashlib
import secrets
import uuid
from datetime import UTC, datetime, timedelta
from typing import Any
import logging
import redis.asyncio as aioredis
from passlib.context import CryptContext
from sqlalchemy.ext.asyncio import AsyncSession
from app.config import get_settings
from app.models.session import Session as SessionModel
from app.models.user import User
logger = logging.getLogger(__name__)
_pwd_context = CryptContext(
schemes=["bcrypt"], deprecated="auto", bcrypt__rounds=get_settings().bcrypt_rounds
)
# ── Global Redis client singleton ────────────────────────────────────────────
_redis_client: aioredis.Redis | None = None
async def init_redis() -> aioredis.Redis:
"""Create and store the global Redis client. Called once during app lifespan startup."""
global _redis_client
if _redis_client is not None:
logger.warning("init_redis() called but Redis client already initialized")
return _redis_client
_redis_client = aioredis.from_url(
get_settings().redis_url, decode_responses=True
)
logger.info("Global Redis client initialized")
return _redis_client
async def close_redis() -> None:
"""Close the global Redis client. Called during app lifespan shutdown."""
global _redis_client
if _redis_client is not None:
await _redis_client.aclose()
_redis_client = None
logger.info("Global Redis client closed")
def get_redis() -> aioredis.Redis:
"""Return the global Redis client singleton.
If init_redis() has not been called yet (e.g. during testing or
outside the app lifespan), a new client is created lazily so callers
always get a working connection.
"""
global _redis_client
if _redis_client is None:
_redis_client = aioredis.from_url(
get_settings().redis_url, decode_responses=True
)
logger.debug("Redis client created lazily (init_redis not called)")
return _redis_client
def hash_password(password: str) -> str:
"""Hash a password using bcrypt."""
return _pwd_context.hash(password)
def verify_password(password: str, password_hash: str) -> bool:
"""Verify a password against a bcrypt hash."""
return _pwd_context.verify(password, password_hash)
def generate_session_token() -> str:
"""Generate a cryptographically secure session token."""
return secrets.token_urlsafe(32)
def generate_csrf_token() -> str:
"""Generate a CSRF token."""
return secrets.token_urlsafe(32)
def hash_token(token: str) -> str:
"""SHA-256 hash a token for storage."""
return hashlib.sha256(token.encode()).hexdigest()
def verify_ws_origin(websocket) -> bool:
"""Verify that the WebSocket upgrade request comes from an allowed origin.
Checks the Origin header against the configured CORS origins.
Returns True if the origin is allowed or if no CORS restriction is configured.
"""
from app.config import get_settings
settings = get_settings()
allowed_origins = settings.cors_origin_list
if not allowed_origins:
return True
origin = websocket.headers.get("origin", "")
if not origin:
return True # Non-browser clients don't send Origin
return origin in allowed_origins
async def create_session(
db: AsyncSession,
redis: aioredis.Redis,
user: User,
tenant_id: uuid.UUID,
role: str = "viewer",
) -> tuple[str, str]:
"""Create a session in Redis (runtime) and PostgreSQL (audit trail).
Returns (session_id, csrf_token).
``role`` comes from UserTenant — the built-in role string for the
active tenant membership.
"""
settings = get_settings()
session_id = str(uuid.uuid4())
csrf_token = generate_csrf_token()
expires_at = datetime.now(UTC) + timedelta(seconds=settings.session_ttl_seconds)
# Redis runtime session
session_data: dict[str, Any] = {
"user_id": str(user.id),
"tenant_id": str(tenant_id),
"email": user.email,
"name": user.name,
"role": role,
"is_system_admin": user.is_system_admin,
"csrf_token": csrf_token,
"is_active": user.is_active,
}
import json
await redis.setex(
f"session:{session_id}",
settings.session_ttl_seconds,
json.dumps(session_data),
)
# PostgreSQL audit trail
audit_record = SessionModel(
id=uuid.UUID(session_id),
user_id=user.id,
tenant_id=tenant_id,
csrf_token=csrf_token,
expires_at=expires_at,
)
db.add(audit_record)
await db.flush()
return session_id, csrf_token
async def get_session_data(redis: aioredis.Redis, session_id: str) -> dict[str, Any] | None:
"""Retrieve session data from Redis."""
import json
raw = await redis.get(f"session:{session_id}")
if raw is None:
return None
return json.loads(raw)
async def refresh_session_ttl(redis: aioredis.Redis, session_id: str) -> None:
"""Extend the Redis session TTL on activity (sliding session)."""
settings = get_settings()
await redis.expire(f"session:{session_id}", settings.session_ttl_seconds)
async def invalidate_session(redis: aioredis.Redis, session_id: str) -> None:
"""Delete a session from Redis (logout). PostgreSQL record persists."""
await redis.delete(f"session:{session_id}")
async def update_session_tenant(
redis: aioredis.Redis,
session_id: str,
new_tenant_id: uuid.UUID,
role: str | None = None,
) -> dict[str, Any] | None:
"""Update the active tenant (and optionally role) in a Redis session."""
import json
settings = get_settings()
raw = await redis.get(f"session:{session_id}")
if raw is None:
return None
data = json.loads(raw)
data["tenant_id"] = str(new_tenant_id)
if role is not None:
data["role"] = role
ttl = await redis.ttl(f"session:{session_id}")
if ttl <= 0:
ttl = settings.session_ttl_seconds
await redis.setex(f"session:{session_id}", ttl, json.dumps(data))
return data
def check_permission(
role_name: str, module: str, action: str, permissions: dict | None = None
) -> bool:
"""Check if a role has permission for a module+action.
Built-in roles: admin (all), editor (read+write), viewer (read only).
Custom roles use the permissions dict.
"""
if role_name == "admin":
return True
if role_name == "editor":
if action in ("read", "write", "create", "update"):
return True
return False
if role_name == "viewer":
return action == "read"
# Custom role — check permissions dict
if permissions:
module_perms = permissions.get(module, {})
return bool(module_perms.get(action, False))
return False
def filter_fields_by_permission(
data: dict[str, Any],
field_permissions: dict[str, str],
role_name: str,
) -> dict[str, Any]:
"""Filter response fields based on field-level permissions.
field_permissions: {"annual_revenue": "hidden"} → removed for non-admin.
"""
if role_name == "admin":
return data
result = {}
for key, value in data.items():
perm = field_permissions.get(key)
if perm == "hidden":
continue
result[key] = value
return result